From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E495C38A2D for ; Tue, 25 Oct 2022 02:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9747980008; Mon, 24 Oct 2022 22:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 924A880007; Mon, 24 Oct 2022 22:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8139B80008; Mon, 24 Oct 2022 22:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7359880007 for ; Mon, 24 Oct 2022 22:53:08 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 40C98C0849 for ; Tue, 25 Oct 2022 02:53:08 +0000 (UTC) X-FDA: 80057950056.02.111EEC0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf21.hostedemail.com (Postfix) with ESMTP id D4EAB1C0006 for ; Tue, 25 Oct 2022 02:53:05 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MxGZw2bxcz15M0R; Tue, 25 Oct 2022 10:48:08 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 10:52:59 +0800 Subject: Re: [PATCH 1/3] mm: memory-failure: make put_ref_page() more useful To: Kefeng Wang CC: , , Naoya Horiguchi , Andrew Morton References: <20221021084611.53765-1-wangkefeng.wang@huawei.com> From: Miaohe Lin Message-ID: <96b39919-7054-7378-a6ab-a20401458d7c@huawei.com> Date: Tue, 25 Oct 2022 10:52:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221021084611.53765-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666666387; a=rsa-sha256; cv=none; b=gGATHYmm850Ra7X3QcR2hQGmBUr5D75qYfDWDYmm8SXoQ8O7DjakWzynFowSvmNEpJRUdX uaBn+1qgokc2VppXM1WMN3eFP2tK3DpJqf+2vRkFO3PrpSrOt0LeS7TWRBFpyKdJEq4slw e5js4X17tadInchH60+7P2Deb3XQ024= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666666387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ak/ZuE7sRZ6eQS2vVpXIe5ovLLjcDDRj+9WaqFV6pkc=; b=8EO5b0nrQy0DyswTSyQHQyN4LtQspvcff99F081/Qb4VkOWUzt8V2HrJ737ssg3uFtYaRn G3uGDZK8gn1yK/4lZ+O75XT3ThjKwV8B7RIpSk5RwrwOwGQWGFEa+fH+p6eX/H2uVLpXR7 TiraA5Uv42HXfWXsOspLjlitgJ/9wfg= X-Rspamd-Queue-Id: D4EAB1C0006 Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: zo96jnbnhao55ynmrsaoumfjwhs418pm X-HE-Tag: 1666666385-759952 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/21 16:46, Kefeng Wang wrote: > Pass pfn/flags to put_ref_page(), then check MF_COUNT_INCREASED > and drop refcount to make the code look cleaner. > > Signed-off-by: Kefeng Wang > --- > mm/memory-failure.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index bead6bccc7f2..b94152abb1c9 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1913,17 +1913,25 @@ static inline unsigned long free_raw_hwp_pages(struct page *hpage, bool flag) > } > #endif /* CONFIG_HUGETLB_PAGE */ > > +/* Drop the extra refcount in case we come from madvise() */ > +static void put_ref_page(unsigned long pfn, int flags) > +{ > + struct page *page; > + > + if (!(flags & MF_COUNT_INCREASED)) > + return; > + > + page = pfn_to_page(pfn); > + if (page) IMO above check is unneeded. Page can't be NULL as pfn is valid. But this is trival and this patch looks good to me. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin