From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5113C54EBD for ; Mon, 9 Jan 2023 11:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2BD8E0002; Mon, 9 Jan 2023 06:35:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B63A08E0001; Mon, 9 Jan 2023 06:35:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A046A8E0002; Mon, 9 Jan 2023 06:35:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C8528E0001 for ; Mon, 9 Jan 2023 06:35:25 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E848AA839 for ; Mon, 9 Jan 2023 11:35:25 +0000 (UTC) X-FDA: 80335055010.16.FCD9F25 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 0B2DD8000A for ; Mon, 9 Jan 2023 11:35:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UMVHZPxP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673264123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qpEBm03GdEu7pr5mXkVVNIA5JjlbFFPvXuYilU99v3Q=; b=XH/5eI6nG0ORJQPPkOt+ZPgQIq426imDEBE5/QTyE4gcnVgrOi06RPLkev0M4C42jI5duu qTc1a7K8d70Enwlo0f/SjvF33s3xhU/FFYXcycO0NQkjucKa7r1YOznUQyacAm5tKQl5K/ w6w8qCeB+ObdYGIUoXTmP0vH4wN9GiM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UMVHZPxP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673264123; a=rsa-sha256; cv=none; b=AaZyDggOfsZL+g51wT59dnzgJ8+a7tXmjev+Qplb1+/zOEVWiAYEO5ZeIAFNN4ZD5lBfhB UwrKXzcew3Uk/q1sE1FJfEGMkuYLxdblVHOCn/wvZd/hB0Y2uQoKiAO6/t0FvDDl2tnJFo 0W8xzUfW4xp2458t23BKnZPPQHhbnAM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673264122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qpEBm03GdEu7pr5mXkVVNIA5JjlbFFPvXuYilU99v3Q=; b=UMVHZPxPrsJCbz7JO3u87Tv4gwkNnwIiEknGK9gtjjCFpPN1G/ecdO7ol15T5ZMa067/SZ HaPzI7rloZdGfOy6Vg2OcK+83pTxPHVaAGT4enR1UaUqgySMcMckNPXNY4c/Xtq79jtTgF Ii1R7X/ySPmNegnS5knhSIoA/6Ry1s4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-600-9-YhSVnjMT6DVN750gmjeg-1; Mon, 09 Jan 2023 06:35:21 -0500 X-MC-Unique: 9-YhSVnjMT6DVN750gmjeg-1 Received: by mail-pj1-f72.google.com with SMTP id h12-20020a17090a604c00b00225b2dbe4cfso2982143pjm.1 for ; Mon, 09 Jan 2023 03:35:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qpEBm03GdEu7pr5mXkVVNIA5JjlbFFPvXuYilU99v3Q=; b=77Us/xETQTv7+4EwdXv7hJSGgcGmaf2jEwrHsyWkeazEIcchBe/K8kqW0vBtRAo6be 00CW3wKmVOM+6YvsvqoIGGd8//YMdvahzb1AXW0LExQvGpBDE9ouQcr2YGLm5kcTJY6H H4wPZgbMeMIzrC9vsrcqk1FD3t0atoWBTQpGFgOlKkk9gtfbu1kOC2c393tSb16jmW3N /RNY+97VOzXQSbtWGnCPhay1mVgF9FQGJi/xpmg48GGYK8fHB+X68m2zVHCLgVcpyCZV INYw06V93TVQR+ylDlV/Bxtd7jYDwMTe7BLA+BGki9vJq2roFPciDJx/epq0b0Nppjku FA4A== X-Gm-Message-State: AFqh2krb0REvGlPBe/B94eA326V1cA3PMrA+SaPmmuG0cq/qgysvReN5 G8JXWw1nGcRFyyCBBqi0Kxn7mBIXZqu4dgzkkhot+iP2s6n2Qch0+2SWbCUM267IrIWVYXGbgj8 aosokyHVaRgA= X-Received: by 2002:a17:903:2341:b0:192:5e53:15f3 with SMTP id c1-20020a170903234100b001925e5315f3mr86887075plh.48.1673264120084; Mon, 09 Jan 2023 03:35:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXsPab4Pvw2BslAilX4Y9tDoSZq+7jkg+ZkEM1xBntD65o5ZDnZDYwzMUhtc4el7KFSVwOpO3A== X-Received: by 2002:a17:903:2341:b0:192:5e53:15f3 with SMTP id c1-20020a170903234100b001925e5315f3mr86887051plh.48.1673264119792; Mon, 09 Jan 2023 03:35:19 -0800 (PST) Received: from [10.72.12.50] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k11-20020a170902c40b00b001894198d0ebsm5953735plk.24.2023.01.09.03.35.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 03:35:19 -0800 (PST) Message-ID: <96a670f1-a4ae-e07a-d630-7fcfcda86917@redhat.com> Date: Mon, 9 Jan 2023 19:35:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 0/3] add folio_headpage() macro To: SeongJae Park , Andrew Morton Cc: willy@infradead.org, Ilya Dryomov , Jeff Layton , linux-mm@kvack.org, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230106174028.151384-1-sj@kernel.org> From: Xiubo Li In-Reply-To: <20230106174028.151384-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0B2DD8000A X-Stat-Signature: tyf1otw6ta6dryzxs1zwxw9gg5xhtta7 X-HE-Tag: 1673264122-164901 X-HE-Meta: U2FsdGVkX188wCdfYwwjiyQOeoIRu5T+xJmUtnIUBCoDNKFnkN6wDe5cJcMtOJwfVED76W25pFEBz0DhOZSxuwYMa1CyQ4On/NLqJkBcgDzMiRbL3hJRO2ccqSClBh5MKGLt2L06E0OvYwzmBoiw2ZFI78/9k1WMT+W/b9i5qPlZB7e8IG+K1TucFw5IzWOE05RLRGXOjF3toYpmZhnt4bhZ+eQqE9tqIvFXZiEzjGWpqAfOBhRMmaB9PYcHdm1ST7c6R8dvTk8oG+VZxb8LLj+C+Ng7mIAayUUIe0JXUYc3QoLh4prQQtb4ay6SWcXE7yWx58nFyirYqKiSsU5yDzXPIBmFt4cWL9n6SCdzazuqZt2cF/3KNgy24QH2ZBXompxTyKl7OinkfQ82Sp3uAzPK5xGJvwg3wsqyFocZk4Qa06teZFsqkB3bMD3BKwETrRKR3gVc3tIEVk9L3OcNgdYhGvbmld6Xx6KraRBHfYXDPyxfDP6Z6OhltntMkKjnsAHInyVKkg/F3iUnbXofLAOgCD6kMhTZ9ZA2olxzZx0e8O754fAQVArFaeam9UBjKIuDqEteqmTaRgw7s+Gp0BSZ4sbcrnqNNUomt/Yl3o0vpOJQxIYdWGcAs4Igj/CnuIY/prl6kDpKwGgReeGbpHqSAsyc6aUDuRmyS1f7Z1DYCXV1I8ko+HJP8wP6BCD5LwHUpzSdBWxIF0qcGFE+ozcNLoYJfaGIdVvvdF9bSJ8I80Z1GbEAQAz/SZ+0EbKwDm1SXCZx2YbLYfAl0qp8JxA8eNDUkxvcB36GH6gMjuV4/JWJ3cWKI/xobZXQqFXdj9RCEH3yrUAjrE1wrravCdWCJBFXLQUxhus42lRt0QRrWc5cLe3hAcXOuNY/e9BoUdxkxoTa5GiiwCUagW9xlxyoHaKW450crDACuFWESgGc+JBj7DyzRtT+64Cq9Wsze/TPqQJ5gW0xQy5pAfv W4V8BJC7 HhzgQcvbofnJAhfmv7bJZQ2tG7UkTifVZA/m05m+59EkKKnlu4liWsG3CGihbZn4K1YY8PkvA+7FRRUgy/w46zLggNiazGD1SuIu38nXWr78EBZC0hud97lZK+A201wgY9HO0r/CWzjC/TCb7Sq9qEfUieg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry I didn't see the [1/3] and [2/3] patches in my inbox, it seems you didn't CCed the ceph-devel@ mail list. Thanks On 07/01/2023 01:40, SeongJae Park wrote: > The standard idiom for getting head page of a given folio is > '&folio->page'. It is efficient and safe even if the folio is NULL, > because the offset of page field in folio is zero. However, it makes > the code not that easy to understand at the first glance, especially the > NULL safety. Also, sometimes people forget the idiom and use > 'folio_page(folio, 0)' instead. To make it easier to read and remember, > add a new macro function called 'folio_headpage()' with the NULL case > explanation. Then, replace the 'folio_page(folio, 0)' calls with > 'folio_headpage(folio)'. > > > SeongJae Park (3): > include/linux/page-flags: add folio_headpage() > mm: use folio_headpage() instead of folio_page() > fs/ceph/addr: use folio_headpage() instead of folio_page() > > fs/ceph/addr.c | 2 +- > include/linux/page-flags.h | 8 ++++++++ > mm/shmem.c | 4 ++-- > mm/slab.c | 6 +++--- > mm/slab_common.c | 4 ++-- > mm/slub.c | 4 ++-- > 6 files changed, 18 insertions(+), 10 deletions(-) > -- Best Regards, Xiubo Li (李秀波) Email: xiubli@redhat.com/xiubli@ibm.com Slack: @Xiubo Li