linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Burt Holzman <burt@fnal.gov>
To: Michal Hocko <mhocko@kernel.org>
Cc: "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: OOM notification for cgroupsv1 broken in 4.19
Date: Fri, 21 Dec 2018 17:33:17 +0000	[thread overview]
Message-ID: <96D4815C-420F-41B7-B1E9-A741E7523596@services.fnal.gov> (raw)
In-Reply-To: <20181221153302.GB6410@dhcp22.suse.cz>


> On Dec 21, 2018, at 9:33 AM, Michal Hocko <mhocko@kernel.org> wrote:
> 
> On Fri 21-12-18 14:49:38, Burt Holzman wrote:
>> Hi,
>> 
>> This patch: 29ef680ae7c21110af8e6416d84d8a72fc147b14
>> [PATCH] memcg, oom: move out_of_memory back to the charge path
>> 
>> has broken the eventfd notification for cgroups-v1. This is because 
>> mem_cgroup_oom_notify() is called only in mem_cgroup_oom_synchronize and 
>> not with the new, additional call to mem_cgroup_out_of_memory in the 
>> charge path.
> 
> Yes, you are right and this is a clear regression. Does the following
> patch fixes the issue for you? I am not super happy about the code
> duplication but I wasn't able to separate this out from
> mem_cgroup_oom_synchronize because that one has to handle the oom_killer
> disabled case which is not the case in the charge path because we simply
> back off and hand over to mem_cgroup_oom_synchronize in that case.

Hi Michal,

Thanks for the quick response & patch. I can confirm that with this patch the notification is working for my sample test case.

- B

  parent reply	other threads:[~2018-12-21 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21 14:49 Burt Holzman
2018-12-21 15:33 ` Michal Hocko
2018-12-21 15:33   ` Michal Hocko
2018-12-21 17:33   ` Burt Holzman [this message]
2018-12-21 19:02   ` Johannes Weiner
2018-12-24  9:11 ` [PATCH] memcg, oom: notify on oom killer invocation from the charge path Michal Hocko
2018-12-24  9:11   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96D4815C-420F-41B7-B1E9-A741E7523596@services.fnal.gov \
    --to=burt@fnal.gov \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox