From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D212C4332F for ; Tue, 4 Oct 2022 01:56:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E9B6B0072; Mon, 3 Oct 2022 21:56:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E746B0073; Mon, 3 Oct 2022 21:56:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EDE16B0074; Mon, 3 Oct 2022 21:56:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5B0466B0072 for ; Mon, 3 Oct 2022 21:56:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1AA23A428D for ; Tue, 4 Oct 2022 01:56:21 +0000 (UTC) X-FDA: 79981602162.24.5338AAF Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf07.hostedemail.com (Postfix) with ESMTP id B799040003 for ; Tue, 4 Oct 2022 01:56:20 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id l12so11406497pjh.2 for ; Mon, 03 Oct 2022 18:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=IUIxHgJYWcHGaS/qJFBxYXjYwMIOrkLEaJu/xQNKfEQ=; b=aKmGtBJE8VNe0EZE7dHTOoTQnKr33h5A4fz5n/RaLhpnf1RHcnEVEG45rGQZjNjY49 LrtfZ7iAK6i0asA6CsmDCLH4WSl5WY3+jR0ijHAzLVnO89szKZvyex5xcDNRQQ/REXhX dJx+0CXbZv1hCkrd0Wu6pyaOiOwFnf3LaEtyy0ulvhBkeP/mOMy0Rlu2vXUAJbdXiHAd 9+2BQaZ7bEicPlGSagnR8iN7XmX+ADdNKWgr3ti5IsyWD/v2QonYTwPvGAM0p6U8OjJ+ r3pJfhJFUcCqo7xt8DNWI1cWyaEGnWYIeXH77kDnjGeXZSE3+6XTDyPE7BnipIZTesB0 TSpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=IUIxHgJYWcHGaS/qJFBxYXjYwMIOrkLEaJu/xQNKfEQ=; b=cERG1KT+qEbXwfHJqTU231JR11iOZQO2DyWuPR0nQCnaQfhCHEmfeI9//hcb+UTcM7 77KcgpoTQQfMFhINHpMaJhvyVkx6XKSzjm97T8tN3vfzM44a1DyKm0vpZdKUnzuSbBNa uiPtq3a6ijftOkhX5L/lHtuxMjJyJDKXCrBettPBS41QK++4jteROmyZemIehlbs/l1l IJcLun1rObindI2bYLFf74+Gm9z7RkJYtAzRU2ryHYGEUYCwlo9HkdI0FZXbHaCOrkVZ zwO4vq8kWWIaqP0aelXw8wOUvCFEXdeNYqdyXAA+7gNVmcCkBkvdYthS6RME9LCVP8p4 /aXw== X-Gm-Message-State: ACrzQf3Jv7usErplhoc6TBdna/vY/YC6livV4xQWIVhJCHiYtnQhH9+J VGh/Sio7JXEog8Eu8O5kDxw= X-Google-Smtp-Source: AMsMyM6BsRvc9pwadnammyxGl8ehM6JvyxAhCPZ142D2t0y8sbOHs4tx8RnG8eFOcCU4x3RllKHJxw== X-Received: by 2002:a17:902:a611:b0:178:6b71:2ee5 with SMTP id u17-20020a170902a61100b001786b712ee5mr24393638plq.53.1664848579309; Mon, 03 Oct 2022 18:56:19 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id q15-20020a17090ad38f00b00209a12b3879sm6955729pju.37.2022.10.03.18.56.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2022 18:56:18 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2 17/39] mm: Fixup places that call pte_mkwrite() directly From: Nadav Amit In-Reply-To: <20220929222936.14584-18-rick.p.edgecombe@intel.com> Date: Mon, 3 Oct 2022 18:56:15 -0700 Cc: X86 ML , "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , linux-doc@vger.kernel.org, Linux MM , linux-arch , linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, Mike Rapoport , jamorris@linux.microsoft.com, dethoma@microsoft.com, Yu-cheng Yu Content-Transfer-Encoding: quoted-printable Message-Id: <96BFE665-4A76-4CE0-A22B-A999C4A16FFD@gmail.com> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-18-rick.p.edgecombe@intel.com> To: Rick Edgecombe X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664848580; a=rsa-sha256; cv=none; b=J0ugQW4teWInRj8ovvas6/OJNSjGgYSTEHOYwLmMrQoPga1GRLrID5OPIgItxkmLqsKlYy HEN9QYLXKZcPOgfLIBaJEwPwqSLIYQPXyYJoYEvtHvBu9gOaZf1I2RbZYlXBfOnnW67TJ6 +oorgoNh9/hW4VNB8dq7XHfwUypZsU0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aKmGtBJE; spf=pass (imf07.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664848580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IUIxHgJYWcHGaS/qJFBxYXjYwMIOrkLEaJu/xQNKfEQ=; b=hOQP51p8d3VEsVPSyXE//Ht3F5wexvNOesOjPmlubqnwBifZOaBksAWkAI+9uqWcE3yKjm HuriEqNqZJrX3fF1r6haMyiM1HHTk3CwwY37nUKuJiqHjh+naKB+19bcPvG45yexQwO7eo 1BF2MJisf9X0j3qBshf5oxE5CuWzs7E= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B799040003 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aKmGtBJE; spf=pass (imf07.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: gapzg7s937xpmjnaackwogobozzgpris X-HE-Tag: 1664848580-560910 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hopefully I will not waste your time again=E2=80=A6 If it has been = discussed in the last 26 iterations, just tell me and ignore. On Sep 29, 2022, at 3:29 PM, Rick Edgecombe = wrote: > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -606,8 +606,7 @@ static void migrate_vma_insert_page(struct = migrate_vma *migrate, > goto abort; > } > entry =3D mk_pte(page, vma->vm_page_prot); > - if (vma->vm_flags & VM_WRITE) > - entry =3D pte_mkwrite(pte_mkdirty(entry)); > + entry =3D maybe_mkwrite(pte_mkdirty(entry), vma); > } This is not exactly the same logic. You might dirty read-only pages = since you call pte_mkdirty() unconditionally. It has been known not to be very robust (e.g., dirty-COW and friends). Perhaps it is not dangerous = following some recent enhancements, but why do you want to take the risk? Instead, although it might seem redundant, the compiler will hopefully = would make it efficient: if (vma->vm_flags & VM_WRITE) { entry =3D pte_mkdirty(entry); entry =3D maybe_mkwrite(entry, vma); }