From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130B4EE4996 for ; Mon, 21 Aug 2023 15:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31B5C6B0071; Mon, 21 Aug 2023 11:32:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB7B6B0072; Mon, 21 Aug 2023 11:32:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16CC26B0074; Mon, 21 Aug 2023 11:32:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 08B6A6B0071 for ; Mon, 21 Aug 2023 11:32:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AC7C440B54 for ; Mon, 21 Aug 2023 15:32:57 +0000 (UTC) X-FDA: 81148504794.15.8649626 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4A17B40023 for ; Mon, 21 Aug 2023 15:32:55 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QtIAZQls; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692631975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t2AB1p0AEhcKkiapqkhrfmo1fwMB4+UWLtP07pSOwNk=; b=EeiUJ4KnESoExhP3RWxMaFs96c0MubPfFqSwnGOVLb8TMn1XaXquC3rRlre2T3HqYQp83V fVWbxgosejlkN5L8lyt7ZuywQ3gwlkSkVGjLXhvilG65VzuW0V4Mwr/s86N0HPHvRvv015 lfuZRVfEOolj10dGrwM6woTPQdMqk4E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QtIAZQls; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692631975; a=rsa-sha256; cv=none; b=Mkctjj938hJ+homDC3fkDxUorRHjht/pR3puSJRtSOXGg14zBWcyPvL0rw82K/51HoxR6R dFsIo/davs+eT3rd2OM9Q4PGQ6GaMYv0PB8MCEBsgHCj69bckbLBaeD3Ylpf7vn7FGhzgx 9vJlSKwL9vceKnNt0d8SU3ZZZ/iFhc0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692631974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t2AB1p0AEhcKkiapqkhrfmo1fwMB4+UWLtP07pSOwNk=; b=QtIAZQlsxQqCL9YnuK6/lbaTVpetazwJZt1groTIj8zj8RqtsyvpS6/saUyyLfxsHFmXDv WXnj3F+D1zyV5H+J9LPKE/enkoRX7JfS0bXia+c3H9YaDkPpvGOu1H6Iki7uRQs4DxbIcJ cjJefrh5zCNJh5p5oKUNK/AphXj4v9Y= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-uHnQF2_ZMSeJilXJKulbIQ-1; Mon, 21 Aug 2023 11:32:53 -0400 X-MC-Unique: uHnQF2_ZMSeJilXJKulbIQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-31c5c47807aso355519f8f.1 for ; Mon, 21 Aug 2023 08:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692631972; x=1693236772; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t2AB1p0AEhcKkiapqkhrfmo1fwMB4+UWLtP07pSOwNk=; b=MUxQ5zRn79PHc7LtmWRlD6HxQ4Ttb4QiH20FjTd1hqW/fv1Ib1gmeOK3xFY1i5dVs6 C5zCB1drhRGDGHe+wg70kOpKQwuULpUZ4vPZQahOCDFymG7FzmxLiXcSxNsCgg30VzQq kBG+XAlaHgjZmuwp6JGpZT8bEaf6MhTpv9LcR10hRED9gbxEfd+Wi4PEfc7FbcPmzw/t 3/wJRtpP3T2MaHrQ/U8u+WV7gOxIxK+6xT7/fKc4JAVpZJj8kPsFiLXgOf4s5/ac7qCM AN7Akmobh6oebMzfuSW4LpsrzawA4XdEFvf1ATQp+d01z9Uqaxk87iXBiO/k+tOjohUT x5AQ== X-Gm-Message-State: AOJu0YyNq0pbzbWyes9NDB5MHjYbEQNayyLxokfGMk2mCYL9Bo5rX0S4 6CvBcrzf+N6oIG19Fc8N0Oa3X/UQ98iZQXd3KWHweUknjEENISRN7Pn1yVj7TwXZKZ4R7x0rGoh FTF/9WpjPWqc= X-Received: by 2002:a5d:5452:0:b0:317:759a:8ca8 with SMTP id w18-20020a5d5452000000b00317759a8ca8mr4696673wrv.67.1692631972217; Mon, 21 Aug 2023 08:32:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvV766/8KBT2JlSxhZL2APkdI2hKJ3WzFPwoMND6VZeG99uBd5MT6IIWD2ZzP54eTu/NjclA== X-Received: by 2002:a5d:5452:0:b0:317:759a:8ca8 with SMTP id w18-20020a5d5452000000b00317759a8ca8mr4696649wrv.67.1692631971806; Mon, 21 Aug 2023 08:32:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:5e00:f3e5:9995:b58b:3782? (p200300cbc7155e00f3e59995b58b3782.dip0.t-ipconnect.de. [2003:cb:c715:5e00:f3e5:9995:b58b:3782]) by smtp.gmail.com with ESMTPSA id e1-20020adfe7c1000000b0031b2c01f342sm6971847wrn.87.2023.08.21.08.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 08:32:51 -0700 (PDT) Message-ID: <96895823-ce2a-5dc7-77a1-a28d1242bc6d@redhat.com> Date: Mon, 21 Aug 2023 17:32:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Mike Rapoport References: <20230821141728.2536317-1-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230821141728.2536317-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4A17B40023 X-Rspam-User: X-Stat-Signature: bzadqngztjt9mpqxo7s6nimbnqucjo1t X-Rspamd-Server: rspam01 X-HE-Tag: 1692631975-956861 X-HE-Meta: U2FsdGVkX1/4yXu8qp9OF59/EkCRb/Zpyb6Wv9bkNmEPObavdVJu1RdIAlboSFnMRQsZg+bTq9XbTkWqefFJpu2dAtjwpFfrtSXUpBQcDtVOONWBLWhsbduB4Yvqe1qmDP8BKEYCb84gPmyhlP0h5olM1FLbsSdSlJOwkJXlJKqEUca871QX0RVX0AYE6PojvRgFrBn2b3JgM7RDSbS9wPv0UfnhsvVOpPiddMqXxzTrYTR8LuL2RkJiO+cyXHnIKPcK41b06ucQlsNV+ZDKwM/0KH8n4nvr5xc2TVcx068rAVRJF0GQ4D4/Ii/MBrU1y8T4iwsob268dm5Su7xgvvxuV73b6EAxqad9s7IVRGsBor3OTGGGaWddz/jxHLnv0f3OOz6C52l2tZ0jsWvXzlTiQXphaBspdmw1+/rJB2e+O4ln7KnrsifHRzx8xf0abqhw7mXSEP3TkSNfpfKr+5pQF6gxImK0oC16JMgv+EfQk+xD/ejB53SIIZGpXxyXQuPv/3fEBn95qvsXf3mupNp4JBnrevKYWlr0jM83Vg/9hui0Ha8ep+RrJwPQIGWNyPrbQ46+yuWjDULMwep2p16vfm+wr0UcQM3Jj8VbD72VSbVb+7YMLtPF+sv+kOByvCnrRNsvKcSv93WnPrXp3/CvxVisjJ/9Esh9D2jo+ALd9UcH0s0zru5/B1ciRGXC73DFALHC79rgsF+JiVHFe5oGc24KbM42G2SLxUUSJyvaaZxVmWklMSaKjx1yMXqgIayOsdv0FAZqizUjeJ3EcLw85OlcgFAVRrFr1mNuvpJvsM4TKiFgfTw+8ZzGA4/Ocb0ZgnC8TAcrbfLgS1EWwT9rD2djcdz+auGStH1cAvr2b0auG804uUFWvJ9I4OMsGfFNCqoJED4mD/hiKo2oFypFDEnp5aDnSDzb7hoqMa269sQQTIyv/zNgdb25dPcOMSeHWJgefUlqjdpLSxo lFqD2IKU Y7Zp83BIiNJOCznbSY+pxIsmX74YWhCi4XjBQGGxy9jJ2rAa929ZxU2WuthhRqHTeYN10/lN5lHK/97yBNAKtuaYCdPVMHct/qOgTFndDFPmgPTcnfDWgkdTezcicjfpApoAM6OBBab34oiR2oWH8IATgIYm6tzk1jy0dCY+I1/qMwmie3EDCenw/LUrLx5RCFJQC2Pdm0zRgom5pAIa/90a3Ka2iVaw9ylj4Rti4FkbGYd32YJuSQOnB4rcE2CWIDzZfOFz2LwIZJvoN0CYFGQaNtGi4En2wSfm13XzRjea9xddCDobXqfjUL5UWVi/ibWVas5cRh0XuDm3vTrKevTorpDdHPPkL+2kmV0HIbOfDZM0wO9FVfPXeNh/3tUXq6bm3nWFOEVFADDVtUfuu6ov2erlTzjUEv1fSUYtFoQeM+AwZSBs567ipkzQixhwMw9jcwqiPQgczVioCOBXySRZ/RwYUfRGsYRXPuQA6p5LJEak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.08.23 16:17, Matthew Wilcox (Oracle) wrote: > The only caller already has a folio, so use it to save calling > compound_head() in PageLRU() and remove a use of page->mapping. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/secretmem.h | 15 +++++++-------- > mm/gup.c | 2 +- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/include/linux/secretmem.h b/include/linux/secretmem.h > index 988528b5da43..6996f1f53f14 100644 > --- a/include/linux/secretmem.h > +++ b/include/linux/secretmem.h > @@ -6,24 +6,23 @@ > > extern const struct address_space_operations secretmem_aops; > > -static inline bool page_is_secretmem(struct page *page) > +static inline bool folio_is_secretmem(struct folio *folio) > { > struct address_space *mapping; > > /* > - * Using page_mapping() is quite slow because of the actual call > - * instruction and repeated compound_head(page) inside the > - * page_mapping() function. > + * Using folio_mapping() is quite slow because of the actual call > + * instruction. > * We know that secretmem pages are not compound and LRU so we can > * save a couple of cycles here. > */ > - if (PageCompound(page) || !PageLRU(page)) > + if (folio_test_large(folio) || folio_test_lru(folio)) > return false; You converted a "!PageLRU(page)" into a "folio_test_lru(folio)". Shouldn't that be a "!folio_test_lru(folio)" ? -- Cheers, David / dhildenb