From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC20C47258 for ; Tue, 23 Jan 2024 07:52:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A91B8D0006; Tue, 23 Jan 2024 02:52:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 134378D0001; Tue, 23 Jan 2024 02:52:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15D98D0006; Tue, 23 Jan 2024 02:52:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DF02C8D0001 for ; Tue, 23 Jan 2024 02:52:10 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B51451A0173 for ; Tue, 23 Jan 2024 07:52:10 +0000 (UTC) X-FDA: 81709807620.07.80B3567 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf14.hostedemail.com (Postfix) with ESMTP id EA13A100011 for ; Tue, 23 Jan 2024 07:52:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=SPfiKPLY; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705996329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U4jBxtMg1/g50fV2wjOV5C4gWz3brpU0h47v6AWOV64=; b=f3xhjsw2Iwf+MsN3qI5HsV9oC6DfomNG1MVmkGzr1H+gHuFSuoFOdPsKlbm9pa1tPv6r+q +ynH2NGRZkPJ6ip5dbeC1mN3vLMp61u+WqPOWzFIdkNwJtJsHb87Ct56SVz30UDpKNU1qS hHTAUbMeNpO7IPMptA0zEwBWI1jSzt4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=SPfiKPLY; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705996329; a=rsa-sha256; cv=none; b=WfmHP9uJUvfUdxlMwUbqLFBsTBWTHQr3wwp1xm1yruInA4XhXG0S7mBU4BGIGrgMZjjq6n KG8IyBv3zT4Pbc/n1nnr19V/HoCKqiYUB7hxkRlCRggirPxOj7b7AHeyqwtgTQdiMrpHUT i0arDh3IEgM47yD2Ra1H8G9oSv2qOQE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705996327; bh=K6k2QYxpHaMZ2H7zY/M+E12/FkVtZ9PqhUpBbAY4yvo=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=SPfiKPLY5BytPAwfWFsIu6RvNfW9rLkcEqNoDbKMXsCTrz1xvBcpDNRrya6jfH+Ho m1lY6Xf0msHKHHHNmB8DcEk7e6pAnWjdti3y0epaeU2Q48Ww/HArLmm4G7iQqZwSFo tYRVhzjvokTH/g1PsYSa7/+SzvlYcO069Yk9F1cgV/b4RYvxjY00oniw8WbJBU2Ilu hxxR3VjqVlkSi0EIZt2mtZrz/6Dv6hA08xobu4BgfKA+iDURWwnmUGXUMuPJTy+r97 kXulpIUNR3tlHZ70027ywlg6kyDui6XrvC6sL7FrHKOXj4nigqyH362YKVNkq7Ioie b9IPvROSQGvIw== Received: from [100.96.234.34] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A1A293782066; Tue, 23 Jan 2024 07:52:05 +0000 (UTC) Message-ID: <965acceb-9aa1-473f-a873-40eaaebe5d0c@collabora.com> Date: Tue, 23 Jan 2024 12:52:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v3 1/7] selftests/mm: hugepage-shm: conform test to TAP format output Content-Language: en-US To: Andrew Morton References: <20240115073247.1280266-1-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: <20240115073247.1280266-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: u84irhyz49aiy1dhhcoane6fgz1bt1gh X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EA13A100011 X-HE-Tag: 1705996328-5864 X-HE-Meta: U2FsdGVkX1/hG+CLZDIXpex7zRE7+bND0lNeaDmMtoJn3oKS5Nb5zAVO8/fiZaShKzAfumuPdp+tpR+2s4sOZXBMw3ngGAmo/MJ3UtU2lwttd1nSGJtUmkxXjSD7kI9QD4EYSrgQIy5KkRV1jp2slLgdxvXFtZOErX5nXNZnV3uQI9enmTxykoUVeSFaTEIms/GMEembSQY4T9iNRX0mG4nVSvURSqxPqsPDYWikH34K0pwMfk4Z8rR6T6tnSzDn2tznTOyQBhqCwCRwJ1K7gpspYJyWU9BClIpkqweThLmII7c9dRARoVWAuo3ErU0OKjFmxna4T/MEd0fAOC7C2sIvqHLpJqoGOGxu0z/AQJa0cilBmrJeL8f2++GompaFU0YO7/eiGdQrrsYSrYQdEcN5PmKFRO9nSutt8E0syYzEehYlE5X76BFCzx4M6A69ZzIn4DGCJBfgDK+D4wpku1SyZIAdYPkUQZQuakOuAhLxaBJ6dSqcbCIOyJB7gJJMdeIOAnf5A5DVhTK2XMOG4Q6J9Zbi0SN7SghiXPahqx9Qa4v4vssWLajQGcZwieuxa6jkiOfVCPiPLhWD2fPmm+q0QnPaHzr8TvjL0aJ0XPrWN5nR3Y3f7p1hS8uSy023grc4iiWK9WeFChtfnYzVYGoIChLmA57bE4VQAdHu0ERCWyBtVHVote/nT7pZRnizX7mHD0k8bYtNc+gAbc9OabAr8K4VTsw+aW/usKZguOwXZf3N7ESP33RjX3twjwzaigCh++yo5gfC1LalFlUaE/QGXeUmxke3cTyvg2NXhh+dAtgFb/if70K8aJ7fPWKkTy2w4Mbk+AAYNFXntz2Z+ycp9AJN9F2iFAhraICDBzKMxbs3aJizu6/l+DTF0c9v/u+/redNfFhMBSZmOLov2nO2pu7x3Tb7qXZpvA8Vn9eDqRIR1G1un/5DpDeszK+M4uQQrA6JSd7lAxnCc3Z FBDm2KrN FYQDgebcY+jg1ugUkn+uC3SfMyTnN91vSG93v8AI9DfJi7uwD/UT9MmN31w69F2EfdQsL5U2l1NcLNyEf3iaKyjAA1uqH8xZ/Jas81ks530HvqanVQQzJIe4qjOYPVWDTMfnp/Cb/7nX2E8qL3v9sBQ4hiU6APYDr0BbNALqxBvBnftxOpBMgkFdzVNCgKAZfz1JoywoOxZO0KxZ12Cg0TP0gxCD8tqr9nYE30U0g63/qdgE0HCSdlL6rIxx1OXZmF4U2r0y3nmnSYnUP9xwnvf66TFKbA6JrXEHnPiwY/Hfx+t/uZx/dbq3XxT+pn2Ts1j7qUBgTvOU/ACtXBy3rScjciw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, There hasn't been any comment on these. I guess, they can be picked up now? Thanks, On 1/15/24 12:32 PM, Muhammad Usama Anjum wrote: > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > The "." was being printed inside for loop to indicate the writes > progress. This was extraneous and hence removed in the patch. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/hugepage-shm.c | 47 +++++++++++------------ > 1 file changed, 22 insertions(+), 25 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugepage-shm.c b/tools/testing/selftests/mm/hugepage-shm.c > index 478bb1e989e9..f949dbbc3454 100644 > --- a/tools/testing/selftests/mm/hugepage-shm.c > +++ b/tools/testing/selftests/mm/hugepage-shm.c > @@ -34,11 +34,10 @@ > #include > #include > #include > +#include "../kselftest.h" > > #define LENGTH (256UL*1024*1024) > > -#define dprintf(x) printf(x) > - > /* Only ia64 requires this */ > #ifdef __ia64__ > #define ADDR (void *)(0x8000000000000000UL) > @@ -54,44 +53,42 @@ int main(void) > unsigned long i; > char *shmaddr; > > + ksft_print_header(); > + ksft_set_plan(1); > + > shmid = shmget(2, LENGTH, SHM_HUGETLB | IPC_CREAT | SHM_R | SHM_W); > - if (shmid < 0) { > - perror("shmget"); > - exit(1); > - } > - printf("shmid: 0x%x\n", shmid); > + if (shmid < 0) > + ksft_exit_fail_msg("shmget: %s\n", strerror(errno)); > + > + ksft_print_msg("shmid: 0x%x\n", shmid); > > shmaddr = shmat(shmid, ADDR, SHMAT_FLAGS); > if (shmaddr == (char *)-1) { > - perror("Shared memory attach failure"); > shmctl(shmid, IPC_RMID, NULL); > - exit(2); > + ksft_exit_fail_msg("Shared memory attach failure: %s\n", strerror(errno)); > } > - printf("shmaddr: %p\n", shmaddr); > > - dprintf("Starting the writes:\n"); > - for (i = 0; i < LENGTH; i++) { > + ksft_print_msg("shmaddr: %p\n", shmaddr); > + > + ksft_print_msg("Starting the writes:"); > + for (i = 0; i < LENGTH; i++) > shmaddr[i] = (char)(i); > - if (!(i % (1024 * 1024))) > - dprintf("."); > - } > - dprintf("\n"); > + ksft_print_msg("Done.\n"); > > - dprintf("Starting the Check..."); > + ksft_print_msg("Starting the Check..."); > for (i = 0; i < LENGTH; i++) > - if (shmaddr[i] != (char)i) { > - printf("\nIndex %lu mismatched\n", i); > - exit(3); > - } > - dprintf("Done.\n"); > + if (shmaddr[i] != (char)i) > + ksft_exit_fail_msg("\nIndex %lu mismatched\n", i); > + ksft_print_msg("Done.\n"); > > if (shmdt((const void *)shmaddr) != 0) { > - perror("Detach failure"); > shmctl(shmid, IPC_RMID, NULL); > - exit(4); > + ksft_exit_fail_msg("Detach failure: %s\n", strerror(errno)); > } > > shmctl(shmid, IPC_RMID, NULL); > > - return 0; > + ksft_test_result_pass("Completed test\n"); > + > + ksft_finished(); > } -- BR, Muhammad Usama Anjum