From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9D9C8302F for ; Tue, 1 Jul 2025 04:53:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70C8D6B009E; Tue, 1 Jul 2025 00:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E4536B00A1; Tue, 1 Jul 2025 00:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 648386B00A2; Tue, 1 Jul 2025 00:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 559636B009E for ; Tue, 1 Jul 2025 00:53:19 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C6EAC5802F for ; Tue, 1 Jul 2025 04:53:18 +0000 (UTC) X-FDA: 83614476876.21.77C4B14 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 05187C0004 for ; Tue, 1 Jul 2025 04:53:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751345597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hv2TENqJDdWkyGFB09QzUZAOlYRHThbF0hgWV/LHaz0=; b=KKd/SDdD7q/y0Uck5EH5PVk5hBbCF7QvQFD6zj0KZ9LXQnw79UPlEqdzztrobCcnRTG3li /H09ii30ihQ0xKrQ5pX6XxbkcrSS6bLyqcydQXtGkYvTzev+caIqYhfp8Q+W9BQn8yAjX1 lhWZ3WDUYfhG2NZ8vp4mh9tqHxg26zE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751345597; a=rsa-sha256; cv=none; b=No1+CphxceE07k37VCA+rDT5I4dMcGTaZrsKr1HZ1twGeOUSGLebP4il8hl1Nmjm8o72oc glYNPYNDqF8fPF+s4QhpijNpqBf7qpgLIh1tvqQ0BMl55iQcbiWD7aoIxCL7zKCk9NfltR tINzce2gVWCRm1awMRNeKaHn8tEFYEE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4911A15A1; Mon, 30 Jun 2025 21:53:00 -0700 (PDT) Received: from [10.164.146.16] (J09HK2D2RT.blr.arm.com [10.164.146.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C882A3F6A8; Mon, 30 Jun 2025 21:53:11 -0700 (PDT) Message-ID: <965ab1cd-c606-4724-a8f0-b352f4a3d443@arm.com> Date: Tue, 1 Jul 2025 10:23:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Deduplicate mm_get_unmapped_area() To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Jason Gunthorpe , Oscar Salvador , Zi Yan , David Hildenbrand References: <20250627160739.2124768-1-peterx@redhat.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250627160739.2124768-1-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: byb99gqxtc3p3tfrc5gjjx1nsxeg4m5f X-Rspamd-Queue-Id: 05187C0004 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751345596-308617 X-HE-Meta: U2FsdGVkX18+oUQxHMbmwEFpP/Im4i0yMWc16b7PPg9ZnEiFuv80p0nXGZtbOGWQQYSWvPX0HSN87vnQYKdsJkAfOPXRm6KTWxgQHWncsmwe0c0u6yMpwRx2pJ3aWRUcLRat5acZvxK58DWeK5Hym3Ykholye+wVqHiirZlIphV9LnLk/nXViCbU4PVVweu2gp+ijxjKS/qdjEFDcnTSSbYU7EcrFtXYoAhPphk+RjUlTjNwaqIs36CRgVDS47HDaW3QTleqB4AFyHhNjIF7Ts8QyoXwAUJBBeO2kO6Ii/Dlq6NCLYKGhTHD6xGtx0zH4SSVkb/2ZHr5LBxoaTGonAIxr7FZfKdb6gQGyCWF+rVaCpF2g9zsH+YW2n9OtJCtYvHz5p0anvQTR9jQr82eMlgHL+pKdO9ZhbMe95k+356cpJwdFFD51lv5zG8vS/vI5SUtXkr8qcnz8eCW/ZpcHHTXCg2smnty7GELaDe29JfXpsGXhgnyd99QAqy28Ulr++C8vxMlf7J7+rbCV3j3C1SQDUsAZp4GMLJGRWPw3OspJyuH1swQ2+W37oOi6moeMsEwBWgMdc4zShU82K9J54+bhVZCKA1S5xgOZ9osafgsq/vYbw5rMG58nuPnEcl1HkWLT2/59RIgEOTyoIZdwmIX/crHpTXs0VNp02znUp0KFJ6egYLlfwdjAc3ugl4cEZ2Q8TxPphgMj/Hkh1XUPmn79ROyiAh1+QrSAWc3oi2fBRv01mNK02BhetWiSYlDo1L99JGccAqJG8Xip2FybPIS98f+6kJR+swU0a/Dg/bsaD0Qbfv62DC8h0AjOI+O9O9mG2ibHORThp+NwEV/NU/B/NqmyM2+zgZkvA3BMfWa5fKf2o7mIaTfoEmJjCzPo8KpEzQTx/+LDdHUCCQW/lcSyW8H1tmHUIGP9l3IQ9TS0xMJpijqJkT9mbeyXaAM7jwvCJ0umKmTzJbHPIu VPWlJ39H WcXi/MidwQQEG3lOwj6d9HS6Hp1/y3/ycX/LstgRyMgQP6jlIHirFyDclukkG5Um2H2SrkKoJMxsyO0hnnojGntvs1XImdhreqZZM3tfbZhdLG04/phgnc8l3657kn8w+aag2cZxKu1pvigppV8N4Y786fnzIvECKNsz/OUPkMCIAB5akr+vih56JsO+lWfwhK813sHaaruvdSc9Qx8/tfShVoNtcCtb+xOhB9wKBES7/6PLYAkSeP7Z/bR/Xs4ZHYiZampCPXhny98kiMxxTyq1gfYt4GUDLEk9U8LnDPasxaWDu7I3z8vpo1MTPmo+MVn/oPNYH3YeOUijYCKIX1RqTkmGmfrWLB7kbOfSwvW29OBoDs9me7qcitojy2+n2VENH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27/06/25 9:37 PM, Peter Xu wrote: > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > the helper instead to dedup the lines. > > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc: Vlastimil Babka > Cc: Jann Horn > Cc: Pedro Falcato > Reviewed-by: Jason Gunthorpe > Reviewed-by: Oscar Salvador > Reviewed-by: Zi Yan > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Pedro Falcato > Acked-by: David Hildenbrand > Signed-off-by: Peter Xu > --- > mm/mmap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 8f92cf10b656..74072369e8fd 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file, > unsigned long addr, unsigned long len, > unsigned long pgoff, unsigned long flags) > { > - if (test_bit(MMF_TOPDOWN, &mm->flags)) > - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0); > - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0); > + return mm_get_unmapped_area_vmflags(mm, file, addr, len, > + pgoff, flags, 0); > } > EXPORT_SYMBOL(mm_get_unmapped_area); > Reviewed-by: Anshuman Khandual