From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/list_lru: Simplify __list_lru_walk_one()
Date: Wed, 20 Mar 2019 19:52:13 +0000 [thread overview]
Message-ID: <9654f80e-ac2b-9d85-fe93-f42cdc2f6011@virtuozzo.com> (raw)
In-Reply-To: <20190320115251.026f65e83ebde2b8ebf51134@linux-foundation.org>
On 20.03.2019 21:52, Andrew Morton wrote:
> On Wed, 20 Mar 2019 14:19:27 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>
>> 1)Spinlock must be locked in any case, so assert_spin_locked()
>> are moved above the switch;
>
> This isn't true. When the ->isolate() handler xfs_buftarg_wait_rele()
> (at least) returns LRU_SKIP, the lock is not held.
Oh, I missed that :(
Thanks for pointing.
Kirill
prev parent reply other threads:[~2019-03-20 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:19 Kirill Tkhai
2019-03-20 18:52 ` Andrew Morton
2019-03-20 19:52 ` Kirill Tkhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9654f80e-ac2b-9d85-fe93-f42cdc2f6011@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox