From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C74C282CD for ; Mon, 3 Mar 2025 08:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87A48280020; Mon, 3 Mar 2025 03:58:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 803BE6B0092; Mon, 3 Mar 2025 03:58:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65529280020; Mon, 3 Mar 2025 03:58:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 41A486B0085 for ; Mon, 3 Mar 2025 03:58:24 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 014281404EE for ; Mon, 3 Mar 2025 08:58:23 +0000 (UTC) X-FDA: 83179638528.15.4A77B3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 910FA40010 for ; Mon, 3 Mar 2025 08:58:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DzkSI/nM"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740992301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yhKA0PWZzkHsCkSvRw6WIRSjH0fQoXRBt2BANeFnGaI=; b=2JbiPHa7f1C9w14zCXl2HiiQrzJWwSmEq7mk8Q5QkvNWr/1vjsNQo92kj9VxeJJvWuRgo/ kFG5ktFuHXAcTVA2auorGxphjIeRy1dshfmDZKfNhEz5TESZfcJAkSdH1CQKtNwUjMUUhj GwDDQU8frH89WthvNnCOHH6zC4Ul7/I= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DzkSI/nM"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740992301; a=rsa-sha256; cv=none; b=6eZrT7LDEDiMiMPzfnczyVtzi+P9QXfM7JxS17mjl+87BFKSvKUN+KtBYieXpG1kpMyFse xIdmIzwafwVEFS6vTOkQQSGk8NrEtqIhOL/1Eotgfwm8bVcAi/e+Tmpak7TWAcgWvIdu7P MFboCZFnigAOi+5RUXvXDwo6Y1OTN0c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740992300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yhKA0PWZzkHsCkSvRw6WIRSjH0fQoXRBt2BANeFnGaI=; b=DzkSI/nMd7zv8UK0jaoNH+jt7Jamt2zknqwSX/vd3oHnQApzS86JrECsChFBZTg6KZm+7t wRYCGEqfy1AXf52pgB+K09m7NSKwo2wM1q6GN+9AiVShKPEl39+YIZ46gfAlP7cu8L0yVe OeX1aKuYO/gm3Lg2nSanEjVH51kSvGU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-XGjzPKSyO1GTPQ3zltcZWw-1; Mon, 03 Mar 2025 03:58:19 -0500 X-MC-Unique: XGjzPKSyO1GTPQ3zltcZWw-1 X-Mimecast-MFC-AGG-ID: XGjzPKSyO1GTPQ3zltcZWw_1740992299 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-390ee05e2ceso1761787f8f.3 for ; Mon, 03 Mar 2025 00:58:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740992298; x=1741597098; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yhKA0PWZzkHsCkSvRw6WIRSjH0fQoXRBt2BANeFnGaI=; b=L5Ol7HG0wzFaAtSaqZzwo9u2IQPuO9REJJfHWFGeychGsyVMITiBZc0qLETEVB0M9f R9IoIyxPzmF0oh0QPBNSo8CIM5nE3Fq3YEr45sfiiEIs8F9bIGBGiASPzG0GK6woOnhk ZM3qhq8qPCQqrCUbYI+9cnXhLS4j30ZvQE1eOU/max521meCaDClVBpi2w9z/Lnlux+k 5ZRp+Bjo+7NLOUXVHruDtLQMc6TjbcKwTntnO/uGMTMqfKeWGwB9vtF4XYhaAMrspMYo s+PC5mk0Z+yIfPTxELlBNPa9AxtY2ZmyHjFr5D0dhtwT5gcWtP7pdnWX4zuQjM07p239 7I8Q== X-Forwarded-Encrypted: i=1; AJvYcCUbB1ASm119HJS1rbGjLDmEZgTqWJ6ocXd6+dDeaPOavIXQWNB0JhK1yBxo1ryxmmvGYtsaWv3v0w==@kvack.org X-Gm-Message-State: AOJu0YwL/DwM9Vviyj6j7Uef/pK55w3BZwVQ5pA8vUDh/add/zPfW3Bx K8Om+3eFFriZSUH0CONV/iiqZgr4qsEWIeWWogIvQ0WzFZPNndTWf/OdMjssX3cdgTRt0SsWRdG eYohb3UaTHo3cnp91RrQAfY+3BJBE7KxPoMuUafSNSd8NURqXx564diRMuAo= X-Gm-Gg: ASbGnctrIHlwKNL/tc5AJbS1zLl8XGrjqlxMlX/JksHOotL/YkGsiHmCKLPAS2Y3gim V8mTeB1SdP8UgQluE94qhJqIIad+avY1/JV7HRw/LlppSd/sU5lSuIFSXn+Sqp4A4q2Tz+wT7VZ GYwkIP/5x6kLEwhq6oLTOYJEuq8eklWVgCn6jHGEB35YLY5PJLRsMzlhDs9RDCKqHIo7ydqO4HC IkCwJetkBHsFha8HxbweWCo98CcVKVUiq/7G6oz4Lm17i5oTxx9qvp8PmYYOrMxCKTKmvnopRzx 4efVmmWPQE+usqVVx59LnyV1A168dFXOwwK6nb/7vcNr/QW3AkRaUpBM4ccDQjVpsaDIygCiq0M 8KLYjqdJWTz8JYf+1Rp1H5PvGOC3VKdOJXBpuy91DAQI= X-Received: by 2002:a5d:59ae:0:b0:391:10f9:f3a1 with SMTP id ffacd0b85a97d-39110f9f4ffmr1082123f8f.35.1740992298633; Mon, 03 Mar 2025 00:58:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrOB8TUQnl8FpqKRAFyy2zHk+Etq0hy84HKx7V6iLK+hyXpCu8bZkk/epZdl6ibKYIEl0N0g== X-Received: by 2002:a5d:59ae:0:b0:391:10f9:f3a1 with SMTP id ffacd0b85a97d-39110f9f4ffmr1082091f8f.35.1740992298255; Mon, 03 Mar 2025 00:58:18 -0800 (PST) Received: from ?IPV6:2003:cb:c734:9600:af27:4326:a216:2bfb? (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e485e61csm13948947f8f.98.2025.03.03.00.58.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 00:58:17 -0800 (PST) Message-ID: <964e8991-44c0-4ff7-91cc-033ed7c09835@redhat.com> Date: Mon, 3 Mar 2025 09:58:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 19/20] fs/dax: Properly refcount fs dax pages To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: W64QGKtc1jzGegu9CemKOeT-6Hohf8HOWiHw38WW-K8_1740992299 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 910FA40010 X-Stat-Signature: y6xpro1yg7wtaiaogiuind6ksnu6q4gu X-HE-Tag: 1740992301-746036 X-HE-Meta: U2FsdGVkX19aGkl1Wz5ghZSZSQz8MFQUvaKTfrnOtpLWNkjm4IMQmj3FWrMd34HxE/Qsani5Bdmx7ZU4+AjEWOYTTFQKTZJKSblXvNztQsfMJdJzw7WkZ1jTjYrlyGLtgnavLkpvQMRzWvrkAot/vokZ/dfOUe+KzCah54rotPsdBTeu8Su8o0T3Rdr2VHhy/nctZEZqDCqO1LFekxQMLwsw4/gkedepVOVg0J2GqYdL17h9vsdVQeIIhZqkhgaTXstIsLONDHXj03tgOcB8tgX2bBnSVGOnN8qYCtK3FEWC6esgS6/+r4LYQqwMGr0ITdKa5EJHAaHLJeXZiEp62NJinDqn5RHSM5Ij94PHT0fZeGWqmXp8MHOXWgJthP5v2Nypp0y4B3L1ogYERlaF9VndMZ7MNyGRYpTw6O62+S7J+MeOYeFwqttkHhCK4+3uxqGlV/FxjfDjuHbQCjRSaSchYFQCelR12sBz/2j5+d5Unc/uJl/Gz6qCYHAwJ+wXUOMPxK3Ris4VmTDg7ez8V2AHM5U0RpHXa7ubhvRYI4/4/IJALMs0geOnUKlPFom24i/Es2VCrjozF028USXv61LF0bqLfDhuWgKzlHzNqelinGb7tceTZmVOt7XQ5+xyUpdXv+kgwDv2OXqGwYYhomJ+XSIy30DlR5ReUEtcHHc4Y/n7NJXqAxPqjgiF69X+Cu+2or7FH9gsFuntznO4yS1C1zyl8aDZzIra/v4xKCRdmfKleb9Su30r3gNwG+ky7qfM/87EXXyMcxIEg+VUDLnNN+KPNmaby6c2RvorX3Wz2TszpA7oVOFBlXmyherYTCF1GESRDccY/EDpuxZJ6xdPB7LTuu9aIxEFnCC2f0Cb7s5smnmP0KU7b0ntSvDlsgITsSogAcDZykyq+toTc21AFJmN0/ejw189eKd6OBzglNOxN1os2ecv+8L1Fa0qk95g+1ERM+Do2XQPKBA ZGdnle7G jFdijwkfk0J61MLKzyP+F2MEiIQbFypUzKLOgCPCTwrqfNWXKbeG565MASnxeGKFzRy2DmPHTAWbmhtV6w+pp3g5HHkzFVivtttP9qpOP2l1ECi98TlBT4WTN8Hnq6WfNEoWZV9fGcclQqSQ+Qe8D8wN5vGpnHSffpy4JR/ZkOTGjG7ikJG+jcTNu3iB67cZFXgv0wnTgkXbAMf1IlJgE8rq6wnuK4we25b9TTliamcOkoVdw6wA/7RwClWhOyyx7XJsIG82VJFH5gKhMpFY/23xVJEJWMvMhFAnaGE6/yXLjoxWwLq0RZlFzQZKYZZvvL9xVBEsCN1juB9k+H+urKbl6e9POnv02iXAYliiNU5DHvSn9i2ohkQkXWDD6MuPOC2UgRI69nDfmSJBW5RVqAYo6p5AgLnfApEs9a2aQxQjDjBVJdjeXEpYGK2wyDqMLNNJ93Uuhjz+J+czTp75pwFMx+d4rrcySd7OZjeB35y44jnI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -static inline unsigned long dax_folio_share_put(struct folio *folio) > +static inline unsigned long dax_folio_put(struct folio *folio) > { > - return --folio->page.share; > + unsigned long ref; > + int order, i; > + > + if (!dax_folio_is_shared(folio)) > + ref = 0; > + else > + ref = --folio->share; > + It would still be good to learn how this non-atomic update here is safe (@Dan?), but that's independent of this series. Staring at it, I would have thought we have to us an atomic_t here. Acked-by: David Hildenbrand -- Cheers, David / dhildenb