From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C291AC3F6B0 for ; Wed, 24 Aug 2022 08:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 424F3940007; Wed, 24 Aug 2022 04:10:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ADB36B0074; Wed, 24 Aug 2022 04:10:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24EB3940007; Wed, 24 Aug 2022 04:10:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1506C6B0073 for ; Wed, 24 Aug 2022 04:10:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DA92EABDB4 for ; Wed, 24 Aug 2022 08:10:44 +0000 (UTC) X-FDA: 79833764808.17.E819A55 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 4013E10001A for ; Wed, 24 Aug 2022 08:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661328643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FkqRyVmVnH2p/hv4jFAhKRZhXQQdh+BaDqLkaLzGuMI=; b=Oa+Em88MUZNpXu2kZgs8oBvqX/8Z2dYvAOyjwZKZbLBnmxowZKHGQopcdTs6u39IoPHUeM 2LT44LzVDDVD2p4UGD1rFLyUg92qIxxbB/4G207bomwTIaZF8MhktbEjFGkORwOhletkov 8H3QCBzI9zqOA581pR9y05UBWHGHu6s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-265-wCFHelIfMB6wQkyo1j86kQ-1; Wed, 24 Aug 2022 04:10:40 -0400 X-MC-Unique: wCFHelIfMB6wQkyo1j86kQ-1 Received: by mail-wm1-f70.google.com with SMTP id q16-20020a1cf310000000b003a626026ed1so236108wmq.4 for ; Wed, 24 Aug 2022 01:10:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=FkqRyVmVnH2p/hv4jFAhKRZhXQQdh+BaDqLkaLzGuMI=; b=kOemFF8aB4OnfeMURWPdlNUcR+01PfBp6Py/og1O2lkwN99k0tjU4F+wS92mIqACmg 8qeglYIgRdC516pIg1OcGIzQdmQ+oIGG8tvrBabaXKA6TJZuf99MZPh8iRC3KHw9ev6d +EVAPV7JwKXrv4KsgHIURA+aqnrEB6sQN6ttgqDGj3/abwPCqIuKdU9su5N7gQL+MPwl 18AZrtdCyaYi8R3DOJFv7UdRf1Viw8KieDESMkk9CMm1uvS0+8qlSvYgDh4yyipQ4xG8 oHkS+7ptrVWBA7cblAOMXrf98Ngo2yKhSA1jF0Z7tMGqtmY3ItSQ3yQ88nEVvQhY/iXy AmPA== X-Gm-Message-State: ACgBeo2zK46POhbsaEvv4+6C0o/poFgGIsmJmjiH+osdrpafrOh5sXBn RPH2GBDiVEh4zB/0fjP052a+Vw7C/wQ9VtVXAZZ8rsHud7urhfi6Us7EtV+aPMj7RmKbsxhAZCS b4tym9ZPLA40= X-Received: by 2002:a5d:5487:0:b0:225:3fa7:41c2 with SMTP id h7-20020a5d5487000000b002253fa741c2mr11668196wrv.195.1661328639300; Wed, 24 Aug 2022 01:10:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7oWpPdTD3abka/IUBi2UFio+jqKRoZcRc1o7eyZSl+PEi58PEdaVPrSmiTzEqsevHnndBcoQ== X-Received: by 2002:a5d:5487:0:b0:225:3fa7:41c2 with SMTP id h7-20020a5d5487000000b002253fa741c2mr11668178wrv.195.1661328639030; Wed, 24 Aug 2022 01:10:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:c500:5445:cf40:2e32:6e73? (p200300cbc707c5005445cf402e326e73.dip0.t-ipconnect.de. [2003:cb:c707:c500:5445:cf40:2e32:6e73]) by smtp.gmail.com with ESMTPSA id m9-20020adfe0c9000000b00225206dd595sm16017732wri.86.2022.08.24.01.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 01:10:38 -0700 (PDT) Message-ID: <96433a14-1d2c-739d-95fb-3e3339200dcf@redhat.com> Date: Wed, 24 Aug 2022 10:10:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 1/2] mm: Cap zone movable's min wmark to small value To: Wupeng Ma , akpm@linux-foundation.org Cc: corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, songmuchun@bytedance.com, mike.kravetz@oracle.com, osalvador@suse.de, rppt@kernel.org, surenb@google.com, jsavitz@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, wangkefeng.wang@huawei.com References: <20220819093025.105403-1-mawupeng1@huawei.com> <20220819093025.105403-2-mawupeng1@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220819093025.105403-2-mawupeng1@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661328644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FkqRyVmVnH2p/hv4jFAhKRZhXQQdh+BaDqLkaLzGuMI=; b=JryibVGXOfn6CE4+mya3EjEwH/GIfEbGKB24eFZtO+CWyouv/MWb4HBUpGI3aWpMlUkeyg dEG/fd8X1ACeHi3fmvZ8231r7z7pPVcRwkf2bE1aCJ/xGzCdxFoEd6mzhR1kGsmX3wZqdZ B23UYaIg6i17Egm/P8Utius51tYRWi0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oa+Em88M; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661328644; a=rsa-sha256; cv=none; b=JCLEUDNDE4jziT2abuxAhNiRTpT4u4Qm7lyxFcp/3lbJXSDRaQleI/mdzZ91veTrDhMggV MyRaxTqYWeeFoENvgQDVteBpIghBy+NEijz8NnEAkjD1TvT/aDjg0ekDcqTvESTHn2fnUv iQ/PruP7q5yvm7uU2650E5LqZJc6HQI= X-Stat-Signature: df34f5tkq3t5s5uswnw9ddpqhbnqrsbh X-Rspamd-Queue-Id: 4013E10001A X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oa+Em88M; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1661328644-252607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.08.22 11:30, Wupeng Ma wrote: > From: Ma Wupeng > > Since min_free_kbytes is based on gfp_zone(GFP_USER) which does not include > zone movable. However zone movable will get its min share in > __setup_per_zone_wmarks() which does not make any sense. > > And like highmem pages, __GFP_HIGH and PF_MEMALLOC allocations usually > don't need movable pages, so there is no need to assign min pages for zone > movable. > > Let's cap pages_min for zone movable to a small value here just link > highmem pages. > > Signed-off-by: Ma Wupeng > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e5486d47406e..ff644205370f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8638,7 +8638,7 @@ static void __setup_per_zone_wmarks(void) > > /* Calculate total number of !ZONE_HIGHMEM pages */ > for_each_zone(zone) { > - if (!is_highmem(zone)) > + if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE) > lowmem_pages += zone_managed_pages(zone); > } > > @@ -8648,7 +8648,7 @@ static void __setup_per_zone_wmarks(void) > spin_lock_irqsave(&zone->lock, flags); > tmp = (u64)pages_min * zone_managed_pages(zone); > do_div(tmp, lowmem_pages); > - if (is_highmem(zone)) { > + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { > /* > * __GFP_HIGH and PF_MEMALLOC allocations usually don't > * need highmem pages, so cap pages_min to a small This kind-off makes sense to me, but I'm not completely sure about all implications. We most certainly should update the comment as well. -- Thanks, David / dhildenb