From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37217C4332F for ; Fri, 16 Dec 2022 22:57:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83C9A8E0002; Fri, 16 Dec 2022 17:57:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC6A8E0001; Fri, 16 Dec 2022 17:57:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B3FB8E0002; Fri, 16 Dec 2022 17:57:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5FE738E0001 for ; Fri, 16 Dec 2022 17:57:09 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 21CEB16049B for ; Fri, 16 Dec 2022 22:57:09 +0000 (UTC) X-FDA: 80249681778.29.E6A5CE2 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2074.outbound.protection.outlook.com [40.107.237.74]) by imf11.hostedemail.com (Postfix) with ESMTP id 3A8EF40006 for ; Fri, 16 Dec 2022 22:57:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="OC3vwV/Y"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf11.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.74 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671231426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2EUv0V4VM5gI0P51Kae8hR/xvnjEhuuKqx9LwiQ3CZE=; b=4g6EEYIBQgcpaTeO3XJiV8gd6+8b1Jqa6znVLiMYkt951B5SXOORpZR7Xl7snB/KtUbOVX vsQFuAzkDk3nkBpyA/ad3/+Vab4kBGYSjPiqY3vdmiQzdhy0l9G4Y+y6ku1UhDoeo6idPA CppMA68pg6dspxrUxBKeYgZd/ALpG1g= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="OC3vwV/Y"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf11.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.74 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1671231426; a=rsa-sha256; cv=pass; b=KOnIfBR+qYVUhuh7eans4jVkUiFb7eKjw3KbY0c0E1TDzwY4IPn2KOQTGRo/N1qatFjfkI yw3u3bkRCSpQL1WkHxXy8FR3p7h3RcBJQzTLzNiVsqilV6MxSlfOy+zll7kkrx81Eb050I KtcJGQT+wboyxPBKbtqrbDyAETLAxDI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FDStdDbVlaMGEN9gptssgtBCUgoQ2GoiMZ+hwK+BMEXg3Mb6pl7ehvxzL/LPjf1W8H37DaLFiwnjoZhVDp12gNdAR54cFDqB6bg60WSEaUTAoWgVruxLC55oYmv9mm3Occ4rcmmfm6UVXpJRcWGzYcKEjSiUjFd10CGmBVAEiMtyRmKAYcemsnLbZQKEYzsQxGZEuYptcbFiVuysXf2/Cs3GIMU1HLYfhRRWuDuxCmKE1G6LpD4tpciU3Cv86col01rtSSNmSxnwaEcadNqnhpA0EX1H+uCcSbov+GN25HVW5aaHpPZfMjVDih/m3WaJcZwaK8JcJfP8GW1zVvVfig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EUv0V4VM5gI0P51Kae8hR/xvnjEhuuKqx9LwiQ3CZE=; b=QXmhKvzMsHU+6Ru9Mv1v0qO4WZxAXbuHGOt0XV70az9oLrZu43Nv9cRyLS8p8MeALdUWzoZLfVoYA6+CT+5qUtXl4+YZa3pJ6zVoPO9TsIQlDVsEWQfa8vzn8MNpBJ77fHp5qGP+V1vtLN9yKTiJEU3Y1jmBzPluHGxz+s0DhiyGvs2VGGgqKoZCpJdRM4aOCf7dPc8ALJD56FziwNDAtiMzzayCWDrtuBa2L1WlQIsyMVH8hJdOIBWllcAWJ+4YvSmBUVMzEmCvIFwGx0LRc2EtO4ts/lAZEjrtVjYhfGntVHxGkOTlo+EyTtp8HtzN+P3N2S7l+yZrTdxrqrqQiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2EUv0V4VM5gI0P51Kae8hR/xvnjEhuuKqx9LwiQ3CZE=; b=OC3vwV/YRHKNzjG6TU+oa7AkShUKvQTQmSzfzt8UP6Px4zHlg/P2mpfksC8SeU9P+JnU+k4aJ168/q4WHwPTT8F+30kGf9pFCydywhL2tGjWFRau4Cudm2hQZhUQmsR6ZOfpzf1hRBMtScMv+ntK9lfEExRj3qLsGvAdgyGpQUQq41Tf+fnu7FynuZQXUjAwaoTrDhW20gbQvz4tVUKRdGb91wihoZoPbuTLNIcqntlm9jph2xGY8NK5rA+fTsG0swQdmRs8pofKvx6/sJ01+BxufqpafRwOheX0C/fLyLmukKEEFqkLWEmB73KKHmwF0y6eR1AfQ5W5WVe3msmGHA== Received: from DS7PR07CA0006.namprd07.prod.outlook.com (2603:10b6:5:3af::16) by SN7PR12MB7105.namprd12.prod.outlook.com (2603:10b6:806:2a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Fri, 16 Dec 2022 22:57:03 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3af:cafe::f4) by DS7PR07CA0006.outlook.office365.com (2603:10b6:5:3af::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.15 via Frontend Transport; Fri, 16 Dec 2022 22:57:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16 via Frontend Transport; Fri, 16 Dec 2022 22:57:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 16 Dec 2022 14:56:49 -0800 Received: from [10.110.48.28] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 16 Dec 2022 14:56:48 -0800 Message-ID: <963ba9b4-6ddf-39bc-85cf-2feef542029d@nvidia.com> Date: Fri, 16 Dec 2022 14:56:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h Content-Language: en-US To: Andrew Morton , Sidhartha Kumar CC: , , , , References: <20221213212053.106058-1-sidhartha.kumar@oracle.com> <20221216142733.e2a716a4cd7ea55240d98391@linux-foundation.org> From: John Hubbard In-Reply-To: <20221216142733.e2a716a4cd7ea55240d98391@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT014:EE_|SN7PR12MB7105:EE_ X-MS-Office365-Filtering-Correlation-Id: 6984869c-c414-4ca9-1245-08dadfb8d8d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jQI42SaBUUhEBcvYADue9fgarLuyuk6MAGuxC+5dr4C6nHvmcfh4kuWsKKRMk0+b51ZTk3Rp3PZK9jznbwLyG1ROmgwAJ99BbAB7g+Lqh7NFNAhWjJncw1AaTynyjz9eF2TYtNpxVSKKKK3C0UlP2zpwclF6p0fvOZJbGpM+NaVn2UR0aif6nzsa2HzzSMd+cnS3P+0AY3qqQCXwIx2nfp+Cjy3/ni762lQtG9WNXBr+G00BJcWvd0jh2aN43AQBZ7SAm87/PkdW2QXUeyMBBTI3kSQSniemup3gGqmQfisli2w57/cAgs8zm1HpYBq9ejXSQZaUOEeXXPJdmbsZK5P1SYUCzegKOQsz17AI9u4iqLAu2MBG4AApN7tNkthvkj89CcmfIjlyzvlz/HYWrBvaZiSZzV4FdClsEpui3BcXdXjOpJXiRkUvSMrGH1slQTSWeDGgFeKeSXCZoR5PA+k0ehq79L/3GFVuZxesIGBGJx2jtYvajXWCeJ9t65tJb6feQu5IctQrtmIMFk25lVnN1j2oHgGUwdWau9LW9MCtOaTGcrSEdwGM+nApbX0pIQ6n0InGzuUq2zEulLNc/ECA+YJdS84bimXnzRhMGbtMJWOhNVr3aLzTlqhhw9l0sxS3zjHzOaP8OF9cJUqo+eAly67nO9B9fyKu71nPxQ8H8zIxREURAGTSJW0abk2162vLAs+KgX4aC4n98cC8qaI9raBK1fuRhgDzg0NX5nc= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(36840700001)(40470700004)(46966006)(16576012)(54906003)(31696002)(70586007)(110136005)(8936002)(53546011)(5660300002)(8676002)(36756003)(4326008)(316002)(26005)(82310400005)(47076005)(41300700001)(70206006)(16526019)(83380400001)(336012)(186003)(40460700003)(2616005)(426003)(478600001)(36860700001)(86362001)(2906002)(7636003)(356005)(31686004)(82740400003)(40480700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 22:57:02.9562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6984869c-c414-4ca9-1245-08dadfb8d8d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7105 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3A8EF40006 X-Stat-Signature: ayygqje5afusxgfa7xieap5ymhdus5ow X-Rspam-User: X-HE-Tag: 1671231425-295694 X-HE-Meta: U2FsdGVkX18Q/KK6+jAJLMhK25RflfhkaZopQ8SyJxWAB9Hc/O1whJTrNdci5YsZpODPgGfDuEol0EBTDzInoD7nvlWwZxypjpqFXUs5/UF5e6X36l3pdtQCNeltzcjh/8wYWDmV+q5wE7rORJh4C5SOt3raGAU0XtgzBt2r7NqGC40h6X6EH6uMGOFhqNA87ji4UIKOyk3fsKKMU8APz7ORexztX0a/O2f4+VIAzaUsJdXYM/HS5M6+UrNlfndNJkRL5NUzgQRQaZV5s4+afh2rzd18Zq0MzdsWHgfAY21o3rYqzC4yiqJZJQ/ynriKnv/cPJSoSI4cHhBWVrpX35BbdZD6oK7oWQ/8SQ68JMaVmA7FWwhwd3Gmxy9LOmiN1w/9itXsSkL0qzTUHuM2RXsqCmQ+EOnDZYv60Xooml4cyDq4DlJpzN+LOKbq/y0wQh3Ug2WU+r7a+oG4JWaUVcwMp3GERk6oGMmd9DxzCnYM+HmHJZALsD5vkNOHkvDFo2f1yxdSbFnaswwlNwHcTWZoN8FlB8Vn8NcWc683RYY2ZfWIbsMOhwLxDlwDiiGjQgjWLtAJGvwX2HkmstOcKInEuNNlg+Y8hvELw+TI+5yUJwMcevyrbwGhG6bguW5iA2fLYryc+uoSIdLhRBsfryFHRpr/BeHfG3PTd3jxXTF7hIkGGwdfuf7raXudMPoxAcf14RmvUJD8PCHQQBTFNUaQtlmBGTsaVmpoSAxwRihtStjwMJ2t3JCe5P2XbI0iTX29SRQXIHLk2IN49laKQMEoA2cEiVO0Dq+yRnsOy3yruzBIFO8C9i5wDyRE5nMJ9xgMW5sDuZANqHUpevn5H/T5ndNT/A5pv6H0QiSgEGQXKRHSQH48OoGerSdqFZHuRORMMELyp2MF9jbxjGpt3H8n/9ueXbuK0PbFNOEFVZbjLT4cXio4hZlnca2DTJ2TpE49JJbBjJOQPMNWjt8 YWZeR93f QSXyx8hcwHIw++5Es3zuXHlzaJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/16/22 14:27, Andrew Morton wrote: > On Tue, 13 Dec 2022 13:20:53 -0800 Sidhartha Kumar wrote: > >> folio_set_compound_order() is moved to an mm-internal location so external >> folio users cannot misuse this function. Change the name of the function >> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, >> handle the case if a non-large folio is passed and add clarifying comments >> to the function. >> > > This differs from the version I previously merged: > > --- a/mm/internal.h~mm-move-folio_set_compound_order-to-mm-internalh-update > +++ a/mm/internal.h > @@ -384,8 +384,10 @@ int split_free_page(struct page *free_pa > */ > static inline void folio_set_order(struct folio *folio, unsigned int order) > { > - if (WARN_ON_ONCE(!folio_test_large(folio))) > + if (!folio_test_large(folio)) { > + WARN_ON_ONCE(order); > return; > + } I think that's out of date? We eventually settled on the version that is (as of this a few minutes ago) already in mm-unstable (commit fdea060a130d: "mm: move folio_set_compound_order() to mm/internal.h"), which has it like this: if (WARN_ON_ONCE(!folio_test_large(folio))) return; > > folio->_folio_order = order; > #ifdef CONFIG_64BIT > > Makes sense. But wouldn't > > if (WARN_ON_ONCE(order && !folio_test_large(folio))) > > be clearer? That's a little narrower of a check. But maybe that's desirable. Could someone (Mike, Muchun, Sidhartha) comment on which behavior is preferable, please? I think I'm a little dizzy at this point. :) thanks, -- John Hubbard NVIDIA