From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4006C4707C for ; Fri, 12 Jan 2024 10:14:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40E696B0089; Fri, 12 Jan 2024 05:14:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BEB16B008A; Fri, 12 Jan 2024 05:14:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AD0E6B008C; Fri, 12 Jan 2024 05:14:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CAAC6B0089 for ; Fri, 12 Jan 2024 05:14:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EAD63120B90 for ; Fri, 12 Jan 2024 10:14:41 +0000 (UTC) X-FDA: 81670249962.05.C82F8F5 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf19.hostedemail.com (Postfix) with ESMTP id 645AE1A001E for ; Fri, 12 Jan 2024 10:14:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705054479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yBv1t4MFbmWFwPKgMJO0ynKoXwkgCL7K4/TMExh+xVQ=; b=NltTaM1i5mlacjiawyCgAlKQNtS0WtHEowV0PmWc+RlFFzlayHRYmtidO1uhQDWamV1O+/ NeIgLR8TE4n+Ek7z5hJzeBPRTjT+sHrf/XF9ediIx/vw5XUs3hntz8XDthaKsCUVGp1i5W ApaHeDgDv5LdWZlaaz7XjNXgYpk2bRI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705054479; a=rsa-sha256; cv=none; b=6GWltDhg1pIpJERdZvYBocSB0zcawjGaWXKnIHthZZnUzlHTCSA3jEPE065PwJ/uRJoY/w fbs7uhGquPEFpH6gFrhBnQPjgHSf7XqGo8gprPlu5BUsdF4Lm/xVCKOm3lIROh4bNAoJcy wzHE8QMuIrtSgmYwsV8w0Y2KLp4KQ3w= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TBHSl5GLGzGpxn; Fri, 12 Jan 2024 18:14:15 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 4D7D514011A; Fri, 12 Jan 2024 18:14:33 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Jan 2024 18:14:32 +0800 Message-ID: <962a7993-fce9-4de8-85cd-25e290f25736@huawei.com> Date: Fri, 12 Jan 2024 18:14:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] mm: Convert to should_zap_page() to should_zap_folio() Content-Language: en-US To: kernel test robot , "Matthew Wilcox (Oracle)" , Andrew Morton CC: , , Linux Memory Management List , , References: <20240111152429.3374566-9-willy@infradead.org> <202401121250.A221BL2D-lkp@intel.com> From: Kefeng Wang In-Reply-To: <202401121250.A221BL2D-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 645AE1A001E X-Stat-Signature: 45cdbf5sz3uh7z4kwkjjf1x4c66xz1io X-Rspam-User: X-HE-Tag: 1705054477-22819 X-HE-Meta: U2FsdGVkX19CRylcuC654hkSRpHUhtHG+JgukjCuXPl7BKMSzSQkrFZMY827j44qbSGsxbKx5XVDGYG0tzeJkuaCme05hoVlJXks3uKQcdI3dpOvNFCssY5SixICl12gm1iFHzUASzOH5o/Ss0UKOkOo72I6FDc+d7vBAodk/CSfictxse2EDp5iM6lwoHDA0CqB78h8q3X3xDwG0KCuNoNiByu0y6/ud9QOtgxywpSKg3hWgq3dEdvkVSPsOG3MM2+scZra0cvLqvysbfnWyq7PvpCWUgtSsSjGbDFIphYG51lmDx6TedhQWg2mKL78tjaUaUmxhDgA2YKx0k/tIlNg9V0GO7YBMOVLzaImgO0sCd3Ib7CQJfYkvlr58HVRhqA8R+xyCVA78fo01KYqgyKbiJTsG6bo3ILqEorjOPlTlWothKSngmclTwCKvekFSeTmAHgRqB6SuXJ/KbaB7F7tEdtdECGnhfAgZA3Cvms0jWYL/GNqP16GYYdkTnoomJxaNHtfrXEj+oqDnS+jBUJLY6nKmGo4vRXiq/CLy2gHEjNEeFGGJ3ERdedyU04Fn8BiESv+ZLoLHCLCsAcsIEZhOEnrX92CwdU4z/FG4eIhgbz2gSjgj7UF1SweWGXD/88a0OXGWIpF07cPNDxOlYk3U4Q3iK5MlohU3oPV0Atcl+aS2Lq0rWPMiLlyTteY40bH/BTyOeVRx71o6IFmBgluDSeG55CRWgDtg/IEXyFvJIP22PSiXMwepuAneO8VkrA5fwNQR3YaaBZ7eY7A5jCIYxCOvEPPpTEL8NhDnUqdFIrfjK7DWBBNSbAX4ZqtT1zeDE6xPNF9FKgXyI6ZhtqCnxkTHmRWLZ8NKGrdSJVNZmvhNZw8aDvYbmYVrEdqaAkdRZhMcZZjhnwFST7SoOnah7ojcFAj4Y90kFSxvyQwiGJYWrRBRTaJG9eRD7uQ2aJDS9CAYPR5LaUxGMM bv0FTHP0 Mu2C1mhHm5mwgiPPengIlaHhfQQ/D+Of5jVTiz5BxSkt6CbNSQIREV2Uc8fzItgfVaQfKFsqs/J4wsh0iUkvD7Qnvb/oFyuV236SuG1lKokljakRkB7xc6XpKzgq473ZX38SLmB80pVTw9gRbV6IYhQjmqbKZk3cr0VQI42wiJ0wEl9P5zGz1UPTfT2McD1d9ChZOsWIKlZUPo5CwpJC6yfAiIqx4de125mdsdMS852PBRqLBdwf7BZ9vt6GgzN7N8yUAJywRLptBZXOZOT6hPty/SIH7skN/DbcjEXDmj2bYOIEzXAisp7lf2up9G8QrmajFq2Q5ddx7XZ1MFMmtwmFdlOMZFSihipiqdsZvYRGJMSIkssRklQpMfDD+2Kl2aOWnFEXUHvMfW/y0NWibU2rZr64Uy7a7HM8d8GeUkmLg1+zT1ea3p8Yl73e+aniY3BUv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/12 13:03, kernel test robot wrote: > Hi Matthew, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/mm-Add-pfn_swap_entry_folio/20240111-232757 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240111152429.3374566-9-willy%40infradead.org > patch subject: [PATCH v3 08/10] mm: Convert to should_zap_page() to should_zap_folio() > config: arm-milbeaut_m10v_defconfig (https://download.01.org/0day-ci/archive/20240112/202401121250.A221BL2D-lkp@intel.com/config) > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240112/202401121250.A221BL2D-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202401121250.A221BL2D-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> mm/memory.c:1451:8: warning: variable 'folio' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (page) > ^~~~ > mm/memory.c:1454:44: note: uninitialized use occurs here > if (unlikely(!should_zap_folio(details, folio))) > ^~~~~ > include/linux/compiler.h:77:42: note: expanded from macro 'unlikely' > # define unlikely(x) __builtin_expect(!!(x), 0) > ^ > mm/memory.c:1451:4: note: remove the 'if' if its condition is always true > if (page) > ^~~~~~~~~ > mm/memory.c:1438:22: note: initialize the variable 'folio' to silence this warning > struct folio *folio; > ^ > = NULL Hi Andrew, please help to squash following change, thanks. diff --git a/mm/memory.c b/mm/memory.c index 998237b5600f..5e88d5379127 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1435,7 +1435,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, arch_enter_lazy_mmu_mode(); do { pte_t ptent = ptep_get(pte); - struct folio *folio; + struct folio *folio = NULL; struct page *page; if (pte_none(ptent))