From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E351EC6FD1D for ; Tue, 21 Mar 2023 03:04:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681C26B0075; Mon, 20 Mar 2023 23:04:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6306F6B0078; Mon, 20 Mar 2023 23:04:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F386B007B; Mon, 20 Mar 2023 23:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F1366B0075 for ; Mon, 20 Mar 2023 23:04:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0F9E141097 for ; Tue, 21 Mar 2023 03:04:23 +0000 (UTC) X-FDA: 80591412006.16.81448B8 Received: from out-54.mta0.migadu.com (out-54.mta0.migadu.com [91.218.175.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 094C9180006 for ; Tue, 21 Mar 2023 03:04:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XRudqie4; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.54 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679367862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2CzmygZ3+9dcEEzX9d9IRsXgfDbVX0/dCnDP3lROHyI=; b=nzGsuN0vzZHaJoy0qSXl2up4sD0y31LcfLn9bNEJfJwYTOt71/CGm/4Ijh0qMStO7boQUR KFiI5ZMzuYedo8IYe4mlugm3N/pVL02w5AJqDjHUKKt0iQ+3Xo5N47QLj6ICRf5ytnej5E nFeeC1T8XTLasZ1sYY+PvmQSeV/DhvY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XRudqie4; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.54 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679367862; a=rsa-sha256; cv=none; b=zseBfipxferc53iwqCKO/XuzuQbTlAXhbhNRxd/1N6pE2yQCjCu7kVZY8+dCbTf2WFAPPD F6CQDRY8nU1RMYmoZtyPMPldAH7LOLZFpfqfs+61C8aJ5iNyP+YOxr6Nwyjvjrk8eIUrvN TaS1DVcxyES95k/SkJnVQIGGJmlQS7E= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679367859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CzmygZ3+9dcEEzX9d9IRsXgfDbVX0/dCnDP3lROHyI=; b=XRudqie4wY/koaYw9RjFAc1kxFGp3McOvtX0jtPKxU9wE3Z56T8ivT/dyQlovSiQok2a/t ffkEdEdqj2iGLxgIdoh9GoaDkOGbnJyVVfB0OctS8xcS+ae5KP8QY5GSwgODj8y4RumCSl lY9os2eKS3biWyHMuZKSfPRtUcFrL1Q= MIME-Version: 1.0 Subject: Re: [PATCH] mm: kfence: fix PG_slab and memcg_data clearing X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230320142954.fd314c5e46c1d18887ccf8cc@linux-foundation.org> Date: Tue, 21 Mar 2023 11:03:41 +0800 Cc: Muchun Song , glider@google.com, elver@google.com, dvyukov@google.com, sjpark@amazon.de, jannh@google.com, Roman Gushchin , kasan-dev@googlegroups.com, Linux Memory Management List , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <962CB717-DF8B-490A-86A0-2ACE90209012@linux.dev> References: <20230320030059.20189-1-songmuchun@bytedance.com> <20230320142954.fd314c5e46c1d18887ccf8cc@linux-foundation.org> To: Andrew Morton X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 094C9180006 X-Stat-Signature: 51aksixem68hb5j5hxxowibd8tddhhjo X-Rspam-User: X-HE-Tag: 1679367861-183242 X-HE-Meta: U2FsdGVkX1/BFECjtV82If4VI7h9A75zvV+NQCTugEJ+wcZIXF61rjjssT0U5i2S4VhMaU2RY1h1WMsMTkHdEwE7zw4JVaCaPopRNQ/YJX3H3fcercBXGNODOatPnhd8D7PsKdicMnm/lc/pFsPqeTHA/i1TDSybdZboDeOsYXYXjHcBorM7PAsOj08XbDrFDlbamkAEvKbnDirlp2/x1PRYryeMgy9JwomPaaaZSNp+QFv+ppaFLyrlfkHYbWVrJQozzWJJF1dVk8Pri9Lj0Qh2p/8S9jr88OAJ0R55ryRWZrRHj/rHqOORTpn44bmXnnl8eeGGcmXxDhAwQ8znEXRHYL0kT2Wlb+hCj1/pJoimML/LzoPZp4/+nigzYvn6HWG0JbXUZMcR0Iv0FFU54t4yzoHofwHFxdr5VHui5YQmN7RYG5KvEcGq4VIxW25E4EEvmBjbIdroKjtWBvOkWTTd7te4sDpVpxe2hAjSyL2vJlwD3xdBz29oau9Dugh41qazK2tM3gqvMSur16QvWH0a1zUREO0H9z4NLFiicgeFptSWAVWBq1LrzdC9ZUYEMNLyfx7z4RIYttw2GYUkezhc8wj7bnAkuxZLv15WDuCWUs8Gvxjnr2Xg//+Y7+SqaD190GeSFJolMtZC0morgcJEHcsw2tBn8wEkFda4HakjPZWlWj8S4z5MSitXqihcjUAVyeGbrqK3DZ81Le7FLlST0KYy1nsB54E8h+ltjO148q+iyktdzLrj2qo1x1F4YM7L8/SAGUgLuqWDG0/zbcSxlescDt0Q5pXJo1sX3cYmkrMMP5TGpdrUJyutQukvvswfHhyy2bvfKXBGi927n9WppwTDwjNwd+h3pUcQ4cITuM2naE6bRJk7TNMScChjLzWABU/fcIVngwx2gtH1FsQtz1o5vpIQ5Cg0p8UuPxzrjajaHL79KHf6cYRx1NMprlqkTnjJ+viPSu9Scqc g2f+lMhF cNJQ+WCjGmSMCNlgMM5n4djQZTZQhmu3SQlWh+D3j6eikMewOsle7WUyRczfT8wGs5AlwEgOzGbrr1R4r4muNClipqucyncd3/thv3dAbmQz+1vN4mB3UiIDr1Oxh+0aEdMcG4QPlIxfAcZ9bzgkm67Sb63Q7JBTb6oQ5005qdfoDqn1Kwi0b7tXZhHCYtaapb0vL2Zxzj5OyQ7L/ZYC4zKDooVFw1Pq/HCPoXGos62twX4vT/ZBKdfWR+rxPrgnKX/b7DwUlyIHkksgsPxqcT2MfvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mar 21, 2023, at 05:29, Andrew Morton = wrote: >=20 > On Mon, 20 Mar 2023 11:00:59 +0800 Muchun Song = wrote: >=20 >> It does not reset PG_slab and memcg_data when KFENCE fails to = initialize >> kfence pool at runtime. It is reporting a "Bad page state" message = when >> kfence pool is freed to buddy. The checking of whether it is a = compound >> head page seems unnecessary sicne we already guarantee this when = allocating >> kfence pool, removing the check to simplify the code. >>=20 >> Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") >> Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation") >> Signed-off-by: Muchun Song >=20 > I'm not sure how the -stable maintainers are to handle two Fixes: = tags. > Can we narrow it down to one please? I assume 8f0b36497303 triggered > the bad_page() warning? >=20 Actually, 0ce20dd84089 triggered the PG_slab warning and 8f0b36497303 triggered the "page still charged to cgroup" warning. This patch fixes both warnings. Moreover, 8f0b36497303 fixes 0ce20dd84089 as well. So I = think we can narrow it down to 0ce20dd84089. Thanks.