From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6407CFC28F for ; Tue, 15 Oct 2024 11:34:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 063D56B0085; Tue, 15 Oct 2024 07:34:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2F406B0096; Tue, 15 Oct 2024 07:34:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D813A6B0099; Tue, 15 Oct 2024 07:34:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B5B016B0085 for ; Tue, 15 Oct 2024 07:34:33 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 705D112142C for ; Tue, 15 Oct 2024 11:34:25 +0000 (UTC) X-FDA: 82675628574.06.EED1FBE Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id C2FAB40002 for ; Tue, 15 Oct 2024 11:34:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=G4UrvigG; spf=pass (imf27.hostedemail.com: domain of maddy@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=maddy@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728991929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c69cTslBIDcPA3cDCJjH6VoeJG0oJsXagvXewdckmtc=; b=r9+hXntD4nngOb59KNPKnGnl4ynekFusoxH7FlWKJjWM+R3os8REreaOC/na8P0qw8MfN0 gI5jEpqNNlp71iHVHk1/5Qtq7qifFqfdOmw5QFF5juoFXXt+M9H7hey7t8I2/CjaPQA/AO K9YLUQxt5g2m5aguTgRwpJJMvxdvfPM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728991929; a=rsa-sha256; cv=none; b=zHvGffehbkzSLJlN5j9CI4W5jBuornQc9G0y6z1lnTEhoF0MVWgegCNJ0yp3eD3sBNLbFX CxFU55wVRr8EDryb8tULq67FkP1+rUrjCo6hOA6CKL49s98U3N+l6n7P45AWg8tdx9qKRn 3sOZhlTBkimlp+ij8DAUwUJsy0M8C1M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=G4UrvigG; spf=pass (imf27.hostedemail.com: domain of maddy@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=maddy@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49FAtf86013475; Tue, 15 Oct 2024 11:34:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=c69cTs lBIDcPA3cDCJjH6VoeJG0oJsXagvXewdckmtc=; b=G4UrvigGVysgYqKyXGpbIl 4oqWnPInuHUpNReoBb9tJ2k3JG6oW9X0rl6wKVRec6RJY7T+kPADWfsMlT1olu6s a8WLeP47EpJdTJ+SI6Wx7FEqFivxaMRytzqOX32DAVmEP3xeRmy+pdUocRojmBep /IQU2FfUG7t9gEAh5+rFWTB+NgBQZVB8emWFis9PPgnjiyX/D6ICpE1FcRHQTf4p IskOSf8QdEsAh/xNBS7pJ3ejYK6NMib3qRcgrrH55xKF0XUe2Jr9t3KmuXnHmv2F Y0Bty/zZnP8yJcH6jkVz+mZPRm3AZbZqiOSYHlF1yaESvsOd/tOJWvhi4VdV7Zzg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429q2fg5sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 11:34:24 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49FBV2Q7005449; Tue, 15 Oct 2024 11:34:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429q2fg5sg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 11:34:23 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49FB7sAT027464; Tue, 15 Oct 2024 11:34:22 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4283txkkrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 11:34:22 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49FBYLbw24183534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 11:34:21 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DB4858064; Tue, 15 Oct 2024 11:34:21 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F5415803F; Tue, 15 Oct 2024 11:34:13 +0000 (GMT) Received: from [9.43.1.152] (unknown [9.43.1.152]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 15 Oct 2024 11:34:12 +0000 (GMT) Message-ID: <96241074-7b78-4b7a-a539-ef8a1055c198@linux.ibm.com> Date: Tue, 15 Oct 2024 17:04:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v3 2/3] fadump: Reserve page-aligned boot_memory_size during fadump_reserve_mem To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige References: <030b6d46fddac126a6cf7e119bea48055338f0ed.1728658614.git.ritesh.list@gmail.com> <32496f6daeb4ed04c772ae484895241ab2ae1da1.1728658614.git.ritesh.list@gmail.com> Content-Language: en-US From: Madhavan Srinivasan In-Reply-To: <32496f6daeb4ed04c772ae484895241ab2ae1da1.1728658614.git.ritesh.list@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: SLW9cavwMcq6r2LFyWJAefiDDSWm_ram X-Proofpoint-GUID: 4sJHYHgueqtmFBC4Se70VM021ToNv91C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150078 X-Rspamd-Queue-Id: C2FAB40002 X-Stat-Signature: fbti4u8tfbaqfj3kjn1gqyp7qjuqp39f X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728992063-265054 X-HE-Meta: U2FsdGVkX18yoKWzCF6XFHWbFRtzPMrE3aSCebeX/gH0PgGVdBCccG8iRwoyx8JMlRiaPEE3MoHouI45aJEpk0ogAs/P3P7s/36HHrGvEJSNVBkcshJtUFiw3YaPFaulLld0XmAl4BZO39yTBSkzgsMw42X51alo8LckruzKRT2/se9fzZ6hzoOQG3DHap56iwDwpsJxKW861zAzzrngpKaghNjVmDTbq+1QxPUs3N/UptRa/lF+Pc4Y6Ep5zU0R8A86f8JE2fOj4ZuAHjuYTd+r753Lzj4riXEi3GqT7KnpVTNzZ9kkf00G1zfLxGESMeU7/wvY6MJkKcuAGxZNstyVU+LTzi04WB4hwyyck6IaJsTPMDOJIGgINP0g9K2lEivlhtyxGKF9ATUTLKinVM9u6EAo4oHKyTQG1AWMje8V2uvaxfx7H2p4Wcm062S0fooNt+FHGotokWDGSjHSH0ozxz96+oJBN8Upm88W8Xv0S6PYV9ozYxrD9S7WR1bTmTCmQTLlOf5rbCUdhsE3I/lDFmDvsU+rBoOsChfaylKsQ+P4mOKIKw2FEN37zejqOQGgzHCTWBv5atoPQhHn0NcPLgjzlJdd/CVZOaXw/KMO6K85K9FpyQLZgTB+1NPOBJSf/tTpuM9/1HgtYrzxncOnpKlWT893irzhn1fp104+rNty+u7aezkvdXWRpayKKmgfnO1yWxo/Ko7y/Bdmt59LtqjTpCR91c4k1nLIib7RrY2Bly0roZSjGlkiIFNF17m9cEErBkouF+GZo8bHOvGhpfbAcMrRdlKV3m/+io6Qi1ZVRuh6+ux64d/jNWpUJDkcq/sXsLVItJlC8H084YrtZL170piOLfp30utu9FaaBXEcXGyg+u4X0kE2tMUcQMDKGFQqhgakq48LSzfWCGGbBp7C1HkxBG9n/tT1/XyQNYmRxKcG2glSf1Um0LUlLp80Z2gtucHdc9CBLyQ qIB9vM7n fVNR8IPFQRn4e7hqN2g6iPVXIG6+z6Zfr445/E67zVIRmAYP9PPEgqrnf/MXfVbxdvO92ltq9NZBq0kV5Pzlkj3M6vm6mp59TE/M7Khoi0s6xnVuqO9fLOyRgU5deOKAYiH5823zJJTzgkrQ/ylhIr0Lywk28d77LxG29IQ5EQvoUxqpKa6QkBnmvC6jzWnPXwc+NO73hJ3pwLZG7n7ULPdK8EL2iidH5rbbNDJKVklBfxmg07mU0gyCn0/P0eJDwyaYTjPJQd7BwYOqZ4zozQA/R/mNtgxNxtdL7iYy07A1P7MUwRVFaOzjRItWPhJw0LK8nlQhW7aE1aNCao70ncjiKBEWVzExRb1SgXMTXqCdLIt9EyBtKYHwQUwlV5zcf8YsESbt5N8qdlUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: > This patch refactors all CMA related initialization and alignment code > to within fadump_cma_init() which gets called in the end. This also means > that we keep [reserve_dump_area_start, boot_memory_size] page aligned > during fadump_reserve_mem(). Then later in fadump_cma_init() we extract the > aligned chunk and provide it to CMA. This inherently also fixes an issue in > the current code where the reserve_dump_area_start is not aligned > when the physical memory can have holes and the suitable chunk starts at > an unaligned boundary. > > After this we should be able to call fadump_cma_init() independently > later in setup_arch() where pageblock_order is non-zero. > > Suggested-by: Sourabh Jain > Acked-by: Hari Bathini > Signed-off-by: Ritesh Harjani (IBM) > --- > arch/powerpc/kernel/fadump.c | 34 ++++++++++++++++++++++------------ > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 162327d66982..ffaec625b7a8 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -80,7 +80,7 @@ static struct cma *fadump_cma; > */ > static void __init fadump_cma_init(void) > { > - unsigned long long base, size; > + unsigned long long base, size, end; > int rc; > > if (!fw_dump.fadump_supported || !fw_dump.fadump_enabled || > @@ -92,8 +92,24 @@ static void __init fadump_cma_init(void) > if (fw_dump.nocma || !fw_dump.boot_memory_size) > return; > > + /* > + * [base, end) should be reserved during early init in > + * fadump_reserve_mem(). No need to check this here as > + * cma_init_reserved_mem() already checks for overlap. > + * Here we give the aligned chunk of this reserved memory to CMA. > + */ > base = fw_dump.reserve_dump_area_start; > size = fw_dump.boot_memory_size; > + end = base + size; > + > + base = ALIGN(base, CMA_MIN_ALIGNMENT_BYTES); > + end = ALIGN_DOWN(end, CMA_MIN_ALIGNMENT_BYTES); > + size = end - base; > + > + if (end <= base) { > + pr_warn("%s: Too less memory to give to CMA\n", __func__); > + return; > + } > just minor, other prints are all "cma", any reason for "CMA" here? > rc = cma_init_reserved_mem(base, size, 0, "fadump_cma", &fadump_cma); > if (rc) { > @@ -116,11 +132,12 @@ static void __init fadump_cma_init(void) > /* > * So we now have successfully initialized cma area for fadump. > */ > - pr_info("Initialized 0x%lx bytes cma area at %ldMB from 0x%lx " > + pr_info("Initialized [0x%llx, %luMB] cma area from [0x%lx, %luMB] " > "bytes of memory reserved for firmware-assisted dump\n", > - cma_get_size(fadump_cma), > - (unsigned long)cma_get_base(fadump_cma) >> 20, > - fw_dump.reserve_dump_area_size); > + cma_get_base(fadump_cma), cma_get_size(fadump_cma) >> 20, > + fw_dump.reserve_dump_area_start, > + fw_dump.boot_memory_size >> 20); > + return; > } > #else > static void __init fadump_cma_init(void) { } > @@ -553,13 +570,6 @@ int __init fadump_reserve_mem(void) > if (!fw_dump.dump_active) { > fw_dump.boot_memory_size = > PAGE_ALIGN(fadump_calculate_reserve_size()); > -#ifdef CONFIG_CMA > - if (!fw_dump.nocma) { > - fw_dump.boot_memory_size = > - ALIGN(fw_dump.boot_memory_size, > - CMA_MIN_ALIGNMENT_BYTES); > - } > -#endif > > bootmem_min = fw_dump.ops->fadump_get_bootmem_min(); > if (fw_dump.boot_memory_size < bootmem_min) {