From: Dave Hansen <dave.hansen@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
Tejun Heo <tj@kernel.org>, Chao Fan <fanc.fnst@cn.fujitsu.com>,
Baoquan He <bhe@redhat.com>, Juergen Gross <jgross@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
x86@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 1/7] x86/mm: concentrate the code to memblock allocator enabled
Date: Mon, 14 Jan 2019 15:07:59 -0800 [thread overview]
Message-ID: <96233c0c-940d-8d7c-b3be-d8863c026996@intel.com> (raw)
In-Reply-To: <1547183577-20309-2-git-send-email-kernelfans@gmail.com>
On 1/10/19 9:12 PM, Pingfan Liu wrote:
> This patch identifies the point where memblock alloc start. It has no
> functional.
It has no functional ... what? Effects?
> - memblock_set_current_limit(ISA_END_ADDRESS);
> - e820__memblock_setup();
> -
> reserve_bios_regions();
>
> if (efi_enabled(EFI_MEMMAP)) {
> @@ -1113,6 +1087,8 @@ void __init setup_arch(char **cmdline_p)
> efi_reserve_boot_services();
> }
>
> + memblock_set_current_limit(0, ISA_END_ADDRESS, false);
> + e820__memblock_setup();
It looks like you changed the arguments passed to
memblock_set_current_limit(). How can this even compile? Did you mean
that this patch is not functional?
next prev parent reply other threads:[~2019-01-14 23:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 5:12 [PATCHv2 0/7] x86_64/mm: remove bottom-up allocation style by pushing forward the parsing of mem hotplug info Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 1/7] x86/mm: concentrate the code to memblock allocator enabled Pingfan Liu
2019-01-11 6:12 ` Chao Fan
2019-01-11 6:12 ` Chao Fan
2019-01-11 10:06 ` Pingfan Liu
2019-01-11 10:06 ` Pingfan Liu
2019-01-14 23:07 ` Dave Hansen [this message]
2019-01-15 7:06 ` Pingfan Liu
2019-01-15 7:06 ` Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 2/7] acpi: change the topo of acpi_table_upgrade() Pingfan Liu
2019-01-11 5:30 ` Chao Fan
2019-01-11 5:30 ` Chao Fan
2019-01-11 10:08 ` Pingfan Liu
2019-01-11 10:08 ` Pingfan Liu
2019-01-14 23:12 ` Dave Hansen
2019-01-15 7:28 ` Pingfan Liu
2019-01-15 7:28 ` Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 3/7] mm/memblock: introduce allocation boundary for tracing purpose Pingfan Liu
2019-01-14 7:51 ` Mike Rapoport
2019-01-14 8:33 ` Pingfan Liu
2019-01-14 8:33 ` Pingfan Liu
2019-01-14 8:50 ` Mike Rapoport
2019-01-14 9:13 ` Pingfan Liu
2019-01-14 9:13 ` Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 4/7] x86/setup: parse acpi to get hotplug info before init_mem_mapping() Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 5/7] x86/mm: set allowed range for memblock allocator Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 6/7] x86/mm: remove bottom-up allocation style for x86_64 Pingfan Liu
2019-01-14 23:27 ` Dave Hansen
2019-01-15 7:38 ` Pingfan Liu
2019-01-15 7:38 ` Pingfan Liu
2019-01-11 5:12 ` [PATCHv2 7/7] x86/mm: isolate the bottom-up style to init_32.c Pingfan Liu
2019-01-14 23:02 ` [PATCHv2 0/7] x86_64/mm: remove bottom-up allocation style by pushing forward the parsing of mem hotplug info Dave Hansen
2019-01-15 6:06 ` Pingfan Liu
2019-01-15 6:06 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96233c0c-940d-8d7c-b3be-d8863c026996@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kernelfans@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox