From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A7DCF9C5B for ; Mon, 23 Sep 2024 22:34:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 299246B007B; Mon, 23 Sep 2024 18:34:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 247E66B0083; Mon, 23 Sep 2024 18:34:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1104A6B0085; Mon, 23 Sep 2024 18:34:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E7EEF6B007B for ; Mon, 23 Sep 2024 18:34:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 699021A164C for ; Mon, 23 Sep 2024 22:34:07 +0000 (UTC) X-FDA: 82597457334.09.82E680A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 6B14BA000E for ; Mon, 23 Sep 2024 22:34:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eePA8gnV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727130831; a=rsa-sha256; cv=none; b=FloQIZzQpw7bxIqriPpZhBHtJdCzblZP2VTj44DIChSoh3slCqoijjz8IsZBAkbCZgd+Rg mR93k/jmwj+GXMUJDYVfOcdEnse1WMgUmRvVtJ30wVa3/p8aKYHwapq9kvmzw80RI6NGpk 9Bu/X1NJC3R0mgkzpxjKYgCtAM5n/Bc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eePA8gnV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727130831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jTkM6enpKsq/HPP1aWcd0UHOFBRJuXPpDuW+0fAnEgU=; b=1S6HMiXXUj3zTN/LLbzBOh2a4lh5v+qA7P33meYQjBlVM4VKU90mPrAkDT8sqDuwuqwaLy HPbIh2MilHexvlDR0Bt3gs6jMyCMvdh/OHih/1h011xpT7RSskmhsN+1nHaJFV+1hQTjPC ZjhuPU4SeCsNDCeo1PjuLAxldFygElA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727130844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jTkM6enpKsq/HPP1aWcd0UHOFBRJuXPpDuW+0fAnEgU=; b=eePA8gnVy+KpeSID2jCvQ93ToonI1G/92XpJFo8sviMmcByFNBU8/QP4LByxwkc2JIWZc7 9+pR157GGaaL/A575t2qQkg02BiYUKEpBoz3s38Si/QVXV/Oh/5A5aiuDaDE6SmvcguIdB gJAZgWLfnvhkj2c5Zgp6vam1jIozw2s= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-vMyy1_3ZP0WVkfaK3Q6znA-1; Mon, 23 Sep 2024 18:34:01 -0400 X-MC-Unique: vMyy1_3ZP0WVkfaK3Q6znA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2BEF4190C4DA; Mon, 23 Sep 2024 22:33:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.145]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8F15319560AA; Mon, 23 Sep 2024 22:33:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <0f6afef57196cb308aa90be5b06a64793aa24682.camel@gmail.com> References: <0f6afef57196cb308aa90be5b06a64793aa24682.camel@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <20240923183432.1876750-1-chantr4@gmail.com> <670794146059f85a30efd7cf9d6650375d987077.camel@gmail.com> To: Eduard Zingerman Cc: dhowells@redhat.com, Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <961633.1727130830.1@warthog.procyon.org.uk> Date: Mon, 23 Sep 2024 23:33:50 +0100 Message-ID: <961634.1727130830@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspam-User: X-Stat-Signature: 7i9x5pkpwjth338bn53zpixhi5axstsc X-Rspamd-Queue-Id: 6B14BA000E X-Rspamd-Server: rspam02 X-HE-Tag: 1727130845-894186 X-HE-Meta: U2FsdGVkX1+ixLwS2vOaDJt2+j9m0Y80GYAjIiP71hCgRuF9wKD39XCrl0OEUkmtkzLf8EmmbrPxp32irUtsxNxtsmWXkVlgJhXsC7OryQxEbC9diiyGEDTTqpWE4e0sU6SKjssfp4BqfW+l78qeumKNt9FvwzoIgZ9BZg55IguEW8FTcPi2jwL5nq3wjMXdzeKVvThLsfpstnXLYkZ3WITu5GE5KanAcwoN4oMWfrS/n0lhrb9wXSmcvQjiz60d3SK/NDALQiGwvuevY8mjZHj0atGj0vJCYykksGIwNO1ibIWgjL1+urLPwL1R0+OiYkueytkgc73ZtpLNFMPap1ntREKPQdXtmYjjOYDFXfnzMtBccUynFQ733GNNhXx29oqtIHkUrgaEUfaL5q7f3HztCTkA/98AzQFG2meI35Cq30nwV4fi6zKPf0IUw/F7CJ7xpgPdffVdl9Z6K1LNi1yZ8Qg4No+VTVKTK4WjOy2LXReGlKKoYLa689ChAVFX2SnrgShyd7vVQoFyglJgysDFFJZGI9x+RjX6VL6oZbxsMNR9NsMtqeSJBB7C5yP9IGwDhTPaaC91Jwxr33EX8OobRj4a3WdZgDXDeMjIM5YcY8w8fEbOTpI6mlAzkqIAuYIvu2XZaOALmuv6+TlIZ/M6xq+hfDMA1AX67fx5wOlLsOi0EYpwHyhfFqMv2Dodv/ty6hb/DM9Zj53mkvx2+W7ysCqlLPaFzg0z0K/+vJ4S5quBdE6upcNWzh2hR963m5xV3PPsiFt/sEOw4xe/8ixzKvsmU/owj5RfWPNvnKCjBYCCNufwn6rS85qevmv9XthQJQwQ2W67o4djENTgKAUmrjQzE3OfH+CoJxubhCkBtcr4Rksp8eAM+U21Lafw9OZ9tWSci90IR+avR0uvB6iULZlXpYXeFsKvaxoHEY62hNR4+TS+LHlUZsQM9PMLlfmrX+etj8up9Ir+jt8 fqARmB8x 3n/mS7AZuR1YcT5P1zfKGWn8I2zZ4+TCQXHgNb3gROu0DP9FXAqtqmSJeuRYtR0aRgO1liZd2cOg/bOi5+iX8k6gMSWRxWmWjqTLitex3EzsNcqbsVVJrJVXzDRHsFHsTbZ5EbdPAvg/UHVdz8uTelqKgtRqT8LZCKsYoOUS2N1rIcIvQMlY5fyQD+feUp652VKq0mIvXgFCjsZQlrofgtkSLX19hDYG6R5wjDSS8GHnh5+EQvcVNiaKsg8VpI6PVFQ32969qkFR94ONwYFLFVEZ5TCHwoZ3jYRamLHhQKTfROMaU57Gw620pMISziPjv3m12oAe6qKi1WN45dl16QpudZKehu39oUso7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Eduard Zingerman wrote: > - null-ptr-deref is triggered by access to page->pcp_list.next > when list_del() is called from page_alloc.c:__rmqueue_pcplist(), Can you tell me what the upstream commit ID of your kernel is? (before any patches are stacked on it) If you can modify your kernel, can you find the following in fs/netfs/: buffered_read.c:127: new = kmalloc(sizeof(*new), GFP_NOFS); buffered_read.c:353: folioq = kmalloc(sizeof(*folioq), GFP_KERNEL); buffered_read.c:458: folioq = kmalloc(sizeof(*folioq), GFP_KERNEL); misc.c:25: tail = kmalloc(sizeof(*tail), GFP_NOFS); and change the kmalloc to kzalloc? David