From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB76C433ED for ; Fri, 23 Apr 2021 15:01:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB13D6145F for ; Fri, 23 Apr 2021 15:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB13D6145F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FC526B006C; Fri, 23 Apr 2021 11:01:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ACA36B006E; Fri, 23 Apr 2021 11:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 575286B0071; Fri, 23 Apr 2021 11:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 375F46B006C for ; Fri, 23 Apr 2021 11:01:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E62761802EB23 for ; Fri, 23 Apr 2021 15:01:29 +0000 (UTC) X-FDA: 78063945498.01.37409AD Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf04.hostedemail.com (Postfix) with ESMTP id 4ECA1797 for ; Fri, 23 Apr 2021 15:01:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 01D15B14D; Fri, 23 Apr 2021 15:01:28 +0000 (UTC) Subject: Re: [PATCH 6/6] mm: Constify page_count and page_ref_count To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20210416231531.2521383-1-willy@infradead.org> <20210416231531.2521383-7-willy@infradead.org> From: Vlastimil Babka Message-ID: <960066da-c982-f6c7-ddce-73c054a6a843@suse.cz> Date: Fri, 23 Apr 2021 17:01:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210416231531.2521383-7-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: dkeeroo63e3dpozh7eweifaeurpiirfk X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4ECA1797 Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1619190086-481357 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/17/21 1:15 AM, Matthew Wilcox (Oracle) wrote: > Now that compound_head() accepts a const struct page pointer, these two > functions can be marked as not modifying the page pointer they are passed. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > include/linux/page_ref.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index f3318f34fc54..7ad46f45df39 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -62,12 +62,12 @@ static inline void __page_ref_unfreeze(struct page *page, int v) > > #endif > > -static inline int page_ref_count(struct page *page) > +static inline int page_ref_count(const struct page *page) > { > return atomic_read(&page->_refcount); > } > > -static inline int page_count(struct page *page) > +static inline int page_count(const struct page *page) > { > return atomic_read(&compound_head(page)->_refcount); > } >