From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A593C48BC4 for ; Tue, 20 Feb 2024 08:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 717356B0078; Tue, 20 Feb 2024 03:48:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C62C6B007B; Tue, 20 Feb 2024 03:48:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5672C6B007D; Tue, 20 Feb 2024 03:48:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 45F016B0078 for ; Tue, 20 Feb 2024 03:48:19 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D72411A0593 for ; Tue, 20 Feb 2024 08:48:18 +0000 (UTC) X-FDA: 81811555476.04.BA13DAE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9ABC7140003 for ; Tue, 20 Feb 2024 08:48:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XM56Crsg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708418895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jE+NRG5Jai/u4VO86x5WSunHbwJ2hR8+UZgnT29myF8=; b=u5HzDPpwcesMXNSkT2gluoj6sugdH52f7Leb1x+IYUAIjYX8e2Q9tbPPcd49CBvKhlneLS EBpFZL+fSXYP9nndgRn88Mx5v+E67TsKbk70kJxSboiSonpboSSq9YwoDXzecN6+ZNW2l3 W5ySPds8jHKJaWqO8RZ/NUT41CoZpyM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XM56Crsg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708418895; a=rsa-sha256; cv=none; b=k0SzLI3dgu5WQzZ0AjTCHIoo/Pfk2st4RrcmaoP119UygyIjO6AMULtJRzz7kjju4kDOdf w8hevMsfj/tF5HfXkyYnZdlK2MCAnRtjq76UZ93dIGhTWaGJ6Be+r3NRpZ8RztfDTqU74u coT4EzrSp7oGcUFIonEYRvUHdWmGn4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708418894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jE+NRG5Jai/u4VO86x5WSunHbwJ2hR8+UZgnT29myF8=; b=XM56CrsgP+I0rk6cSJ97zv6AwFSpGZ2yKVpUi2r+dRpvPwmMdBBW2shRNDvnLuZv+OVcFC ylrdYV6FeZyhN5O2dtTz+e0KSKNsBx4zF3Xlo+azBFtT+GQGvOLKEBe65f0K//MhlZTFd5 7PJIQwqWvjd/nWc9iYv85hBDycsMF+0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-tbPXJDvtMn2_bTeNESuFnQ-1; Tue, 20 Feb 2024 03:48:11 -0500 X-MC-Unique: tbPXJDvtMn2_bTeNESuFnQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-412565214c3so20097725e9.2 for ; Tue, 20 Feb 2024 00:48:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708418890; x=1709023690; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jE+NRG5Jai/u4VO86x5WSunHbwJ2hR8+UZgnT29myF8=; b=siv/C5JlaUmB/vlNvd2jZp44GLZ84cIM1dpoTKH7i2ZNl+Jki9wYS6ouO//mzU6ZSc y0V6RwwWQO0wY9PUaPUwIXg5Jqt5c9eXKEphBwmelpjn/r+M5S9FO4vY0F2dIEgNTfPL cy7nBTLLH4Qr+heu+IguXysr9Fidsdt0SaQX3eictuPSm9vSlbM3Z2RWBjsM4V5R0q/S 3SscB/YdsXHvBF0/bPlkVoLmIY8eUMnZGOabscMw6AIGhHUJUNc56SLENtBc9+dL4u7G l+w+Z7u4sQpftGHoG8qSzF/YydzwUoZQTx5zqArlZWL8+94+YuWmzy45zi4lZsJv6Blo vvmA== X-Forwarded-Encrypted: i=1; AJvYcCVZU+h8RiGbdrAYVqKr0agcwm96N6ygRX1h44azpBbYmTwhr2rJ8Qandf69++8zxFjXiWnCo9xTsUxKAaovhszNnyE= X-Gm-Message-State: AOJu0Yzzcs/7Ggev/oBQ4Z1ApBfmX5teS+/xLQBvDm7ZK212DvxNBvrd tcvjjmtVabxGxg+5CUQg7784hr0zzlQFnUyYa3HXUf9ilH3EMUsPsUHiAovNKq+mUr3qG2kT9x1 p7z0FDmQWxxrBSxSXsPU+1IMDLQuzH6PsKhrc6R8KL5GYdzEL X-Received: by 2002:a05:600c:4691:b0:410:c25d:37e9 with SMTP id p17-20020a05600c469100b00410c25d37e9mr10309626wmo.16.1708418890195; Tue, 20 Feb 2024 00:48:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IEK7Xan/vm/PZMeHodtFHhBI0/9gn0hYjvl8SM7tt8BClIw12vF9L0yXJTnfLuMXUWn2DUjyQ== X-Received: by 2002:a05:600c:4691:b0:410:c25d:37e9 with SMTP id p17-20020a05600c469100b00410c25d37e9mr10309600wmo.16.1708418889804; Tue, 20 Feb 2024 00:48:09 -0800 (PST) Received: from ?IPV6:2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb? (p200300cbc72abc009a2d8a48ef5196fb.dip0.t-ipconnect.de. [2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb]) by smtp.gmail.com with ESMTPSA id u7-20020a5d6ac7000000b0033d1500b639sm12755646wrw.30.2024.02.20.00.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 00:48:09 -0800 (PST) Message-ID: <95fb8698-2fdc-4b4d-a48e-5fb33c75162d@redhat.com> Date: Tue, 20 Feb 2024 09:48:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/4] mm/page_alloc: remove unused fpi_flags in free_pages_prepare() To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240216170432.1268753-1-zi.yan@sent.com> <20240216170432.1268753-2-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240216170432.1268753-2-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8sknwos6iic796hp5owns6epxb6ur6tt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9ABC7140003 X-HE-Tag: 1708418895-776076 X-HE-Meta: U2FsdGVkX18cclJRSN23Vrwndu9T3OekTOhnWWTIWVtu13TQewgVDWoXcMa58n0jdO587H9ezxvhgVg2is/D6mpMzSDddzX1PwFhGUVDW4oxXKgc1ekUKyZ/aTW2Q7MUk1X0LetINuzqtvRihzFevIoNNhuSDmKxtifG8ma/aH7gynzsk2GDx63pO1G5lPqFX88FaqRS/GepkKE90udgna+sdgfjMJW/I2Eisnz/DERfs13AhRmGfJSiiNQZkWs9+Oknkw/FjIlVsoJVm72zqvrulHCDKAXqUlDjlvUbh4K9G5BMYqZapsc9gX544bFuCSPSMFrfXLbQrMNqv1No8xDHCHGUPl8nSgUeuPQYfdrJEDbZe4/4aKPma+XkKYrzF9cFLlC4qQN7LFzij/frF+m6fJIlR97hToer1qaTZk7yPkZBzaI7EiLEz6/HSsU6SgNM49A8S/km+8/HcliM22MAaUk/x25oJlWQC+lB9Sr7mt40LEY0mrLkrbxPVPgqn0PP5OcF/UfvhIF8KF1VIsPJnvKiBZFerhAWsfzy+TvT790vflapezHCa/7WuTt6mp+Wxs5FZVFX5ypn0CKu69Gta79AeXsh0+XHrSyoxdSZhRLAcP2JBKUruO1GyIG6JxRF6GvT+G7IcpTbMdNk61TkNSU6DvblzVDO01ntwUUOKPMgsZlbwD7nf9Z4P6DzryC1OXIo9Ery44bSdRS9tvNsTwuG15dBn+p2vsb1psp/Km0c9IBRg+g2L2M3Un8EVu4bghdmQ3RkRGO4KHNOUbRIzlNwMIQ++uSen/knWtw6CmJIyQjkUbyNgb0smuOs5r/ICPTyrA6u9IC3JodNpBFZTtL+QaHmpR3PZ2x5yEUSyOnXIZxw1G5tLpyBIv/aOTGfOyk0QqD5+bKzTORtKFgAgk/olNEgYBIN1FEOuRSgToeWdc77NW6snQ35YCZwCNWSnQqoESwm3x3pXZp BMuWwbPG KSykBix4H7uQuu7GxckpMsbie6RBBj07nPqsM6f+PBb/h52AjN5oCaWwWveRC8b+kPd4FPnMCfEX2jJAXXgQR/JwZ/WTkClCef1ivwr/V8m/o5Qq7O9yqij89DMrYfWR/3iBF13APhjdVFJpDVKdvXpPde7jiUDQ4fwh3RLqllkanmsFxqF3HBNh4Zqm612ANoNQdcdrVEJzr7rf81BCqcxowRIHWp0Uhkhhv++dG2Z+nYfcTha/As7pL5n3Uk2vymEPNm3YOQTUGeu4UpskdGGiOqnArVqjIJ57c0s0Wf+uPqi7dtaGkoDdagz6AuQXGYOtQov/6GJ6vx8B85eDBP3EdKvAaRLIKaEJA1xEIb94gybmtMUQI7eu0JWY68qHyFbeIUcY2d3+ofa2+LUdfOqfxO6CcsUsmskPiY/GQp/qAN191oTHVDQp5pIh0T6JzFpu8aAkyBrOnJBjXFrD+zbsnWB540LzLf+1mUA8dag+3lQ9DR7TYTV6oc93t+Roq8wGkwfyjBIZliqmVEkY11okkEqI2xWKikeMemAED4fKS6BNkjFUhwHsttw7/mvDVR6rjVkgDDTziD1yy8NdVMpgmcDeorFVd9qNGQDumCSmwcds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.02.24 18:04, Zi Yan wrote: > From: Zi Yan > > fpi_flags is only passed to should_skip_kasan_poison() but ignored > by the function. Remove the unused parameter. > > Signed-off-by: Zi Yan > --- > mm/page_alloc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7ae4b74c9e5c..70c1ed3addf3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1061,7 +1061,7 @@ static int free_tail_page_prepare(struct page *head_page, struct page *page) > * on-demand allocation and then freed again before the deferred pages > * initialization is done, but this is not likely to happen. > */ > -static inline bool should_skip_kasan_poison(struct page *page, fpi_t fpi_flags) > +static inline bool should_skip_kasan_poison(struct page *page) > { > if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > return deferred_pages_enabled(); > @@ -1081,10 +1081,10 @@ static void kernel_init_pages(struct page *page, int numpages) > } > > static __always_inline bool free_pages_prepare(struct page *page, > - unsigned int order, fpi_t fpi_flags) > + unsigned int order) > { > int bad = 0; > - bool skip_kasan_poison = should_skip_kasan_poison(page, fpi_flags); > + bool skip_kasan_poison = should_skip_kasan_poison(page); > bool init = want_init_on_free(); > bool compound = PageCompound(page); > > @@ -1266,7 +1266,7 @@ static void __free_pages_ok(struct page *page, unsigned int order, > unsigned long pfn = page_to_pfn(page); > struct zone *zone = page_zone(page); > > - if (!free_pages_prepare(page, order, fpi_flags)) > + if (!free_pages_prepare(page, order)) > return; > > /* > @@ -2379,7 +2379,7 @@ static bool free_unref_page_prepare(struct page *page, unsigned long pfn, > { > int migratetype; > > - if (!free_pages_prepare(page, order, FPI_NONE)) > + if (!free_pages_prepare(page, order)) > return false; > > migratetype = get_pfnblock_migratetype(page, pfn); Likely due to commit 0a54864f8dfb64b64c84c9db6ff70e0e93690a33 Author: Peter Collingbourne Date: Thu Mar 9 20:29:14 2023 -0800 kasan: remove PG_skip_kasan_poison flag That removed the usage of fpi_flags in should_skip_kasan_poison. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb