From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D136C54EBC for ; Thu, 12 Jan 2023 08:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83EB18E0002; Thu, 12 Jan 2023 03:45:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC8A8E0001; Thu, 12 Jan 2023 03:45:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DBAD8E0002; Thu, 12 Jan 2023 03:45:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F9A18E0001 for ; Thu, 12 Jan 2023 03:45:27 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2907D140293 for ; Thu, 12 Jan 2023 08:45:27 +0000 (UTC) X-FDA: 80345513094.26.50D7C95 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 24C03C000D for ; Thu, 12 Jan 2023 08:45:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iPnMDtmu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673513125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QRkGofy0rOYQohBlbN5nSy8RN48skKljdqEjml4OAaw=; b=7pNKW7bMBoY2JB9QXweqA2bGJP+RTZqQZWN/ve6drlou3TkAsM8mbRuRPMWIR+iiqNmiwY alSBVrfy9TvTiuqNPghzfKF2S/hRVhI7WB24/RU8X0O0B7lcwOwsRgWrj8SgF+FwLlEy+j V9Kaeuk48RB+i6bMRYynagHPXDAOlZY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iPnMDtmu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673513125; a=rsa-sha256; cv=none; b=Ns1MtTZGof7TEJPFvsUeIqqy9bigQrenR8/LIlyvZvz2O3LBHOm3VLdaddwwBZcC8O7yrY lSQT3hCt14T3K4g5tSPdCIeU+2Cnn1YiI/hk/9vCyMmYULAPlZrAMJU+kAxB8kuUk450lV t0uDPsVrWsRVseMxmgF49x6RxOorf/4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673513124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRkGofy0rOYQohBlbN5nSy8RN48skKljdqEjml4OAaw=; b=iPnMDtmuILR/vGcbTYDNaQGz47PI5WZj/cC7BTD/fhENPTfGhgeveKCxycIG18gy3bZBZY 4f3/YQNz2MhgEUk4QHoAFZ6i95mM6Kcoa4Eb3t7EF0fvjfh0M3LNqDUb802lP3VfjrD79u oW3AMbphzV8caluzXLcn84CMrxjSDB8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-tmmaR1OjPCaaUUPq7LjdDQ-1; Thu, 12 Jan 2023 03:45:23 -0500 X-MC-Unique: tmmaR1OjPCaaUUPq7LjdDQ-1 Received: by mail-ed1-f69.google.com with SMTP id z20-20020a05640240d400b0047028edd264so11909561edb.20 for ; Thu, 12 Jan 2023 00:45:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QRkGofy0rOYQohBlbN5nSy8RN48skKljdqEjml4OAaw=; b=JwhPefq92oB0v9AK8O0h21XpqJQb109T9iNfNugz63Kf/96EJYAyH7pQl+NMN1TUhW CjR3m3vlYV8M2mKu9gP7IfBop2dn1tKhkgiCFKC0Q4bewAT+JfbSoG6c/NXJfk8oiL4e ODnPc7msNMpbPkF8VQ9rMJ31/tPbJxPGQ9qw8wwskL9cjxk0eQOx4a/mNLfwYsWW734T 8Bm8ioCdaGXicvbqAQ+QCt4Yw1txmPXeNEApnqzhXU8yYD/a8z25TE/XvTeFdcXNDD7Q i+LpOHy7s66Q2j5avVC2RRh8Tl36k41MiJ5ku2yDGHlX24VdEF2ar1dFNE+HlgsmWNr6 gi7w== X-Gm-Message-State: AFqh2kqD4X886V44cmaMWIrXhA5KnlB0db6/a34kWbOMfgCy4lsQonCi 0Tr4rMvyQJ5lWQ+CpPqEDWdy1n3+lzeEiIHFP0Tr83QAwBo/ResCrSMu25FOcfeYfEMnZO5b++X XNnKXb4064tg= X-Received: by 2002:a17:907:1b0b:b0:7c1:6344:84a with SMTP id mp11-20020a1709071b0b00b007c16344084amr102056835ejc.5.1673513121926; Thu, 12 Jan 2023 00:45:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXu54vDYgLEuxRyxp1eTz+c6OzQAOq5kS8s1aP1PTT89lIebzPDO4yj3/Xck4uxhw5HLniQNWw== X-Received: by 2002:a17:907:1b0b:b0:7c1:6344:84a with SMTP id mp11-20020a1709071b0b00b007c16344084amr102056814ejc.5.1673513121707; Thu, 12 Jan 2023 00:45:21 -0800 (PST) Received: from [192.168.42.222] (nat-cgn9-185-107-15-52.static.kviknet.net. [185.107.15.52]) by smtp.gmail.com with ESMTPSA id r2-20020a17090609c200b007bd28b50305sm7182953eje.200.2023.01.12.00.45.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 00:45:21 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <95ea32dd-8605-f1ac-3799-400918e29e07@redhat.com> Date: Thu, 12 Jan 2023 09:45:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: brouer@redhat.com, Jesper Dangaard Brouer , Ilias Apalodimas , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Jesse Brandeburg , Andy Gospodarek Subject: Re: [PATCH v3 18/26] page_pool: Allow page_pool_recycle_direct() to take a netmem or a page To: Matthew Wilcox , kernel test robot References: <20230111042214.907030-19-willy@infradead.org> <202301112022.zmClDxtO-lkp@intel.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 24C03C000D X-Stat-Signature: eajbttxcww6trtt6wjgso8qnghykoeyn X-HE-Tag: 1673513124-902463 X-HE-Meta: U2FsdGVkX196ZGrf0aVTY/9cD+liafHdHrb0ejM4BUTeVwLiHIRYYcRK1rVJhi/tdCnZdwiIXL39VTzJyGXwneFICT/oLzd1Vxq5tnjM/yiLsiCp/H/HiTJnrX4MsMx9WkmS66TKpDZgmcJSBRBV+8J4xcEuuwmwr0L8N4RQEGCaWC2XOIG47EqrlHOx7y1MgDFVvOjRIfPbneUXmSlS6SmL/zykhnmZeYtldZo73yDZtCIiS0TrtIXFWUk16BTCN1CvCsnEqFPrjM2CFce+KOqEHDUevzno1P3Mdb72QtjdaBy2IDpiXQopu0Ydq7E6z1uSHyxDLPGeeBjIG6tEGmN61GVUVa8MlDFWlh1G/os9bcnII6PpJBmKitKntRM1jGOhaaL84G7QGs5v7n1hNEYs1CoWuePLfJAB4d4aYl9Hp9gn8Rq/IopSz8u9Mo2/n9SJ+o61QUznoPr7zyT0S6n0jF1iYLEyg1wXf4+ytPQixIMJ2sIE3go1p+z6z0Xx6+cBIrlquKySLi66N1DvO5JMvCU+dG5v0Ttw2Idlw5YVjAtNa8eWFSlvTGh9D5lBSFhgQJlsHHBrH34nSHvPzwe0XotLyK8aTQUsoAKaxfjfN/xz1+/NkXTvh/2HWsBkCvXck9xm5gM1EEg/8VHKxj682sXST/0o5dPd2uUk0QIxurnQOUzyYCEALS8GVSOdiWRRd+MSwwapEyd6FGzTQxGJzEy56K+v/34jFXrIvzwwznOxmdBtL1U6BhMXD2tAduD5BDAPOhKwelvoT81w7AJoDxsj+lK1qn4cZhpQ1xlzPpKswYTgYRYPigPHQHfDMPvMuNtex4LPHxO1Zh0Xe59gmh1VCmkQLqtQGIgarQqR2FDcRNsDqrMDTxSEhSIxnB+BC8wExhlG7/fmSX4iQ80/D5dydSE/GcdttZfOipYntcV48pqmGR4LXPXXgEppWtpvqE7Tabw5SdL82gS l5hDVjOT n1CNbPrFT+CW/6DY8T430KWhEvE0lHoPnybOdIQd7cJH9vxr0wtZTPBY1abuR7/Iat1C+u937Ds/iXzjDQ5dBlhvoVy0lm+X6NImD9SOrtpSBlcdEqfIckttiuCG067a29J/o+5oUHX8/Fg/7hVA1jYb3baRJu9EAD1tB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/01/2023 14.43, Matthew Wilcox wrote: > On Wed, Jan 11, 2023 at 08:48:30PM +0800, kernel test robot wrote: >>>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:2978:4: error: controlling expression type 'void *' not compatible with any generic association type >> page_pool_recycle_direct(rxr->page_pool, data); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > I swear I did an allmodconfig build ... don't know how I missed this > one. I think I'll make the page_pool_recycle_direct() macro accept > void * as well, and treat it as a page. Once we finish the conversion > to netmem, this problem will go away. > > ie this: > > +++ b/include/net/page_pool.h > @@ -485,7 +485,8 @@ static inline void __page_pool_recycle_page_direct(struct page_pool *pool, > > #define page_pool_recycle_direct(pool, mem) _Generic((mem), \ > struct netmem *: __page_pool_recycle_direct(pool, (struct netmem *)mem), \ > - struct page *: __page_pool_recycle_page_direct(pool, (struct page *)mem)) > + struct page *: __page_pool_recycle_page_direct(pool, (struct page *)mem), \ > + void *: __page_pool_recycle_page_direct(pool, (struct page *)mem)) > I'm okay with this change, and you can add my acked by. Acked-by: Jesper Dangaard Brouer Maybe broadcom/bnxt driver should (later) be converted to not use void pointers... cc. Andy. --Jesper