From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F2BEEB580 for ; Sat, 9 Sep 2023 05:35:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D52A46B011B; Sat, 9 Sep 2023 01:35:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D031A6B011C; Sat, 9 Sep 2023 01:35:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF1DE6B011D; Sat, 9 Sep 2023 01:35:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AFD196B011B for ; Sat, 9 Sep 2023 01:35:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89EB1A03FD for ; Sat, 9 Sep 2023 05:35:36 +0000 (UTC) X-FDA: 81215946672.06.87AB4D1 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.221.58]) by imf19.hostedemail.com (Postfix) with ESMTP id 13EDF1A0017 for ; Sat, 9 Sep 2023 05:35:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of wangjiexun@tinylab.org designates 43.154.221.58 as permitted sender) smtp.mailfrom=wangjiexun@tinylab.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694237734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNUQU/j9YfuYsYhnHpwuQTiS15wERBS1WPOd2BQrlK8=; b=JjmXrKxDCYMgFoQeG4Cm0lD2k097z3PpwRUJTpAMBRMehtXGHyscuZpVk0nWSgWpCiupM0 vahvNFFOnLXIeYMZXc2hsUdzh7OpsM+44lCT2munXkJ+mEs277X00wQxTYkcsEdpAuStmT U/KY0AkEahOfCgkmIqHhEPxXEaYtX34= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of wangjiexun@tinylab.org designates 43.154.221.58 as permitted sender) smtp.mailfrom=wangjiexun@tinylab.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694237734; a=rsa-sha256; cv=none; b=jHiY3tn9m/zhzV2mAU55XtpMrVzCSI/+gXiKWJ600OtAIFQlzXahh93Pelj5lJ2peaEvvD pzQ/eBhR/lv9aTBZj2G7hTbV4GyUJnBzcdRouqkHMFdu4vTt4a4vxKb8V/AArSt6SdSEIO aDfur69gqzDv82xShkfL0EQtrqUGpAY= X-QQ-mid: bizesmtp70t1694237669txe6uyul Received: from wangjiexun-virtual-machine.loca ( [120.225.34.249]) by bizesmtp.qq.com (ESMTP) with id ; Sat, 09 Sep 2023 13:34:21 +0800 (CST) X-QQ-SSF: 01200000000000101000000A0000000 X-QQ-FEAT: znfcQSa1hKZrI9jdG7jfNoZKIGbSER5jLxOcs5Ol1lhcYITTz7DwmwsVa1Jna BeOWm4eM1+bPQOUX2LqaqIClrDbrmvoXRtCKgy11lHSwNrSpsLTUZPS2mScc4o/LHxj7OxN W/op9BHWM2AnGxutzJlMMqi8F2G99LKDTdzGI9XxSu4+t3wlqLbEOEcC88TlkEL5XsjXTUq CTHK/Hkgv5m8urKUlxiu7TQnbgTQqxussDdgcyBEZjRxFjzXcNtuNvFjPWseeKGheqtZ3sN HOFO51SGY4L/rPjbZnxDEDqOze5KB41BMs2fhUbLShHsYrRfleA3rFkIacUvzHRMDPz97Mj eKTngEiTGgjn8QoW2pRgEs/85sIn7wyKIowOg5I5GruwgAb0EduqrpDBFyyig== X-QQ-GoodBg: 0 X-BIZMAIL-ID: 2953894577725368514 From: Jiexun Wang To: akpm@linux-foundation.org, brauner@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, falcon@tinylab.org, Jiexun Wang Subject: [PATCH 1/1] mm/madvise: add cond_resched() in madvise_cold_or_pageout_pte_range() Date: Sat, 9 Sep 2023 13:33:08 +0800 Message-Id: <95d610623363009a71024c7a473d6895f39f3caf.1694219361.git.wangjiexun@tinylab.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrgz:qybglogicsvrgz5a-0 X-Rspamd-Queue-Id: 13EDF1A0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xoemj93rg5x4a6zrhu3jukkpy6dp49a1 X-HE-Tag: 1694237733-135274 X-HE-Meta: U2FsdGVkX1/k+sFODVCdxolFawdRSSYMCWQ4h1uppfc8I4FtScahubyjf/o2BDtt1BQGihAzyam+rzUKBfPu7LrdwN0kAnurZR33mYknhhtl9uOzkY0CTdVQDM0IF6FzR6i+2PFfXAdKsyUNauP+jWTIcAu0Yeh7muMCBHI67PdwjYOxR0Bnu1x7mrSsjpY8LK2OqVAVqqIsIEolmtuOWWNo9VJf2Ka3Uinsnut8Jdvi3l5sfS8SJOewattz6swXtFfXo7fEosweV8VuEKiJ20XMRbEt6Zmw5cM+ZxHGWZQ2Ttl9BvTbF1IZqSerNKyyr6g2xby6jjv632f32zPXwL5PrktO9zw2jRZG9XG+LydKoJiDnlhSDz2SYRweSODJyHxFeBuiZJMhpr2bfbr/qkVNs/q9APi7KvD7EyRd19JOExYVnZkxvlp8Y8jKYt2jb1fny47+cxtDOXJWibBEGULLP1Oqc7D0LjJIf3lIWaXcNJ9mFwAWOOjttVJEYAziUHQIomxWq+Jx7HBCJUxokw6kBwwByCd10lNHGo7loystHH41Rljn+LIcXal345c2AQU1t7spoFl/iZQo1cZ6tOzLrrgo/jz0+wnVLLbXpSLnVC86NspDHlrTIJHsdsnzAz2kpNVqfdizPxKqDOl5A3vF12MCwcQItzSTo7ZXHYk9LV7swPkA8xOPQphn9hl03P/H4pZr77THMZjx48Z+QYOpG9LYUd/nCdztVEQWw7ir9ab+Uv42n1EG8S/mpw6s3s5gFzwCzSqeaOyJWoRUkyX5SPg47sTqLnvkHxjIHybGTXK9Yy9sehiCvQGbwAyr6ZKTDvOSHWkvyuT+k35xJqrEUqUGy7bo/qWyXI+h4apg7Rc1NoYvAm2TxJlA6AuTqEmyEEzneltLLUmUkhAaeNvZfrOjVqExfU6vY9SoGDw0pbv7BP35Usjp2XXUCS1Y2y0yzJsAqn1qUI4OG3P l2Pa4ghI gBQY7T5PdDeUu3Az6LuO6vqzs5ecN4D3srfh2LQo4Tu2WOJyQ8EmxlZyj4etZuYxsMAuuhNTvfctx+NbBGcEFSG38MosuaWfcoFSr+hNae/7NdGR82ATa1FA4ROBmiTUWo8/vJfs3E4GrbkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently the madvise_cold_or_pageout_pte_range() function exhibits significant latency under memory pressure, which can be effectively reduced by adding cond_resched() within the loop. When the batch_count reaches SWAP_CLUSTER_MAX, we reschedule the task to ensure fairness and avoid long lock holding times. Signed-off-by: Jiexun Wang --- mm/madvise.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/madvise.c b/mm/madvise.c index 4dded5d27e7e..df760096ea85 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -31,6 +31,7 @@ #include #include #include +#include #include @@ -353,6 +354,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, struct folio *folio = NULL; LIST_HEAD(folio_list); bool pageout_anon_only_filter; + unsigned int batch_count = 0; if (fatal_signal_pending(current)) return -EINTR; @@ -441,6 +443,13 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, arch_enter_lazy_mmu_mode(); for (; addr < end; pte++, addr += PAGE_SIZE) { ptent = ptep_get(pte); + + if (++batch_count == SWAP_CLUSTER_MAX) { + pte_unmap_unlock(start_pte, ptl); + cond_resched(); + start_pte = pte_offset_map_lock(mm, pmd, addr, &ptl); + batch_count = 0; + } if (pte_none(ptent)) continue; -- 2.34.1