From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA83C3DA61 for ; Tue, 30 Jul 2024 10:20:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC14A6B0085; Tue, 30 Jul 2024 06:20:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D71786B0089; Tue, 30 Jul 2024 06:20:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C11E56B008C; Tue, 30 Jul 2024 06:20:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D4B46B0085 for ; Tue, 30 Jul 2024 06:20:08 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 481571A020D for ; Tue, 30 Jul 2024 10:20:08 +0000 (UTC) X-FDA: 82396023696.12.DF7496A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id E7877C0024 for ; Tue, 30 Jul 2024 10:20:05 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MniTaIXR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722334765; a=rsa-sha256; cv=none; b=oBCjGIC5cUNdi198BHTwBCukrUFwqpHvwQ5rZz8BxamOfUPwEc2GL1SfcYWg9M0IHG5BIQ eTeHpfIksaEuFyGFxN1Iec7dtP/tS+MeNGtu1pbhlTXDxxq/7X93bqO3JCWIangXOPY+jd FUaBMFkTCPCt7l0vBCchabuJ/5ChurI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MniTaIXR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722334765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHlKbihnop+xxvzMW4NJ2p7lvltsBKozXLZturVqLE8=; b=yr93WL5Nf4a5QcM6hu6S8cP5lW49YDjOHpwbEHGaQuOZbtiwayhmsTw1e4RJ/AtCZm27ym 6c4VSGkI4tjYozr0Qi8AlqwL9VnePvEnmoqa9FpsDnku1xG4kvN4GcGPCoVYQDu+rcDq0h FQssdmVWTMl3YkCviwklGde2bTImNMQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722334805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KHlKbihnop+xxvzMW4NJ2p7lvltsBKozXLZturVqLE8=; b=MniTaIXR0mQY6kcEHzTlLM7RtAeRk3UGmJiB5ycuTmGKgvNKfXj5mNTGfprOr1o8S5jUCT XVUaSSeqdbSCZkujhMfUPvLP6KfTgbwze0Ige99/KMY/RpXOaEdgC28lYRImuVfM5In3pK r//3A++YQD7LYm9Ejlm/ru4pJbGYRYU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-pRJKkgv4NgqerPzTnEmiLg-1; Tue, 30 Jul 2024 06:20:03 -0400 X-MC-Unique: pRJKkgv4NgqerPzTnEmiLg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428207daff2so10898235e9.0 for ; Tue, 30 Jul 2024 03:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722334802; x=1722939602; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KHlKbihnop+xxvzMW4NJ2p7lvltsBKozXLZturVqLE8=; b=OVH+S9zlBcs6ZRziX8q/R1dtgEJuCajmEuUqZqKdFdT23+w6mdF+PpLgL1Qz0Rg0Rk +1fk7811DU8eYIBkK9XwwTOIxHC2lm6EhoRzL8EWf4Eb6Yd4L2uyNjtFkFla4Nz9jhsw onmJLLEvmxUpgpSRU7gHTrQuWGoKjDrHcsECRILaYX60sPavAqDBVfodxjTmMXvUtOLz pvGq/tZuvi1grwZxb4yO+zgGLDiC+oEWENwyrWj7Ra+eec4P2JmYCJMlRCnbgmmJd5fl FtDaXRI26YeylN+dGyjLt8gLclv6RyTo/9YyCpt+jhDwUm4nYB6d/s0VZBEqIxaiEYBt FtvA== X-Forwarded-Encrypted: i=1; AJvYcCUsYuzu4MPkfrH2nhI6VxcIc/vTDRoF1U9B3kx/KwnSwdxUEeb0vA9mRJKNCukxWGhNdDnzyEMErRd3KxiDXfITDa0= X-Gm-Message-State: AOJu0YyMRkaqxb/0G0PSII2W5FRn4jMoLJVohWSt/cTdY4J4AxXTrGF+ gw9wASFDGQKaMltbGUt74eM5xSnS/fe8ha8gLRUFV/ot8vew0ou9dGp/bp8YVHTfdH8Wrx3EMoJ KGeaoOepfBF98WvlQYXM5FTwpYAq6S7TMBfa5RKlpmW7+7FIs X-Received: by 2002:a5d:42d0:0:b0:35f:1dce:8671 with SMTP id ffacd0b85a97d-36b5cefce2amr6483912f8f.25.1722334802666; Tue, 30 Jul 2024 03:20:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnKK3pxJLsLb5USRd7ZaLl0zy+J/qjfribzKrSjpwJ2BE8psfIr3REmPtZd4aWzDrGFMyWIA== X-Received: by 2002:a5d:42d0:0:b0:35f:1dce:8671 with SMTP id ffacd0b85a97d-36b5cefce2amr6483888f8f.25.1722334802194; Tue, 30 Jul 2024 03:20:02 -0700 (PDT) Received: from [192.168.3.141] (p4ff233ea.dip0.t-ipconnect.de. [79.242.51.234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4280574b0e8sm214125745e9.26.2024.07.30.03.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 03:20:01 -0700 (PDT) Message-ID: <95d372e0-e272-4669-a3cc-7da32e866504@redhat.com> Date: Tue, 30 Jul 2024 12:20:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: memory-failure: add unmap_posioned_folio() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240725011647.1306045-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E7877C0024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k88fc1y8uk61sd167gkto6g7supfrm8y X-HE-Tag: 1722334805-25386 X-HE-Meta: U2FsdGVkX1/q54Vx4daiRd+7dswD/DdcN56ZUx8VK2xTQmiv85TsLV+dD9GiCjJcLFy9QSK7fnFyyxERhiIspzrZIUOP7IoYqhJCrVNq0a8MePXoVnQQ3TMEGGQX/EHE1Lxk9UMDks5CQORMZ25nfZDGSfy9np1NcAX4doBgwHrHVYKCCHpoWzV+8dvmYLWSaOeZg/4Xo8C26KEG2+V+SUFf8RaMovq83z7VD19DRGFN6KZNOtCLquJUhlWeB2xuX9dGK5+u36TEiWjhosr1hAcXkW/XKVI05fjvIl6FjJ0O27LPmLLckx9KKwXESXsxLun4aByOblecX6pOjs9jQ4gp8r6O1q3zZ4vOKdwuynUEJWEovf6YT8Td+UNUDU95Xb6TVsbk3b5mMOdapeAiAniDIiHP2mxKwFAbSONP8SDul7ku1tRr9HBBCyrxFpWmnFa5pWCIH1hts7VAOfIBnQNYgSlZE4vhsFf/0eArnKvnKANZixG8I3b1MJddW5kyWRdO0cCfEjl9/3+Ldx5soQwFmBJs7AO9hpygnLQaDKfcmvCCtLqIAml4L29Oa8oPHzoVFfN2GXhStV4kK0BzapnaPGOzci2WUuw+xG19OrdpApmJCBq3FttEqiJEE1miBX6qwAA3wNuwvRGM+mlIA+9jeA/+MbCpmJttUKG52Jfqz4Duod93CrR1gS2NmyqSIIm9I3PtkSFQ75E6y8AtXpRfbJLtBduibnA5I4hWbcVnmf8ARNdiA8nF3nO26lJhQHuPpqzWfKrBbQPp1p4jsM3ZdSsX68bA8lDJR2MQksOvqMPeiEe689HV0Dm18S/BiqsA8q9Fata3NUVFq6AMQfESAK4n6ctjvYT6pL70y3eZdPuadTHm4PG1aUPIiWEgosTmNhfJezzZa/bFCh+PO5rxMK4SK4PfwJQG7Y5+vc2nsSv1D/KG8lJ7r6/QyQeeaBslhAXitQQy2maG7Oz oAsPe26F HRrDznpM+mugo+okw6RaCzO+fUeUMl9vTmYnAVjHsmMZye8L2Kbxs0U6yufJx4GUks88URjBNfM5JKGoLjpeecneISyb7H6mDKIxsNy7f72ULTXkdhWF2wqsmPCHBIB7tWCIuZ23+MTBpnZg+LgpYNEWVjhGb3vFwdUVspOLiWF45hVWQOL+k8cewEcz+F9U/oozxIGZjyblRW40KKHentehlQrkJ4bCFyI8xc1nz27U0U0w17tf1kZLHGD6+XIouhudMsU/9wQRDQXDY+f2jfWB/p+mEmIDAG/ZU2ckEXReebHARULIEOSuvleMmn58b6F95RV5sWZDGunnQpcn5vC/A478IfP1lbZdbrtt2DEZd1N8cJLVIPpfJ2Q22WwYC5SM1HNYD7BnFUGgnV2BtXG4GhNbTvY8qMPcYikPw3408RkTfJyJ1s3haEAAPpP+5vNulgS2WggKQyxIhKH4iWb3JGSJ0O1doQ/xFr+xqlzcwvwMDyZlNJzSnCPhdoOP5f+1QMu1Uc6/ZZMMfg1WGnzscmkin0Pnlv0kEFd+dh7Ity6Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.07.24 03:16, Kefeng Wang wrote: > Add unmap_posioned_folio() helper which will be reused by > do_migrate_range() from memory hotplug soon. > > Signed-off-by: Kefeng Wang > --- > mm/internal.h | 9 +++++++++ > mm/memory-failure.c | 43 ++++++++++++++++++++++++++----------------- > 2 files changed, 35 insertions(+), 17 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 7a3bcc6d95e7..c5bd24c4fa3a 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1069,6 +1069,8 @@ static inline int find_next_best_node(int node, nodemask_t *used_node_mask) > /* > * mm/memory-failure.c > */ > +#ifdef CONFIG_MEMORY_FAILURE > +int unmap_posioned_folio(struct folio *folio, enum ttu_flags ttu); > void shake_folio(struct folio *folio); > extern int hwpoison_filter(struct page *p); > > @@ -1089,6 +1091,13 @@ void add_to_kill_ksm(struct task_struct *tsk, struct page *p, > unsigned long ksm_addr); > unsigned long page_mapped_in_vma(struct page *page, struct vm_area_struct *vma); > > +#else > +static inline int unmap_posioned_folio(struct folio *folio, enum ttu_flags ttu) > +{ > + return 0; > +} > +#endif > + Was wondering if we could come up with a better name (something that starts with folio_*), but wasn't able to come up with something I liked more. Acked-by: David Hildenbrand -- Cheers, David / dhildenb