From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C969E7716A for ; Sun, 15 Dec 2024 19:37:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76DEE6B007B; Sun, 15 Dec 2024 14:37:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F6316B0083; Sun, 15 Dec 2024 14:37:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56F996B0085; Sun, 15 Dec 2024 14:37:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 361BE6B007B for ; Sun, 15 Dec 2024 14:37:05 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DC7051CB4C8 for ; Sun, 15 Dec 2024 19:37:04 +0000 (UTC) X-FDA: 82898201022.16.840ED72 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf02.hostedemail.com (Postfix) with ESMTP id 585CA80012 for ; Sun, 15 Dec 2024 19:36:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf02.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734291400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1gl9FODyQuKKpUP0vDxaRaQJZyTsC5GZRS/Fb1n4TdU=; b=hkxfgxPhNrHXMq3shPRu+JndVPMwDjhEcOwaaTJJBmM4EMYjiftpJquDFW/+4kv1+92075 TKrOkfGmqZu/XLiV8DVQainpuFTW7RQ8QydeuZtPHAiUcS+BqeGJgxMwYvotyKVqDyApTm LE6AG8BquL0XQUtWqRnzDivRvBCR/sU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf02.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734291400; a=rsa-sha256; cv=none; b=ih/JV69l/n3XASHXUYTeQpqILtnyGgcHr46XdOLSqDYST9AaGIUwy2b/3mfFVLQHGmjUYS l2X722gHrZ/ZFrJr87r2TdVBHORzNl1+HzdG3YRRHbZ+31GuZAkbaW5cxaN/2KSu3VhrDD mCknhkUqsdm++FnXWVCEPYFKXMTkdXo= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-78-UIVQJ175NaeBrXPJaEsg5A-1; Sun, 15 Dec 2024 19:36:58 +0000 X-MC-Unique: UIVQJ175NaeBrXPJaEsg5A-1 X-Mimecast-MFC-AGG-ID: UIVQJ175NaeBrXPJaEsg5A Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Sun, 15 Dec 2024 19:35:57 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Sun, 15 Dec 2024 19:35:57 +0000 From: David Laight To: "'cel@kernel.org'" , Hugh Dickins , Christian Brauner , Al Viro CC: "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "yukuai3@huawei.com" , "yangerkun@huaweicloud.com" , Chuck Lever , "stable@vger.kernel.org" , Jeff Layton , Yang Erkun Subject: RE: [PATCH v5 1/5] libfs: Return ENOSPC when the directory offset range is exhausted Thread-Topic: [PATCH v5 1/5] libfs: Return ENOSPC when the directory offset range is exhausted Thread-Index: AQHbTyMyhyLVsk/YOU2ozqtU7VdGFrLnsn/g Date: Sun, 15 Dec 2024 19:35:57 +0000 Message-ID: <95d0b9296e3f48ffb79a1de0b95f4726@AcuMS.aculab.com> References: <20241215185816.1826975-1-cel@kernel.org> <20241215185816.1826975-2-cel@kernel.org> In-Reply-To: <20241215185816.1826975-2-cel@kernel.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PyLXdEkj2_HKg7HDVeoI38C3QTULrGp0i9sH2wftl10_1734291418 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 585CA80012 X-Rspamd-Server: rspam12 X-Stat-Signature: u6tn1gtdym734iy3131ng7xhmqmb1kw5 X-Rspam-User: X-HE-Tag: 1734291367-357316 X-HE-Meta: U2FsdGVkX19yu2lkTnO29YE66ZYTYBgQ6Q6jWvlsh/RG2VAqvw9884Doq/1F5EArL8ueurnOMFOaksPebkht+iqbRiU4m38rriatQgdXpPzAN1eMUl4V9iiCZsSPs/+p6DLxfnFNONV5ktx6ouOlpAqMbshbTWYFQ8LBWH3BkyZtgeqcDuXRloKiwSqQWjlOgCn6QlZibFq2/T8d+BeFQJg77vNe9UZNlIhHUJdVSD/sF3Mp8V1o43RTbFJWfJ3p8zd6F+dsn9Y1hBgKXFK2b88Ya7tBqi+SC0bOqanwSYY7c0qKoRP3HhnRB3WEB4jWLCOXl/poEr+Tq0wFcBXAPaTvjnUwHXGaNxSkkHx4AOVDT0U1R2zpLH2I8Kl8Mc4LQVscHfKCSuNXNwoZCawduhVNVl6l09rMxcVOBZSOiq6/61Sx7svdNL2Z7DP+uANE0RFqRF1ATN+YHGAlbqafw8w6mj5hu8mfF2/9REIujNbT00kxWkOxDtdxeXM6Xah2vrLaaV5nBuFqrIo/UViuIZvUPY9ZzfgExgV4ZIsBMXnJWlIdHkCJ55RvMyVVVmhBYBhShKzgXdzXkMNpRmhW+QFvlE0uTyZ3AMmy1Dw/r8u+3zW3tBMtUdLx/8JwFBGlyMq2gOYnWl5QfCV9v9uDu9gRnD8hT1X3LFj/laSZ4T+KbyK4jEkdWaoqnCk5cYWTlYRexzf5y+Bs4fSMphVgkJ5st7gF5Z6rvXYLRi+pt026r2I0GNAwdBYL9yhEwf8nsibvD9NOCt7ezDVm0NMhBWLGHlGg9NSP2myYCCE8EmogtmgvWSobgU2Qtsf+OH5TQsu1mcbK6v3nD8OTzZtz9+bZA9SCtqins+F1qFKWA7hmaSofGtc5M8slkD1hHi5qAhVEhxlmaP/rLveUKJ2DCnwe19eiTzI1gbcsPm8B298wO1xORfANJBSj0Nkca8SXPtYKGrF3Q2+g7IHsQ2H HHDRW4b5 k29r78W4YyFuwqJysCBmX+i7/DSlnwu/ef6obOuDPEfgVOOKjBEZGHUsyzvpIIRzlzdSFapdNAF+cVRqnwjZfGUzY07yGrvPDWLXGXVr9x1XIohoI7qIrDgWYFHqbGQbbK4FXzFPo7fsCy1N9Fha0W4lC5pV5sxMtEtLlsCJfIyRpcWVqjrpbIh7S/r3XUuZhNiAAFVKASExw9DNE33imkzmAs9d9ogUxfWvR5trreixYu0z/GcBW6ZqnaRc7dUNE0rp3OtTCRspwAfPt9OSo2QykwdFimCRn6cllvWrw5GIj+eCnR7Pb/aqKc62oJoxMFTDLGhHgdDpA7eZhnDtqLemvi0FC+7v4EJej4cmmN1E1r5FaCunTyDhhbM3TDOXXZOmR/FuQGvSxXNCIIbB8hbVtonB4KsNl9YA1tZNuAjQDaMtUvYRCR0rM3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: cel@kernel.org > Sent: 15 December 2024 18:58 >=20 > From: Chuck Lever >=20 > Testing shows that the EBUSY error return from mtree_alloc_cyclic() > leaks into user space. The ERRORS section of "man creat(2)" says: >=20 > >=09EBUSY=09O_EXCL was specified in flags and pathname refers > >=09=09to a block device that is in use by the system > >=09=09(e.g., it is mounted). >=20 > ENOSPC is closer to what applications expect in this situation. >=20 > Note that the normal range of simple directory offset values is > 2..2^63, so hitting this error is going to be rare to impossible. >=20 > Fixes: 6faddda69f62 ("libfs: Add directory operations for stable offsets"= ) > Cc: # v6.9+ > Reviewed-by: Jeff Layton > Reviewed-by: Yang Erkun > Signed-off-by: Chuck Lever > --- > fs/libfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/fs/libfs.c b/fs/libfs.c > index 748ac5923154..f6d04c69f195 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -292,7 +292,9 @@ int simple_offset_add(struct offset_ctx *octx, struct= dentry *dentry) >=20 > =09ret =3D mtree_alloc_cyclic(&octx->mt, &offset, dentry, DIR_OFFSET_MIN= , > =09=09=09=09 LONG_MAX, &octx->next_offset, GFP_KERNEL); > -=09if (ret < 0) > +=09if (unlikely(ret =3D=3D -EBUSY)) > +=09=09return -ENOSPC; > +=09if (unlikely(ret < 0)) > =09=09return ret; You've just added an extra comparison to a hot path. Doing: =09if (ret < 0) =09=09return ret =3D=3D -EBUSY ? -ENOSPC : ret; would be better. =09David >=20 > =09offset_set(dentry, offset); > -- > 2.47.0 >=20 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)