From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3713CD49792 for ; Mon, 2 Dec 2024 01:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D1366B0082; Sun, 1 Dec 2024 20:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 482506B0083; Sun, 1 Dec 2024 20:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36F1D6B0085; Sun, 1 Dec 2024 20:03:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19C0F6B0082 for ; Sun, 1 Dec 2024 20:03:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B995DC18D9 for ; Mon, 2 Dec 2024 01:03:53 +0000 (UTC) X-FDA: 82848221862.14.B100D67 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 363A21C000A for ; Mon, 2 Dec 2024 01:03:37 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733101421; a=rsa-sha256; cv=none; b=k/Oc5d4FyaO6EYIHYP2Bci1swLppQPaYkV5BCrF2+Azfz1h2NiFxB3vXI/9yxiKoNubaT3 zdWChnjIZOGlx58YrXTKXxEOtRsePr+H/lzG7gsMRfCBHODwi+8ItpZN6EVH4gH+nTJGE6 2ixoKS0aoc0lSx/roLQ1I+DuhKMGAKU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733101421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8q5RhA73oYw3RqBo71D14bbDChxdSsvdU8jPP35EUJg=; b=sae6NeKIZVFbgV747jxKUFkGaVzWx81ImNmtc0Gd72Ra+/08m4dZ3NDlytJ3K0oUaNhcCI PvZV4ZvMft2ZKz7zX9LNhoATcKqOqqSXMjrlxioWZimLpd9yXHaq0ZiP1/2DAk1Akjy6QX VKTWku3GBo2QoKtBafBgoMtNyLw+SP8= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Y1lq025Qmz11PQg; Mon, 2 Dec 2024 09:01:32 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id BC8DC140159; Mon, 2 Dec 2024 09:03:46 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 2 Dec 2024 09:03:46 +0800 Message-ID: <95c61e7d-2572-46b8-89f7-abab8ea1b7c7@huawei.com> Date: Mon, 2 Dec 2024 09:03:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() To: "Huang, Ying" , Andrew Morton CC: David Hildenbrand , Matthew Wilcox , Muchun Song , , Zi Yan References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> <127d4a00-29cc-4b45-aa96-eea4e0adaed2@huawei.com> <9b06805b-4f4f-4b37-861f-681e3ab9d470@huawei.com> <113d3cb9-0391-48ab-9389-f2fd1773ab73@redhat.com> <878qu6wgcm.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sese9sy9.fsf@yhuang6-desk2.ccr.corp.intel.com> <64f1c69d-3706-41c5-a29f-929413e3dfa2@huawei.com> <87v7x88y3q.fsf@yhuang6-desk2.ccr.corp.intel.com> <20241130181546.0d4d95e2ad9c0be707f54a50@linux-foundation.org> <87ser8c6ai.fsf@DESKTOP-5N7EMDA> Content-Language: en-US From: Kefeng Wang In-Reply-To: <87ser8c6ai.fsf@DESKTOP-5N7EMDA> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 363A21C000A X-Stat-Signature: pjodi7fk5r8jpkbswuhadofp5sgn8bmg X-Rspam-User: X-HE-Tag: 1733101417-125807 X-HE-Meta: U2FsdGVkX19sufCOuYzc7PERxZnvQmVFQfLhq2UF2fSs5DD9pq0kf/0rFEaybfw+oXVHgtC7WiJLVKnEC/KoZVC7/eQgV1SWq1NyRuYugsXqKIPjIHjC81IeaGOGld9Qu7ocDsFTCirCid3Xb3ipAPlu9nMArmP/aiqo8BlMeG/5dbjByIKi1J9PraX/cUDxUi7MbGY38pKFBP3FOmq6/5zYuh3NrSYFQOdNPkhcY4e7PfTz0cZZQaEQ64tPWfsFacJ+athU9+qX4LUW/QL34I2Xcxzy1rlVUIwdyJguvecsdHxGRiGOUuCYXDK/0OJpznXv68EGGsDAzCnAepzDSdhTyqKYHKiBJYYnefRxE5s8e3gHvfbZLN6B73D18XTmn6RLi74SlgFYQQYn+2YX56M3gVppkbsbRa9wJrZlQ1QVmBqLc1cZ2NIimMxoTOQmCtCZIBjhvXCdupRW7dLMUe6tb40wUXCszx4ST3uG8LiBGcaJGoyx/laEQ61P/Dfg78OWaVbn226yDll1rQwEiDfagcf69Cvoos2/TlkKFdAmMCpMBxlAS1N7w7F8+OPfUsasGRsvp4tvZRX0S0eI7W++ZQjp/mx8vYegclQzQQyGpIlh8oZia9nCTdadXs/WV6hiWCvkU1udxGQr8zvmbAhhJoy5rLTfvVAueb5Gg7tKSiezEGYYU2ILi3IuNHgZUna6Lg4oSoibzUb/wD3Fn2E9G3BVEMuJVRZPwlDrz0lQVy1vWtu1lQbpzBC02pg0qaVE4zydQkLqoFTpZ8/YynPpmwySquPspir8ZWhk+bjzwXaa1Ng2z/6HoOIi8ovTet7mdhEhTm5vJOxPWJukX6/lI5sfSibmJ9BixM2bk0f0ixzJXQBzWloTy6M2Mm65LjJHOqfl3266aoV3skx1Xi8b+iU3AEsYVAmoLWVN0NgSJkulemOf9yczrchxHXnb6Qmjl8QSSo3Mp37En9x rOEzYiPT eSJQfJRbdFuhNkVERC3BEgg+UW67SF52UdrWECYf5mMIhOwDPd722i3LL5fa1NS39tBLf5la51CGys3dFs3o7uLhKAfXDRUuZVWQhMd4YGXVHMBsQAJ7O716HPP9eYS6n7qyOTVOH6AH3iaih/7/pl2x6x9Y3SotKEizs/3ZmzGG4og+DgueKIqxeIVCZ+c1pUe7Bbs+fKphtrRC8HKfi8gS7r9woKWgxDft8LOfRb2CwgH4h9E0jQChOGctvUeFj8MQiddnQxYKDG8L3O4vf1VoBh9Iq2KVzucUDwSh1JeeICbWNHdPcVjqG5UtVoaOQHyXb+o8AYyOK5oo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew and Ying， On 2024/12/1 13:37, Huang, Ying wrote: > Hi, Andrew, > > Andrew Morton writes: > >> On Thu, 31 Oct 2024 16:39:53 +0800 "Huang, Ying" wrote: >> >>> However, on ARM64, it does introduce some regression for clearing pages >>> from end to start. That needs to be addressed. I guess that the >>> regression can be resolved via using more clearing from start to end >>> (but not all). For example, can you take a look at the patch below? >>> Which uses the similar framework as before, but clear each small trunk >>> (mpage) from start to end. You can adjust MPAGE_NRPAGES to check when >>> the regression can be restored. >>> >>> WARNING: the patch is only build tested. >> >> I'm holding this patch in mm-unstable because it's unclear (to me) that >> this regression has been adequately addressed? > > Yes. This patch isn't ready to be merged yet. More works are needed to > root cause the problem and implement the proper fix. I guess that > Kefeng will continue to work on this. Sorry for the late, I've been buried in other tasks. The two bugfix patches in the next should be merged firstly, which is not related about the performance issue. 84ddd1450383 mm: use aligned address in copy_user_gigantic_page() 9fbd869b19b8 mm: use aligned address in clear_gigantic_page() and according to the suggestion of Ying, I am trying to fix the performance issue on arm64(will in new series), but I need to check no regression on other arm64's machine, will send the new patches once the test is complete. So Andrew, please help to pick up the above two bugfix patches to v6.13-rcX if no objection. > > --- > Best Regards, > Huang, Ying >