From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3EAC021BC for ; Mon, 24 Feb 2025 19:06:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9743828000C; Mon, 24 Feb 2025 14:06:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 924B928000A; Mon, 24 Feb 2025 14:06:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4B728000C; Mon, 24 Feb 2025 14:06:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5E6D228000A for ; Mon, 24 Feb 2025 14:06:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E8F45A410C for ; Mon, 24 Feb 2025 19:06:53 +0000 (UTC) X-FDA: 83155770306.20.29214AA Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) by imf20.hostedemail.com (Postfix) with ESMTP id C63911C000D for ; Mon, 24 Feb 2025 19:06:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=HmNfCxc2; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="J LSYzHZ"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf20.hostedemail.com: domain of arnd@arndb.de designates 202.12.124.154 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740424012; a=rsa-sha256; cv=none; b=yWcrpQKyMF9iiaKrnYnQY1/tpvMZSOzZHxrGvhddNBQr3cjTki2t0Icmym/9cupRVMe06V 5D3QWg/BH6jV8P91kOqHtD+Wq3cis6axh+92zQ8SO2oAtMz7mES4jIejJOGR0OXKmpPQNx 5KEVg+53/e1kLEael/iibu2XxpBVHrg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=HmNfCxc2; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="J LSYzHZ"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf20.hostedemail.com: domain of arnd@arndb.de designates 202.12.124.154 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740424012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xa16rFVbwHjyddy4WX/VwkxxP6PBp3La/1/uqQ+Vg/s=; b=40pYzljcHmU0oxq0gFz7yPCVuX8zaU7hX7RxKQ04W8ntiMAb6jrIYB1dHSjKJM7b50kzHw Qn1oic734kWwlrz/28W83JYjw7gUHEmipgD+HJezdlVOCCoHMOJPyqJM42bG6kXo1gSwXe Q3drLBMF+LGGz6qAj9zIXBD82y6ghuc= Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8CE1F2540189; Mon, 24 Feb 2025 14:06:50 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-11.internal (MEProxy); Mon, 24 Feb 2025 14:06:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1740424010; x=1740510410; bh=Xa16rFVbwHjyddy4WX/VwkxxP6PBp3La/1/uqQ+Vg/s=; b= HmNfCxc2Nxcus6tmJOqyjzX4PI6MQjDTwmbRNx5YeuD/iHQMKzaQuz1Bj5aJJyhp bPsml16+eFKopsFzFun9IJgkdCW1zdqRNW/PnOoPFYiWTGiBOPquBJz++M5UfDZL 0zc9PbEJzmwFadsJBJDzGspGIQ1lBHVkUKC2ncJ4SSQCNXSdO0gX1oudsQ2AgmxM QEyiyPEGK7fnx5ScIc6jtrdDPwHYbiicpSAKf8qFFzgEL451daAsVU5Irnab1Zu/ 9B6reFwmSvxZxDhFS7i2cfGqFkhv56B6NAOTfBPfDFTOPvVWICTWKsOx+lOQ4sPz VzqVGpkUww+l1GoSEBT1qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740424010; x= 1740510410; bh=Xa16rFVbwHjyddy4WX/VwkxxP6PBp3La/1/uqQ+Vg/s=; b=J LSYzHZBxdCiFFXytVsHm4mVk0Yg9nk3jMknBf8hiNZ/jb4pl5MyJDCnPp4eYgHuu nEGdaXQC0EeYeoFPrkXY2Kxxq9v7vnOOxE0U8baovVjnjFWGeFcFJvWOzS1iFCC6 CFWGn+PxLebzY8Vhor/Kl+2idPaD8c1HijuWDr0PkX37v+uc1K5wDn557OpPYQZs 234B5s/y22hiNtrr0g/b0Qq35HRVhQ/yz/543/DhI2F+3vz64bEJrwd44JIB/2vL Jc71qZfkE5DkuUrEDv9A2YsP0YzGN+ixONok4lokLvdV8uWxt52dV4un3Col7Jk0 j5FsMcxB/IBw9n0Q/fUcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejleehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpeefhfehteffuddvgfeigefhjeetvdekteekjeef keekleffjeetvedvgefhhfeihfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegr rhhnuggsrdguvgdpnhgspghrtghpthhtohepudegpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopegthhhrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhr tghpthhtohepvhhivhgvkhdrkhgrshhirhgvugguhiesihhnthgvlhdrtghomhdprhgtph htthhopehmrghksgesjhhunhhiphgvrhdrnhgvthdprhgtphhtthhopegrrhhnugeskhgv rhhnvghlrdhorhhgpdhrtghpthhtohepkhgvvghssehkvghrnhgvlhdrohhrghdprhgtph htthhopehlihhnuhigqdhmmheskhhvrggtkhdrohhrghdprhgtphhtthhopegrkhhpmhes lhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohepjhhhuhgssggrrh gusehnvhhiughirgdrtghomhdprhgtphhtthhopehsthgvvhgvnhdrshhishhtrghrvges ohhrrggtlhgvrdgtohhm X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 9CAC32220072; Mon, 24 Feb 2025 14:06:49 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Mon, 24 Feb 2025 20:06:29 +0100 From: "Arnd Bergmann" To: "Brian Mak" , "Arnd Bergmann" Cc: "Andrew Morton" , "Kees Cook" , "David Hildenbrand" , peterx , "Jason Gunthorpe" , "John Hubbard" , "steven.sistare@oracle.com" , "Vivek Kasireddy" , "Yang Shi" , "Christophe Leroy" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Message-Id: <95b00b45-c9c3-4a2b-ae9f-a0144ac3d05e@app.fastmail.com> In-Reply-To: <6EA7241F-A4B0-400C-B338-C375512727B5@juniper.net> References: <20250224151225.3637934-1-arnd@kernel.org> <6EA7241F-A4B0-400C-B338-C375512727B5@juniper.net> Subject: Re: [PATCH] mm: unhide get_dump_page() function Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C63911C000D X-Rspamd-Server: rspam12 X-Stat-Signature: u3igehbag3b4qyr4u9596wsxifkwbjsf X-HE-Tag: 1740424011-267466 X-HE-Meta: U2FsdGVkX19YC3oK3G0kPxXiw0D631SYHGdx2I8vEvg4vMpVPWO7N47H96o6X3wfmNPNE4/g/YN0eT9yH0zNX1in/IWPAA18gxC/3xc+a+v0xACk115R3n5EwIrShhhe+afkKAQqMSR+l6JWkdkiTHCZ5zlj3A6acPyjDDutMpni8ncojcqF9varxOt+IGZrpdmckM/4qyCevXn+NQo2Xj5Uv1L9Wgg161g0gO+FtvmHcphunGmA0POi0ukRtWDWVvrCffkIR1Dg7i+DRN841sX4+b8XOcMhixjut7lo7CuIEBykU6PXMOiouky8/kzKa5pPChXJCs50E0i8YKBtiUmf61HSNM+xqZjTRKmrvZHIUnmlB/Ig9pSW6I9XLYzclVoGUgWZcSrHuh9offOnzwQ7XXbE6qrmpd9HxgbRb8SZwnVtxacySWYAQIv674312Q4tHNQt/LFlvHsddxtba3Qrdnr+zWyA+wuOhs1FQa0OpYHt5G6v1gAl0wRqVzvyYbQW6rTWBZqbGjeRcHkN4hv8eoIMh7PwnVBSBlx8zcgOoKYWvBZN5IJEPw0bI2Ewz/HwRKwUqeYNbTHXXk62Co63LbE5HhSCFpgzqLoU21QstDixpqN5TPmwPEUm5F23MESUSvY4Xi4dP3ISY/FKBc1rKzfN9y7ItqffzxAIuMrGeFcyQrV37ptz2AP06RpFg2QuYngbajdUIxrLy+bB8RQuviwHrOdM4SP00F3MR1KiXhoYnGvnOaWL54tvLUwdewYX2XbwghtIwGYr+qYJCN4aWUQVZc5lANPpiIn7eJc75x56H1Vqgtj465WWWESSVj2DRBdWRwBh9SFEMxz8j+eDSGCHd0sB6tt9DWtynCXube28Dfj78WXKEiJCAlZPA5HtnLDhnt18WjDq1Gr5l82k7/WzQRv0QkH/uhdLIEo8QTk6dcBs9LS4Cs2o6lz5Wv3f6JnDF6ObhIaDhAk mdM75DV/ Ud0PNg9ClYrNeR/M0PSUpZOHBtxKOOxcFvxxb6dFpuDQVuxEBdibJMOnTIIZKSwwIWOgrVSHEQ3zPnJFnPHcttWQBNroOpTrjLFznis2okxJPN8SC9FQNz0NzXvbz/7tZyFW8BD5ojmqp3oD9utarHplUhARcELO6khFPrM3qDlJhQcTgRs1tmlLabY1Z7KJt9rH7As1OG9Ro9uJg21knw/QmNWC36x0oogEpH7EeyPV8VnRVKMoMEQDrwWmgBNUhcdfc03gZ+MEkOaU9XXwj9Tvr7jFaeWn0617y6b0yXhGdaH8Gzz/9r5bHIffIWTY+NupWkYykCiJYTfC+j7hLY7+EWrjthpXRgfrpYKpLtxI5SJs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025, at 19:42, Brian Mak wrote: > On Feb 24, 2025, at 7:12 AM, Arnd Bergmann wrote: > >> The definition of get_dump_page() is guarded by CONFIG_ELF_CORE, but >> the caller has now moved into a function that is built based on >> CONFIG_COREDUMP, which leads to a possible link failure: >> >> ld.lld-21: error: undefined symbol: get_dump_page >>>>> referenced by coredump.c >>>>> fs/coredump.o:(dump_vma_snapshot) in archive vmlinux.a > > Kernel test robot reported this issue yesterday here: > https://lore.kernel.org/oe-kbuild-all/202502231914.ROOVWMZN-lkp@intel.com/ > https://lore.kernel.org/oe-kbuild-all/202502231818.fP8cuxmf-lkp@intel.com/ > >> Change the #ifdef block around the definition to match the caller. >> In practice there is very little difference, as setting COREDUMP >> but not ELF_CORE is not useful. > > Good catch! I wonder if we should guard the sparse dump size calculation > logic from the get_dump_page() caller behind CONFIG_ELF_CORE instead > though. I guess the question becomes, will we ever have a non-ELF core > dump format that won't skip zero pages? > > Anyway, I'm fine with this fix as-is. The only other code that is guarded by CONFIG_COREDUMP now is the powerpc spufs, but that is only used with ELF_CORE as well. The last non-ELF coredump support was removed in 2022, earlier versions had some form of coredump for flat, a.out and som binaries. We can probably just combine ELF_CORE and COREDUMP into a single Kconfig symbol. Arnd