From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30EA7C52D6F for ; Wed, 21 Aug 2024 16:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA10B6B0130; Wed, 21 Aug 2024 12:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B507A6B0131; Wed, 21 Aug 2024 12:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CA9E6B0133; Wed, 21 Aug 2024 12:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7C3816B0130 for ; Wed, 21 Aug 2024 12:05:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D89BE140EF8 for ; Wed, 21 Aug 2024 16:04:52 +0000 (UTC) X-FDA: 82476726066.14.49601BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 26E7714003E for ; Wed, 21 Aug 2024 16:04:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UrPmZa6V; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724256209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S01eevrAEs0lxpxuE+gw3u09VxcLdZQUZHokHj/vHXU=; b=mhWDl+9DwdIECBRLglHMXdrUO+1kumWgG0ovVYfhYhoIo8Y+1YfZEvtTcPdJtz5eGHjmia gQBlpG+eLhs19e2pF+N9ubn3DgEpI25tw7kPJUF974F9EfjZlHxiyYrWd7D5/pH2IQp2Zo X6/c3WajivkCrLCAa/cmWXrzhwQRKmM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724256209; a=rsa-sha256; cv=none; b=cZK7kJAs9aNIO3TNrD+6R55D+v1ts1LALkMEE2eto6l0/zsC1btnNC/MQrLKXvdn9tryvy ghx9c9pw8eaOothsfUUf0t0IJogPeAaA4rpt3vOyTNkQx4i+kKElAEcJU1ouS71WVvPfqx zqs4jm5qRyLt9YF3aqzALNM6n8YSqcM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UrPmZa6V; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724256287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=S01eevrAEs0lxpxuE+gw3u09VxcLdZQUZHokHj/vHXU=; b=UrPmZa6VjL1/L+ekJ3Vf+dBwbp7ArtheFdZdFRf/eKPrtuz9NcgjUq2AmxkU4joPmlzqli gie9aUiZch9Oqp6C3H14EoTdn9GK6Bq3otnMk2fOcTQSTLMySRxSDmwIKB2+2fgrG3L73J MogDyGx+cOKN6y10v+enGfcTFPECCUA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-4Ikrp7TYNy64WEPWPAL-Kw-1; Wed, 21 Aug 2024 12:04:44 -0400 X-MC-Unique: 4Ikrp7TYNy64WEPWPAL-Kw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3718a4d3a82so3975461f8f.2 for ; Wed, 21 Aug 2024 09:04:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724256283; x=1724861083; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=S01eevrAEs0lxpxuE+gw3u09VxcLdZQUZHokHj/vHXU=; b=GddxEyDytFvXHUR7E3ZIodSl9bVvA1XXKAduUJD7/e4BYkhGnR+3MIqjMts19oEudC YhsgX2KU+4yeB87Ngj7AU0io2LhIlil8ajiDEDXrCzk084rThdr0ZV1xQw7AntduAifj 25maAf9ppun+b4J4u3dfimZiPT6hFfBFPd9FCPRKYd4PwA/JRoB4oRo6oiV8b4LzW+iS z8XkEimCeUkGxQURcPNxSdu/6h+i0x9sIqJf1rSkztQ/T/X/ATSZnjkh56KjFxfxejr8 WVpOTOQMuPIlLtnY+iZRpuyMlOT5HC77ybSF63wGkzFOUjSEB9cBgl49dIG5BxnlGTiD dQgw== X-Forwarded-Encrypted: i=1; AJvYcCV+M9QDD0YAvizn3OQZy0N6cgaQIbf+Iapi84gowmhgOvA5T85C/Hpu51O7kam2tO6GwkS1GnS43g==@kvack.org X-Gm-Message-State: AOJu0Yzh1s3qCdi5fyD1u+/OE2g/1clr8PR+pjvVM8lW0YMVqTwPEsPQ 6VeZV6Kgr/sRdVXymb8tw+KThn6ygnpijGKR7auH2pfA4n2u/Zhz1WsVsofSYXGC3ZF//3oaWoJ /9aMzfrtWk8kmD4O5QZhztelwICMrqkmAiCFdn5An5+dLbPxm X-Received: by 2002:a05:6000:196b:b0:371:87d4:8f1d with SMTP id ffacd0b85a97d-372fd6da3ebmr1851411f8f.28.1724256283427; Wed, 21 Aug 2024 09:04:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBsdu1qj2IcJaBSV38+AQ+dl1u7gpj99iE4YKjYFE/TwtpOHQNKrY4gGw10COiV5E2nRnbfA== X-Received: by 2002:a05:6000:196b:b0:371:87d4:8f1d with SMTP id ffacd0b85a97d-372fd6da3ebmr1851369f8f.28.1724256282485; Wed, 21 Aug 2024 09:04:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4300:16d5:c5b:8388:a734? (p200300cbc705430016d50c5b8388a734.dip0.t-ipconnect.de. [2003:cb:c705:4300:16d5:c5b:8388:a734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898bb588sm16022125f8f.115.2024.08.21.09.04.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 09:04:42 -0700 (PDT) Message-ID: <95a7dbfe-d88f-4d8b-898e-87c18e7d5813@redhat.com> Date: Wed, 21 Aug 2024 18:04:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] selftests/mm: fix charge_reserved_hugetlb.sh test To: Mina Almasry Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Mario Casquero , Andrew Morton , Shuah Khan , Muchun Song References: <20240821123115.2068812-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: mj6y63owgbh9hrthtctsm4cz6srnehqt X-Rspamd-Queue-Id: 26E7714003E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724256288-174985 X-HE-Meta: U2FsdGVkX185T0dZv2+mqug97kC5zgYwys7vg27gunzzalCTJ+6Y7dIwRj/I1m7Jg0LDNr51bkCf0m5z6tk7l4BoRghjvh2GzLCk59hdPavRwlRbm4aFehY1E26/5FZK1mOMk2rz0G3UT98oJoFcZRBi5iHdMAlqiA9QybW5LqMrekf1LsgkF8nr53tQfYD5XPFoX3G/uSuniVJ33qVji5ehCJDV+YYUHvuyoQTkt/8/XFyjm4baxcxYJERnNa2cUZo8MgqeUhxzpUzpLRomQsudAPWuJB4Iq5AWAA55hsH3Rn1mPpNKiCz8YIUQd7ruPPF83TKMOIRU2o76Z+vvW+lBm3scC0afrjsqU224s15ZEAhgRIpF8Mb5H0WSY9d5mdvqfasMvXtWi+OhTuWsB6G0qI06CnivvR3p8su3S6vK18C/0wDgJduiPSe3pEuihK9RfIv6WI7Aao7S1712/zO+zJOGfREiZhuSkD+D+CetiWJXT1HK6wIvNkgh/A/3jr80sxMNVHDouNhQncv1D6d08c2uYNr42cHy7kOn13t4ZGmrPrzfwz8ndEvFWd1XYE7OZrqHrv/UQRAwty1Hwxk2WCkX6q/ujZtDNxFuV41MbLxAf+1l6xU9gPHvAnacw1Fdua+AmC4G9tpz88BlgugH7RthyhLBUfoIvYbWXuycujMChvO5qoOfkdRl8bZ9aAUG8FWnFz3cpg22UrXiUTxZ4KustLyv7qoQ+QkQxFMQWH+UDX19XNoq9b1gEpbCNaY0chChsRvL9S6g/4E/RaDHcCtmGA4J5u9LSDsSFjoQ2nM+GboL+IXSJcSusSuQB4IZIjCn6UlKfd19UCux5ci1qQH+rUR7MJ8S9N4l6Afg5gDcUS/MBYtvjpb5n5Cipto0GBfCPA9HT3SNVhcKw37KL7nwUfj3wmleaoBVq9Dp3RlbhwfR14KO/7MZAlJ/U+KykMrqcJNdUwX5kBd vSa8G8sB hd3ChM4nlGXRQ+kO6qVCz59D9nmcSUto6W2UZlYcV31kQbR4X/xpMqTFSvYyyKjbHFtnCF9Qcb4I3jWY4yA1V2qe3JHXTmwS4dq9pkB0C1RkJgwiQPfbw71MHvzG9hulojBLsaHGAiJYfqW4sXRrc5jQlyLF8QX/re1RDAHqfz5IC+U4Kf4kGOjk8pEeiWIWIQQhfhOa4u3UHbWjBszEPsgb2Z+jpM3xIfoAPviitCBVxsTmrI/bwVW2ma9urRd6XtyLTfjUjPJEy58ttmET0p7+WbVGCD1Fb+ZGZBAz/E5v7mDyF4oZsttyU7ytB8ZBEzHYXcFQUAw+f0m2jmJkHGqIxtNBgNuc9ZVEWMrvTiK5XwMABvxF7KWRdKunfqCdi9NDiDGw+Yc2UgHWNr2I8hQ7bnu9aMRPGkk2VqclXSpIyozZSbEUsueOQPE36coHTYwGOnB8fP2csCcY+wbohpQfEwQCK3ETpbGU0kCPNw6FOsGw1N51eC/yDmbnDXnSnczYk28Nntf8n3PKF1hIt05CpWFoaAbXfKhYnjsBWk0XGDFTb3Pi4Vq6E6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.08.24 17:59, Mina Almasry wrote: > On Wed, Aug 21, 2024 at 8:31 AM David Hildenbrand wrote: >> >> Currently, running the charge_reserved_hugetlb.sh selftest we can >> sometimes observe something like: >> >> $ ./charge_reserved_hugetlb.sh -cgroup-v2 >> ... >> write_result is 0 >> After write: >> hugetlb_usage=0 >> reserved_usage=10485760 >> killing write_to_hugetlbfs >> Received 2. >> Deleting the memory >> Detach failure: Invalid argument >> umount: /mnt/huge: target is busy. >> >> Both cases are issues in the test. >> >> While the unmount error seems to be racy, it will make the test fail: >> $ ./run_vmtests.sh -t hugetlb >> ... >> # [FAIL] >> not ok 10 charge_reserved_hugetlb.sh -cgroup-v2 # exit=32 >> >> The issue is that we are not waiting for the write_to_hugetlbfs process >> to quit. So it might still have a hugetlbfs file open, about which >> umount is not happy. Fix that by making "killall" wait for the process >> to quit. >> >> The other error ("Detach failure: Invalid argument") does not seem to >> result in a test error, but is misleading. Turns out write_to_hugetlbfs.c >> unconditionally tries to cleanup using shmdt(), even when we only >> mmap()'ed a hugetlb file. Even worse, shmaddr is never even set for the >> SHM case. Fix that as well. >> >> With this change it seems to work as expected. >> >> Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests") >> Reported-by: Mario Casquero >> Cc: Andrew Morton >> Cc: Shuah Khan >> Cc: Muchun Song >> Cc: Mina Almasry >> Signed-off-by: David Hildenbrand > > Initially I thought it could be nice to split fixes for the 2 issues > in separate patches in case one of them ends up needing a revert or > something, but probably not worth a respin. Fixes look good to me. I was debating with myself as well if it should be separated, but decided to go the simple route of a single patch :) > > Reviewed-by: Mina Almasry Thanks! -- Cheers, David / dhildenb