From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311DBC282EC for ; Fri, 14 Mar 2025 12:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66442280002; Fri, 14 Mar 2025 08:17:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 613A2280001; Fri, 14 Mar 2025 08:17:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46788280002; Fri, 14 Mar 2025 08:17:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2472F280001 for ; Fri, 14 Mar 2025 08:17:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7058DA9AE4 for ; Fri, 14 Mar 2025 12:17:12 +0000 (UTC) X-FDA: 83220056304.02.81FD3AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id DCFD340017 for ; Fri, 14 Mar 2025 12:17:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NijUSqYU; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741954630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uk+PE6keSszFMK/H4FlxtGAYCBN+w4Mxmc2pqfulugg=; b=5WZY+CRflsq/dtSKyIEnYnJeGUSyBeyrDBhxZxncROIeXttThF2WMCKBqTkpKNqx7LTmmj SMG95+oyqY0KoVBDSMNWb6w6Tfkjt4VwhZQ7cyMLKzI4Wsf/oZ/q78h5AV0SRDtw0hyAiO LaU03KCnZDuIJY8irb7RaCilYS3DDSw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741954630; a=rsa-sha256; cv=none; b=f1s6zKRw1n3iwyxKN8yilbHm+7Hhnv8znWPC4d8StoO6W+q1j2SRIp7t7uRFVjPmTVCn/8 RZ1UiAv73h7vrszWF3WNFhlFa9lBLT0sHCsmNv+kpJEljx5My+dVL3N5ot4GbPcR2fHJZR o487bVoHVI3tod+xeodWAqZAHN5jupc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NijUSqYU; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741954629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uk+PE6keSszFMK/H4FlxtGAYCBN+w4Mxmc2pqfulugg=; b=NijUSqYUqnW/Ba517KFDfeL/tZ2PmTEDATXOjNd06gaItUgv2e4f7KBhFu1ll8yY8p+b5A tBY/T7j/z2cClz1XBaDt1ix33h/j1Sf5ayNj5pDRVG5fCIYpBQ5ZfGHGo7GUtYe2ztgqYv wT7NxwPCuKH76txpFdsDyHlW3rvfJxc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-A_IqVv2XMpm-bNO0AqYrnQ-1; Fri, 14 Mar 2025 08:17:08 -0400 X-MC-Unique: A_IqVv2XMpm-bNO0AqYrnQ-1 X-Mimecast-MFC-AGG-ID: A_IqVv2XMpm-bNO0AqYrnQ_1741954627 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d209dc2d3so2878165e9.3 for ; Fri, 14 Mar 2025 05:17:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741954627; x=1742559427; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Uk+PE6keSszFMK/H4FlxtGAYCBN+w4Mxmc2pqfulugg=; b=Jw0AOKQ92cXo5UL1ssSKP9Htb+IcP6Frq0eegWnh6ammJxKVf0smIZbf8XlUN176DA RHD4KXIlwLUvAvkey2M/xKd2rGGyCmdWlagecb2d/LMkZhLgn4knaGUIwKCn4mNifgNo uJ2f7iLkiVKha67Xa8JcMS0L9zBRnov8a87QPCD0ItndD1w9IwLnZT8dnDQVx52slqfH mP3QnLBw7FRvNjfuMr0t8WcRyFTKaAcqMkjqExaZzFeYAHRhmisZUrQN6qVrpPmLN5qC E4TNGFxqSIdioCLeLa7xQewyPvlWIw7zFSiO4UsCCYsG/I6ROwKMe1gLDmu26BZ6y/Cq CW+g== X-Forwarded-Encrypted: i=1; AJvYcCUuIGhroqOzROTm8QxUMz/toCoCQvj5Vdu5JbPfV5xdtPW7wU94swoeFyFOFk7EFH2cUg3Cr2fLDA==@kvack.org X-Gm-Message-State: AOJu0Ywkmo42eTLISMrsWkeHKTE8JxgoZy1jnFx26knR2ePBTVzuZkTR oX5FKbYbs0ylOc7GS36x8felcZpmHLcVe2FK0zTeBDBEeLI+vCk5wAWEN+5CODVi3O5nEpeR2ky U71ghuOWguw0VCqMAZWKDrm++cRaReQFAzCXWS5kD1HtQDy8e X-Gm-Gg: ASbGncucUmqS9fhzIGngfKwsURPvAH34R5Zg1UwtRIshTZ21tEdmO02clhU3FYlAGzv 5znWnmaq4kfRQ++LC6fbm+374okxQRol/s1KfZICrFjX59hcZdpfINbSYpO6rOmfj00hJ5wcf17 asQtIFus2tR3jO1W0SkMb+GMimyT36minIk38HacvarIGno9oXjWlxIdy17ieHmoqXN304D6VOJ xmd5F8elcsMm8hRjm5kK8qyIOcfJOfGI2wde/Ti7pH57EBeFH0TK8FizT3GftmCvO5agaW9avfP gBs7KxctSrALdAck1OY2GYHe8WtNMu6MXw7B2DQI+y09rbc4IrYbxwwsan2h0NNUc0J98Mxhjr7 fyvljlWWvdpXnEtsCkYwu0/bm6vewSuXkRDAJSlby73E= X-Received: by 2002:a05:600c:19cd:b0:43c:ea40:ae4a with SMTP id 5b1f17b1804b1-43d1ecd932fmr30117615e9.31.1741954626818; Fri, 14 Mar 2025 05:17:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDrbvz2tRgrie1qCZ5FL011ovoI1nQAi6sQgjyv7izS0Ueu8VEX/n5R7v+XPE4e+CWYxc4NA== X-Received: by 2002:a05:600c:19cd:b0:43c:ea40:ae4a with SMTP id 5b1f17b1804b1-43d1ecd932fmr30117275e9.31.1741954626472; Fri, 14 Mar 2025 05:17:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:2000:5e9f:9789:2c3b:8b3d? (p200300cbc74520005e9f97892c3b8b3d.dip0.t-ipconnect.de. [2003:cb:c745:2000:5e9f:9789:2c3b:8b3d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fe065b0sm15827845e9.14.2025.03.14.05.17.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 05:17:06 -0700 (PDT) Message-ID: <95a15856-5c47-4040-9291-5b972786efeb@redhat.com> Date: Fri, 14 Mar 2025 13:17:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems From: David Hildenbrand To: Brendan Jackman Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> <16023193-6cb4-46d1-91c4-43342e7e6d30@redhat.com> <41923b80-55f4-44b6-bc59-60327e5308f4@redhat.com> <15cc0c1d-2b02-41de-bf48-3c57cee97c53@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <15cc0c1d-2b02-41de-bf48-3c57cee97c53@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tMUe0wGTwil8IEuu5g1kbbc5Y_L14Ds_XMBrDYjrZK8_1741954627 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DCFD340017 X-Stat-Signature: p4nrznwuiz6d3uxjpgrqppyykbhg87qb X-HE-Tag: 1741954629-299205 X-HE-Meta: U2FsdGVkX1+uqGJIXspNbR+umXwFH+nAyVzASd15B84kGAzqJZbLcKYG1yc/FcSgqJ+o5KpSsyijVoiCZEPvBQhIQo1EHSZ4cKN7r+xUWI82JpMOXqzddvDivdnlIuHOOJXypgpP2Us4KMYRmNztzNlETB0pc+hQSEAM5sE+kzRYbbsVgxX3HeAwWmgkOLRBGIsjz4VFT1N7ZGFo4erYNtKF/GX1NMVd+MkMkgu1HcEwKrSfZNGqWM4f5N3SQP5m5YigWrIXf9Z1xg+wipzST55d7d2ujLI/Vwd7r2BRIMcK6mc6cvOxigzSFLakwQUc85j4c70b0TEbKBTMpKYMY/ymovXe5bWNPRo7mKX5Nes7MFW+bOjpt4ekIPqL39Rl1xKMXbnl8iT6rrGHbEENShPxEZ0/hzFYZy2yFy7Y+r4NsLiUjBk/gF3T3gCpv5dWtiQ905KjofgWOrEcSwr9VYsD64Bu5VsPHIBvgPH0Z+Z46j1V+9hcvvcIkS/Ijp4lbQz7fyGxv7UfdIE/fmTeqNzGclp5GSqeVfFsg12czZ7ixC/ZcTN9+ot6ZpgthVs10WGeI3v2w+pUWO+eC49KIizvl8IDDgsl1tq9maTtq7hW1cLIPKwJPhUwGb2FNillB/KMP0ah8evp/odirfMtm//s/DBDFSWN15jEkLZOL8Ej+r8ZMMSWev/H2YeUBDRr7n0pe6jR4HD3Oo6wpsnSEkBQ4rXUA+OWdbp4BH2gj46OyMhsskJJtgIgDHomXlXa9r1TbacnzJoGhByuQZFOpEIbNVmIPakLkMK2o2FlNCecAbZt60pg1Z5L/7vwkzIjNdciGiV91nPXdb9R0MMZy5W/UP0b6mJTGP8zxpdZmdSA1Pj57ILTn6cDAhbGqU2lwyDs+d+EIoHNIflEfVDcrsXW4BMc9gZL9sUgY3gmk1FO6Q2YSEgXjq42FixDMuiY/XwGj4bL4QgKA7Pjo9r PAlqywTg lEKEa11n5IzB6MXYLTeYu2uniGO2RsoPdq8+15+Hcb+/2A2nW1ZHjkTNnqz7IWAUQ304LU6AEf3Pw/RutBP4LN+m8A8m++buvJnf4CvgZwowHKAwoACZP7wRGkZaJ5U19QqLo4NztAGH0QpD6dB3K0fH9xIfbHmYfRCHnMc9odGj6AhmHMcz/n4VQAKkPZC6eEK3gJ2alTqOCo/pDx4mSLBoRyC31mjsSrU8FSI+D5MgUqaEzKzgDAFMEV2laX4lq6es8xTwL1k1o2nwyGzCXvbaiQ9AGnPt86/48foOFvBa8CtVyKMv7NkQZcYz/xtfC3yNmRM94usO7sRFs8MrANkTGCm8wvb9SIo/N2lXlKyieiTKeU3J37hk21ahtUAavprY+8wLJKzO5PF4ODDuGOZgiVn1saM17mPMuO0FIjmRCizg527w/uTK3ETYIiIOVndUV X-Bogosity: Ham, tests=bogofilter, spamicity=0.031319, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.03.25 13:10, David Hildenbrand wrote: > On 12.03.25 09:34, Brendan Jackman wrote: >> On Tue, Mar 11, 2025 at 08:53:02PM +0100, David Hildenbrand wrote: >>>> 2. 9pfs seems to pass the f_type through from the host. So you can't >>>> detect it this way anyway. >>>> >>>> [3. I guess overlayfs & friends would also be an issue here although >>>> that doesn't affect my usecase.] >>>> >>>> Anyway, I think we would have to scrape /proc/mounts to do this :( >>>> >>> >>> The question I am asking myself: is this a 9pfs design bug or is it a 9pfs >>> hypervisor bug. Because we shouldn't try too hard to work around hypervisor >>> bugs. >>> >>> Which 9pfs implementation are you using in the hypervisor? >> >> I'm using QEMU via virtme-ng. IIUC virtme-ng knows how to use viortfs >> for the rootfs, but for individually-mounted directories with >> --rwdir/--rodir it uses 9pfs unconditionally. > > Ah okay, that makes sense. > >> >> Even if it's a bug in QEMU, I think it is worth working around this >> one way or another. QEMU by far the most practical way to run these >> tests, and virtme-ng is probably the most popular/practical way to do >> that. > > I'm afraid yes. Although allocating temp files form 9pfs is rather ... > weird. :) One would assume that /tmp is usually backed by tmpfs. But > well, a disto can do what it wants. > >> I think even if we are confident it's just a bunch of broken >> code that isn't even in Linux, it's pragmatic to spend a certain >> amount of energy on having green tests there. >> > > Yeah, we're trying ... > >> (Also, this f_type thing might be totally intentional specified >> filesystem behaviour, I don't know). > > I assume it's broken in various ways to mimic that you are a file system > which you are not. > > Your approach is likely the easiest approach to deal with this 9pfs crap. > > Can you document in the code+description better what we learned, and why > we cannot even trust f_type with crappy 9pfs? Staring a bit at that code, it's mostly 9p specific I think. t14s: ~/git/linux s390x-file-thp2 $ git grep "= NFS_SUPER_MAGIC" fs/nfs/super.c: buf->f_type = NFS_SUPER_MAGIC; fs/nfs/super.c: sb->s_magic = NFS_SUPER_MAGIC; t14s: ~/git/linux s390x-file-thp2 $ git grep "= V9FS_MAGIC" fs/9p/vfs_super.c: sb->s_magic = V9FS_MAGIC; $ git grep "f_type" | grep 9p fs/9p/vfs_super.c: buf->f_type = rs.type; -- Cheers, David / dhildenb