From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6DDC433FE for ; Tue, 18 Oct 2022 13:29:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C410C6B0072; Tue, 18 Oct 2022 09:29:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF1B86B0075; Tue, 18 Oct 2022 09:29:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB8E46B0078; Tue, 18 Oct 2022 09:29:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9C6D36B0072 for ; Tue, 18 Oct 2022 09:29:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C28140B71 for ; Tue, 18 Oct 2022 13:29:05 +0000 (UTC) X-FDA: 80034151050.18.971E72D Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 015EE1C0028 for ; Tue, 18 Oct 2022 13:29:03 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id w18so23450597wro.7 for ; Tue, 18 Oct 2022 06:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wcJzlEsI0Q0Zkw3UiSk1AeQ+ZeMU0Uy0FowbXkpqvqY=; b=eEqeweMgoAha2gA3agmhPrwheBhBw4LuItboa3KIkd3futKzMLro4OSFn/+GsHoO2q 1g0UsVLbq6G7LYgkvrjjF0/aK9i1HtM2ftwQjwVtT+HxYmYOQu0iXWkYvn5R2pCAGqs4 s9cqF+SV17FECoYNEG3BbIsBfCDRYocVPcCDrmyfVwRyAV9hx0spYE9DLW1VgzgBS4tr UbQ3nKR9UHhV4a0DtNBqTW1c7Zei2Dx2gjoyD+xI5pcx7YWlyHGRsdGlvYb4iC3lrx8I 5fNhFiugt5kE/2K8pSWMOmRr7GxD0aGVofbLzCMH3mgH/+99nu8B3Ir/+6nZinH/MMQ3 hyTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wcJzlEsI0Q0Zkw3UiSk1AeQ+ZeMU0Uy0FowbXkpqvqY=; b=cYOW92Y3spJUVPhC8DvJ/Q6+ScDH22v8CWowww8LFfWNcspUkHAaugtyPcGDOLklIp VUkSOCj5Enmk7XUjSKVL7FcwErcxcLgA0CyZtOV5mzBpXmzf/bVAd3kI6ntPTFU2s0WE OCBN13GXL+kylAQkgcxR2s0VXAzdCdRkDWofC00LmrCSPZzBT0DzW05snq9dKqdyQeHn nG9zEcDQc8Q2NNc2XdzcDNeTPOyBWfrlEG08ypwYvwNDFtwDJw7npnUDctLWqNeAOjl8 F31+w0UNd9XEHB86Q/BNUjs2luuyQdA2c/emG/dB3zhSUj0G2DEjNDqrPcWgTmWfxnzB LsSg== X-Gm-Message-State: ACrzQf1LyxYOZ5Jdn38p5R1cbiwDd9bNZ7d2NGOIkYWQp2pW8GgcOXFA kqYzPq6NQh1G9gua2X0bJnB7OA== X-Google-Smtp-Source: AMsMyM51yRiBRyVMbbU7I9haBznkPLb7xvkfhQYeXVron/xlOZ8CJeyh1CIWGi75RgG0LYv0FAdxow== X-Received: by 2002:a05:6000:1190:b0:232:c73d:7524 with SMTP id g16-20020a056000119000b00232c73d7524mr1991986wrx.371.1666099742541; Tue, 18 Oct 2022 06:29:02 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id l19-20020a05600c089300b003c409244bb0sm12880231wmp.6.2022.10.18.06.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 06:29:01 -0700 (PDT) Message-ID: <95a0537f-27b2-adc9-d44e-527281326b0d@linaro.org> Date: Tue, 18 Oct 2022 15:28:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH V11 1/4] MIPS&LoongArch&NIOS2: Adjust prototypes of p?d_init() Content-Language: en-US To: Huacai Chen , Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , Dinh Nguyen Cc: loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , linux-mm@kvack.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Feiyang Chen References: <20221017024027.2389370-1-chenhuacai@loongson.cn> <20221017024027.2389370-2-chenhuacai@loongson.cn> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221017024027.2389370-2-chenhuacai@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666099744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wcJzlEsI0Q0Zkw3UiSk1AeQ+ZeMU0Uy0FowbXkpqvqY=; b=2K6LjvXnR6GK5svvSDR2gm9IjizNKHAYc7ZqQUzgughzxQeNa/GnmljeqMSp8p4pcEYtl/ UEYUCmp34A9jUkx9SZs0qla8j74ZlOpf39G6INX++hce+8iXaJwh06D/thXEthABjqFhLy GOdneujtVKa7fD+NosqLFBHbmZctWbk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=eEqeweMg; spf=pass (imf21.hostedemail.com: domain of philmd@linaro.org designates 209.85.221.50 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666099744; a=rsa-sha256; cv=none; b=rlQp9w99WuWXA4T+qvpJefpW0REwSdq8ItVQUvm/MptyArknNSO7jiJrcSW4LRWUMomr+t BlCAC8x5kO7u3t+UWAf8IxqqvgTG98Zv9ODMl43q+XTuFKSFIJa7mlHkcBjPuSsn7lLO/x szYkriMaQiehGpHZQw4pKdOM8/5zGFc= Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=eEqeweMg; spf=pass (imf21.hostedemail.com: domain of philmd@linaro.org designates 209.85.221.50 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Stat-Signature: qyyg54osarpyqbnwsds5k9zmsp6x3suh X-Rspamd-Queue-Id: 015EE1C0028 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1666099743-452472 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/10/22 04:40, Huacai Chen wrote: > From: Feiyang Chen > > We are preparing to add sparse vmemmap support to LoongArch. MIPS and > LoongArch need to call pgd_init()/pud_init()/pmd_init() when populating > page tables, so adjust their prototypes to make generic helpers can call > them. > > NIOS2 declares pmd_init() but doesn't use, just remove it to avoid build > errors. > > Reviewed-by: Jiaxun Yang > Signed-off-by: Feiyang Chen > Signed-off-by: Huacai Chen > --- > arch/loongarch/include/asm/pgalloc.h | 13 ++----------- > arch/loongarch/include/asm/pgtable.h | 8 ++++---- > arch/loongarch/kernel/numa.c | 4 ++-- > arch/loongarch/mm/pgtable.c | 23 +++++++++++++---------- > arch/mips/include/asm/pgalloc.h | 10 +++++----- > arch/mips/include/asm/pgtable-64.h | 8 ++++---- > arch/mips/kvm/mmu.c | 3 +-- > arch/mips/mm/pgtable-32.c | 10 +++++----- > arch/mips/mm/pgtable-64.c | 18 ++++++++++-------- > arch/mips/mm/pgtable.c | 2 +- > arch/nios2/include/asm/pgalloc.h | 5 ----- > 11 files changed, 47 insertions(+), 57 deletions(-) > diff --git a/arch/mips/mm/pgtable-32.c b/arch/mips/mm/pgtable-32.c > index 61891af25019..88819a21d97e 100644 > --- a/arch/mips/mm/pgtable-32.c > +++ b/arch/mips/mm/pgtable-32.c > @@ -13,9 +13,9 @@ > #include > #include > > -void pgd_init(unsigned long page) > +void pgd_init(void *addr) > { > - unsigned long *p = (unsigned long *) page; > + unsigned long *p = (unsigned long *)addr; > int i; > > for (i = 0; i < USER_PTRS_PER_PGD; i+=8) { > @@ -61,9 +61,9 @@ void __init pagetable_init(void) > #endif > > /* Initialize the entire pgd. */ > - pgd_init((unsigned long)swapper_pg_dir); > - pgd_init((unsigned long)swapper_pg_dir > - + sizeof(pgd_t) * USER_PTRS_PER_PGD); > + pgd_init(swapper_pg_dir); > + pgd_init((void *)((unsigned long)swapper_pg_dir > + + sizeof(pgd_t) * USER_PTRS_PER_PGD)); Pre-existing, but why not use: pgd_init(&swapper_pg_dir[USER_PTRS_PER_PGD]); ? Otherwise: Reviewed-by: Philippe Mathieu-Daudé