From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: mhocko@kernel.org, shuahkh@osg.samsung.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V3] selftests/vm: Add tests validating mremap mirror functionality
Date: Mon, 23 Oct 2017 08:35:54 +0530 [thread overview]
Message-ID: <958ed0c9-6c52-ce4e-e347-eb5d11e84e5f@linux.vnet.ibm.com> (raw)
In-Reply-To: <472ed67c-7c14-29d3-ac22-e9340a05bc06@oracle.com>
On 10/20/2017 04:54 AM, Mike Kravetz wrote:
> On 10/17/2017 10:55 PM, Anshuman Khandual wrote:
>> This adds two tests to validate mirror functionality with mremap()
>> system call on shared and private anon mappings. After the commit
>> dba58d3b8c5 ("mm/mremap: fail map duplication attempts for private
>> mappings"), any attempt to mirror private anon mapping will fail.
>>
>> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
>> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> The tests themselves look fine. However, they are pretty simple and
> could very easily be combined into one 'mremap_mirror.c' file. I
> would prefer that they be combined, but it is not a deal breaker.
>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
>
Hello Andrew/Shuah,
Is this okay or should I resend this patch with both tests folded
into one test case file ?
- Anshuman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-23 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 5:55 Anshuman Khandual
2017-10-19 23:24 ` Mike Kravetz
2017-10-23 3:05 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=958ed0c9-6c52-ce4e-e347-eb5d11e84e5f@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox