From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB11C4345F for ; Mon, 22 Apr 2024 20:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D2AC6B0089; Mon, 22 Apr 2024 16:11:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 082D86B008C; Mon, 22 Apr 2024 16:11:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8C416B0092; Mon, 22 Apr 2024 16:11:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CBA796B0089 for ; Mon, 22 Apr 2024 16:11:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 586EFA1313 for ; Mon, 22 Apr 2024 20:11:06 +0000 (UTC) X-FDA: 82038261732.13.CB5B60B Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by imf05.hostedemail.com (Postfix) with ESMTP id 68B4D100015 for ; Mon, 22 Apr 2024 20:11:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of richard@nod.at designates 195.201.40.130 as permitted sender) smtp.mailfrom=richard@nod.at ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713816664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4JpIgXCB9jUQPkFUGAI31NP5EjtRLupEYrFT1gtqbDU=; b=75/XObd9L/wSLrclb3Ks7n+R3bDWcU5BC6sCnxYXWISOgWG9hahNzIBASuZHnaDCFvniyt FprU4/BFVWh4mGvRNq0KNcXVUhBB0SsS3ApAYJ5OvPe6Lh/b1CBlu+rHTAVyU5R+vQHOUL Vy1b2n/T4m+zJPh//Ioh4Mmx6OuEbkA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of richard@nod.at designates 195.201.40.130 as permitted sender) smtp.mailfrom=richard@nod.at ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713816664; a=rsa-sha256; cv=none; b=p94+ewN+fYft9JG7mQzN8/FqO2LY0SHKs3fV86MsVlVkEQxNS5d9I3SjJW9jFuyCNsQYZi f0Ae7fzk6ZrEtlPt66Z3CLV0BIm1QV9qDwLmReYMh2+QcFCIAxYzitRsbaUGWpNTGWo3Lg PHVdUWikHm/iTMaN+1WZbhC/byvXQaY= Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 8788D647A82A; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fvDzHBxSevvb; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 10A4F647A80D; Mon, 22 Apr 2024 22:11:01 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rBhDvx3ZBnCr; Mon, 22 Apr 2024 22:11:00 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id CEF3A609B3C4; Mon, 22 Apr 2024 22:11:00 +0200 (CEST) Date: Mon, 22 Apr 2024 22:11:00 +0200 (CEST) From: Richard Weinberger To: Suren Baghdasaryan Cc: Andrew Morton , Stephen Rothwell , kent overstreet , SeongJae Park , anton ivanov , Johannes Berg , linux-mm , linux-um , Linux Next Mailing List , linux-kernel Message-ID: <95819052.15033.1713816660761.JavaMail.zimbra@nod.at> In-Reply-To: <20240326073750.726636-1-surenb@google.com> References: <20240326073750.726636-1-surenb@google.com> Subject: Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: arch/um: fix forward declaration for vmalloc Thread-Index: VhMS7jUdUYDlNrao2e2bRQ6VhbmZJA== X-Stat-Signature: 9qjpabqck9sz3dd4myfd56mo4wg7oy6c X-Rspamd-Queue-Id: 68B4D100015 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713816663-991676 X-HE-Meta: U2FsdGVkX1+1hjUqhPp4x+T3M+W29XeJaO6WmoTZ64cm+6rzzUeLLlggh3N0fpQiavhM05a/zs7SL5lRWcXkyGDZMzydpI15EVPpx9QNA7/t2AbnGNsC/SHwpOSgRddqqhRYF40jofzAZy36h8kSuQRh97pGJLUUbxw3YeiF1fgyahPA4yjdPsXmIbxdJfWgZ+s/cRVy57TsGY1yNc0bPgyzEbMt4mlvJncsO+aOM6YU0CGFOwdRi3uaq0l14AamaUt9LZkkzy/ZZS8/+jC0o753SdAqOKLi3RjNKDeYbdJ+0R/xCFOXHBDfTiPgn5eXs5mdu0Hjmgu0TCJV3cwqiS8zVacHyK9ZC1z7K3YqBEiI/YXvFA2gK+PNpbZlVsK4GcTA82D/5Ep7P5ZOMSW1hmQO9AgVWSD4BwvoTLJikrrlO5NS5W26O/kmd49Gp+WucKHDMsWEsA07iwXLEdsnMciZqGEaT7X8VBUshFBBpZiaS67lpU6DK5LLc1SVwR5C9hV058vYc12KsEL4PypCVno7qIHA/O0/mf+MRzxhjvMKTfjPjhVTHYHfGxyApgYmRMZwTBMhD6KHI8OTjCHjLlisRfyHhnZvtXynBdSGd9gWBZ2Ove15pAYAxapPiSZ5nhId8O6ooKGZtW2XtE9mK/NQDyFEL+Num+JHQ3ZSjM0abo6mGEQb2vpR9JuUQ5gPyxqcmLyw0psJUL4CLx4e2PCPInt/Pn6/Wx7ZZwBEhE+Ex+w66K4D99r8F4b6+sL80QPkOCYXzCXzpXFwEe2jmdxLFCHLfPAmO7m2hgDaXQoa2PrAkxNrJn3+KVcEvI/VO+rhafUboQxcSULu2Tkszqg6c6mtprdV3LTjHw+2vSgg5jPo0JO2BZ9vEqL6i7LVkvZQhXStwhVqROqxYeljlH8xFC3Y+cryb14mIqjSGKjfpk77AtEaJaH7g466ObmXhbgsGWXlonkG4Jv27QF 1WBHTo9w 9Wf52rBXdR6VO9s+9PsoftGWkpxYavBYTmXu5Kf4fxoDwCf5DN/9ynqehtfdIKbsuowEpK640Sd5fpX9QaOLebbtyWKIg5zTLyVYKH6Qbcn2VKU1UVwuBoYj89nKzb/mRjKqoH6ly+U+tE3w1xT143t63leuNoFNDMXndIWM6+p3k6Ne1J38D079tEFKmHww3SfBrhIF9+9mEALA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000452, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ----- Urspr=C3=BCngliche Mail ----- > Von: "Suren Baghdasaryan" > Betreff: [PATCH 1/1] arch/um: fix forward declaration for vmalloc > Patch [1] replaced vmalloc() function with a new definition but it did > not adjust the forward declaration used in UML architecture. Change it > to act as before. > Note that this prevents the vmalloc() allocations in __wrap_malloc() > from being accounted. If accounting here is critical, we will have > to remove this forward declaration and include vmalloc.h, however > that would pull in more dependencies and would require introducing more > architecture-specific headers, like asm/bug.h, asm/rwonce.h, etc. > This is likely the reason why this forward declaration was introduced > in the first place. >=20 > [1] https://lore.kernel.org/all/20240321163705.3067592-31-surenb@google.c= om/ >=20 > Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling") This commit id is not in Linus tree. Do I miss something? Thanks, //richard