From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657E9C54E68 for ; Thu, 21 Mar 2024 03:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 046EF6B0085; Wed, 20 Mar 2024 23:45:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F39546B0087; Wed, 20 Mar 2024 23:45:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E02F46B0088; Wed, 20 Mar 2024 23:45:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C577D6B0085 for ; Wed, 20 Mar 2024 23:45:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91239A0433 for ; Thu, 21 Mar 2024 03:45:37 +0000 (UTC) X-FDA: 81919656714.21.135706A Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf27.hostedemail.com (Postfix) with ESMTP id 1F9B540018 for ; Thu, 21 Mar 2024 03:45:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710992735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DkCUbgUlDM4SAH8XvzqE/5dRjAfdSzNmVY0bLr5dSPA=; b=QsL/mwjJfsZJGfIK5l20wp7OsomHtjyhjgegc3uRNX9ZIKUz9wwI0JV795uldJE3EaCc54 /sDLUBMrPg6ImLl0RJAhpSP4LYL2X+YeXBczstJwPS3huYmzOnBtAuf+fcWlqByCXG/3sD TPLH+wpTJSFCbZPCbJ5c5tSxw4DrpO0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710992735; a=rsa-sha256; cv=none; b=HSuJd0Z6yFBzZ0rp5WezetwJ9HY/ZGg2obgEAUQSLp98Lysc5w1g3WnIdPjMwK6kxMD9HQ 3dcotBkEFgnNI5sB/o9uVFPQhtwU4rkFq8PWW0Dybw5R4RWSPGdrjRvbhNYNf7Wh9HXkzP 6RIrW5ct4mUOJU0IFr8mu9vdhFHdsjg= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4V0WZD40glz4f3jM0 for ; Thu, 21 Mar 2024 11:45:24 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 907561A018F for ; Thu, 21 Mar 2024 11:45:30 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgC3w5tZrftlDzDuHQ--.36010S2; Thu, 21 Mar 2024 11:45:30 +0800 (CST) Subject: Re: [PATCH 2/6] writeback: support retrieving per group debug writeback stats of bdi To: Tejun Heo Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-3-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <956133f9-f758-002f-64a3-4c44d4bd04d5@huaweicloud.com> Date: Thu, 21 Mar 2024 11:45:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgC3w5tZrftlDzDuHQ--.36010S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtF48WF4kGF4DXF1fWFyUJrb_yoW3Xrc_u3 y5Ar4kuFsxXF1kW3WxZFn8JrZ8K3ykWF17ZanYqryDtFn5AFZ5ZryfWFZrJ347K3WrZFnI 93Z3Xw47Wr4DujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS 07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_ GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r4j6FyUMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07 UQzVbUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1F9B540018 X-Stat-Signature: qsi7caywqie5w7e1sgxgh8wxw67mpe4p X-HE-Tag: 1710992734-294596 X-HE-Meta: U2FsdGVkX19FEXn4dfzT0q5A+NsR+B2QLqD9+5sh6WsRJQ4sVHWIGo4F2T8qS1BSFzuXKx1hzlbapFQ0LCJy/rhIGCE6sI/pBi0aYxNagCK+3SGhw2F76MfloB6S/kr+hkcCms4chWimc8t0LSCNsR7HaE2fM8COgPkVPz4gfcdeuTitP2hgQVaHHWMIcDe9YAUuKyTjlEh84tBkNrkYySBxepkuQlunYOggZZmZYUMOkYhKev7mYdgBPYjlwocqOsSiY/2xDIkBAg+Js2KXsXIGG8vlmjMkOTsrKGHyuAU+evZWdT8nZXbOGf15bnkEmISRdTbrD9nFDQsrHjCQP9uy73S2Gx7aJc7UwqZ8XlTuMy2s1KoKeQiIxh93DB4CSCt387EgcXF6R5wSXsX3XtQy03LraCPgJx6N12jMnz6tL+IUtyWdG1qhV44luZIehupuHUlthkXHIpcV/06VtjFprvKu8em2AlYoVNPwaJyV1O1mRNDe1CFNSWBK/HKCQ9WycHKOdXO+TNe5gAzEYuxCt71mgc/4htErdB6jVfQidE3scsSQazjTTzSbt2Hqwlr6juG7/5v4Zw2JqIwel+nxtemMHPDv2FG1sAuavo1y+5wpPYRPANhqWZfztqyn7337JQZJuNYqzgZrJkUB4Obqa7uEcC7VK/xmIARx94Xu7lZLR2WpWZvo9IQv9EIO85R4F3LWewsRaGDcf+zS8c3xPAZ2vLGke+zEy3wbKRv+REdqI11O3BUC51oLS4C58uHKW7PEO4wTPbX+GoCSr4pxHEbWQgEnFPD8fcdDpwmPNbpl59ry/agk2TOLwOsn9L357ui88ceSI5OZBJBYoXu078rRsNxA9Ur3x7OLfJI638m7aHqMBoeyx61KrrnuQ2QecQgLPCz1YFsBOhmuMc/IEP4Txa8e4HHL9LuncD9nufW/G4v4e1pSLb1i/9xR21OrhNnvgJewCz2wIsV y+h5uq7f 1g1LIeFXYuN72oSWer3mmUH3lB/FEe0IjsUR0gpO0foFOK9v7gqbKlUEe8gy7d9OWSwhw9KQW9NNlAoXGbyV4l0r8ia7wIACSx5e42gJd5UgiUo1gN2l/8+oilCEkM1l/sMYJIIeIiygeIhmHLwp6DjGjDlXxHn7PrHAcoJCx5SyNyGVfTNm0yHw6YA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 3/20/2024 11:01 PM, Tejun Heo wrote: > On Wed, Mar 20, 2024 at 07:02:18PM +0800, Kemeng Shi wrote: >> diff --git a/include/linux/writeback.h b/include/linux/writeback.h >> index 9845cb62e40b..bb1ce1123b52 100644 >> --- a/include/linux/writeback.h >> +++ b/include/linux/writeback.h >> @@ -355,6 +355,7 @@ int dirtytime_interval_handler(struct ctl_table *table, int write, >> >> void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty); >> unsigned long wb_calc_thresh(struct bdi_writeback *wb, unsigned long thresh); >> +unsigned long wb_calc_cg_thresh(struct bdi_writeback *wb); > > Would cgwb_calc_thresh() be an easier name? > Sure, will rename it in next version. Thansk! > Thanks. >