From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26EDCC48BF6 for ; Mon, 26 Feb 2024 13:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91AA9440166; Mon, 26 Feb 2024 08:45:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CAF9440147; Mon, 26 Feb 2024 08:45:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79271440166; Mon, 26 Feb 2024 08:45:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A527440147 for ; Mon, 26 Feb 2024 08:45:25 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CA7A1C0724 for ; Mon, 26 Feb 2024 13:45:24 +0000 (UTC) X-FDA: 81834076968.26.742C461 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf28.hostedemail.com (Postfix) with ESMTP id 6FEB8C0016 for ; Mon, 26 Feb 2024 13:45:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bhzFUB1N; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708955122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5JRZHibxSDt1ouB+hnkMrR1x0/Y+/HJ8lBiREAu9qpg=; b=2S9Fz7jS874c+iCQChFHqP3NU6N+vfsy24nzwIWeV1mGY+w/wbI2TFFLwhHFZfaPSitoZ9 o0dvGv9YaTpYszXSCRr6XQE4rfYCsx4gw1krnlmRg3/3pG3HZbgHrRJnGRO/QMa126ka0q 61Od5qBnoAkGwdx2Fx5s9kYvl76LLrA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708955122; a=rsa-sha256; cv=none; b=cZXzKr9El+l7ot0PxtqQNni6Ui8YhWwUcpllq6FqFs8TTSCQTfXPQ/re/30wU+A3HW9J0l QknV/zAk6s4okelkrBmJIHtOQI0F2GjLxmf2FCEB/17811c97NYLfXXeYQ0r0jSlwfguyz iQnwT5dha5hxmYHsEm8XzIvLS66fovE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bhzFUB1N; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: <955791a3-5fa2-4473-b69d-a9a56ee6f98d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708955120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JRZHibxSDt1ouB+hnkMrR1x0/Y+/HJ8lBiREAu9qpg=; b=bhzFUB1N7OB0LR+pt65bzTbUYIDJd/n/2qnAT4GJ548qfpeWyNojUW+ccX3jyGK9tFgMpy sWsQ2PAQVNbF5ec3XYYAHI4OeAjZYZ18x31sfrX4rwPUOqicJ4YINSLgbLHKVP88MG3l30 ukaKusi5Cd9CWBeBjyFM5LBTMlcPVzQ= Date: Mon, 26 Feb 2024 21:44:47 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: Damien Le Moal , naohiro.aota@wdc.com, jth@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com References: <20240224135329.830543-1-chengming.zhou@linux.dev> <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 6FEB8C0016 X-Rspam-User: X-Stat-Signature: yym8maw3b57k4hmmmy8yyfk4iaecpa1p X-Rspamd-Server: rspam03 X-HE-Tag: 1708955122-143994 X-HE-Meta: U2FsdGVkX19u2SvtYNnemNkZKL6V6MTUmk6aQuUXmfJXb/g3x8EQhBlZBPuDmXV+0/BMth2leTHEBPR0np2ZqhURVe1XdP8Jdkvf6feLCqr2IqSyUkIfNXW78Ah/7YdVQlfKcSOWLZm6uiXNntr23ZwMyhV9spYxFOQ075Sjeqgoy7Q4uo/MHylzS3iIqEYyDOUwOEKupWsrXR3YPeCh8BuRs+D8W+1pgP9XLEri/P8QdZTvnuue/XXZvXw0Lj1u4OvwjxigIzUm9S0AnpM9FkpDU9uqM/wSaKcYfu0nKTcvIjQpyY3R0WjwitpSofoSIZkHA8EUJ8eS6c45bnZn5dVU1PMZqg5rx3TQoYaGVP/eDWZ89XamRRVSCyAatL61KrZhILSpShXrDyguOeVoWSO09ngYA8LDPj/2rhmJHUfdvAKlbZuINbQCBVsU963K4UDuxgPhFdFiglinznBbZ7jn2zAV4YWFbvpSwuY+vxByvoI7E9b2WXeczPbJILc6lK2lcNmwOLKwXVP7s64zUeMvRY/NuByePV3MzWzff8DSwW0qkh6gqJhY3CXUjQgNCISFTcWc9BRrkhsy8gaEkGzVbdWkvU4MhFhIN/IFR5Bhv41VvLgE1fi7LbdBRHjerTOzEni0tXwcX0AhKNx+HrTOkE61CVRyISZOOELILSUEUKFbaIpL07kQrwWxKJo8JPwwVaIXQKGugtFFz0+qLgFp8z5XRsVvvd8ap/Ae1epAnz6h/qBEgJ/nbu63p6u7e7AlhmXXmrafPS5OhqoFNfqwnbkWOGetSYuknpuzKc34yvFa6MW1WB/3gY6tCGQ7M0jxsSzRa6LJMxjTL5Ka47yk6DUbaSuSi9SYw+OS0BGj5QwzAy0BhMlrFE6bzJ4fZsiN+dV5/o10+SsSlNjfFxrpcDiZeaeI2us8SeBsygcmdPJTQaQI7qzYWYl6AnBRj4JZ6RoNalmLohITccl 7KXw+VER 7s5PZCEsjOtgwejXlgPas1BXIgzlC62/oN90U17g4TB26axZ4xf6o2EsQx4eZn3v/gPiabeA8gafXsD4TUl69owG1zv5GoG4IzmZeLSg8F4hYYuJ6eVIlunqhRsKYww1EE1tYG/ff4jKmrWeL0ouoyFBMnJGlq7pHPWyL0JT6OhykGlo50KgyQgizMGRfzGEMBpcRWkuOtMPHhoOG5S+FgDHprbY7R20frXzISSSyiRRDgz1/cAi+zONCcS1a9/paGBAr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/26 21:33, Damien Le Moal wrote: > On 2024/02/24 5:53, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >> its usage so we can delete it from slab. No functional change. >> >> Signed-off-by: Chengming Zhou >> --- >> fs/zonefs/super.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c >> index 236a6d88306f..c6a124e8d565 100644 >> --- a/fs/zonefs/super.c >> +++ b/fs/zonefs/super.c >> @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void) >> { >> zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache", >> sizeof(struct zonefs_inode_info), 0, >> - (SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT), >> + SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT, >> NULL); >> if (zonefs_inode_cachep == NULL) >> return -ENOMEM; > > Looks good, but please rework the commit message as you suggested on the btrfs > list to have more details about this change. Thanks. > Ok, Christoph Hellwig suggested me to send these patches as a single patch after 6.9-rc1 release, only need slab maintainers ACK. So I stopped bothering you. :) Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks!