From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF9EC282D1 for ; Fri, 7 Mar 2025 01:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFC5280004; Thu, 6 Mar 2025 20:40:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 190EE280001; Thu, 6 Mar 2025 20:40:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 058DB280004; Thu, 6 Mar 2025 20:40:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DCCC5280001 for ; Thu, 6 Mar 2025 20:40:09 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8BCC6C01BD for ; Fri, 7 Mar 2025 01:40:10 +0000 (UTC) X-FDA: 83193049380.10.D25173F Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf23.hostedemail.com (Postfix) with ESMTP id A28E4140003 for ; Fri, 7 Mar 2025 01:40:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RHDfK34K; spf=pass (imf23.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741311609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ix4lqrkyEpnvZGnEEPwSx3FIhCD7BBaHH6lxvs2plWE=; b=L6W9VyUIUrxg+NMMK6rTqr3Lua8YMciA1curqwzlzdUqcpHb7tk6+VZttVz0tNxM8iyAVw RvzbAoiZkWhPw5J9SQMH3R8aEFWwBWwj8FWEJ3AQIGCnCZVgBr6BJNGKdjCb0RYsK0+JIc D3jzUwO1l/C6JeCv7nzU99zentdLrrg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RHDfK34K; spf=pass (imf23.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741311609; a=rsa-sha256; cv=none; b=bOPzDpamt1nmRLE+qF+r+g67R22fza+j/XpuGbTuAwnvznkBBgxBlr0VohuUA/wJ+VgmF7 91B8UMZ8mEuPOlYHVf3ilDrcECKbl+1i2eVj541K1egbl+pjTV1gzg67r7Q4SWlTiX38lm GPXBywAa3gfhLGKkH8IHb5uWaRzFOO4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741311604; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=ix4lqrkyEpnvZGnEEPwSx3FIhCD7BBaHH6lxvs2plWE=; b=RHDfK34KbLn7E7Uw34X6IPumstwOdnmvcCsSk+NUlP5ZfrHgJ2kG3kRU8ZYcFNlWG4qVZqH/EtpTD5B+OPVBF1NUk8Rw/QT0gklkzc+C793uFAoy/hzuapIyjPiatybU55wSUm2V+emTV/JUfRqTSvYxCfVw8nxH3Nrky4UCUjc= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQqOCEh_1741311602 cluster:ay36) by smtp.aliyun-inc.com; Fri, 07 Mar 2025 09:40:03 +0800 Message-ID: <9556c686-d502-4b30-83e1-860154c84cc2@linux.alibaba.com> Date: Fri, 7 Mar 2025 09:40:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] x86/mce: Use is_copy_from_user() to determine copy-from-user context To: "Luck, Tony" , "bp@alien8.de" , "peterz@infradead.org" , "catalin.marinas@arm.com" , "yazen.ghannam@amd.com" , "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "nao.horiguchi@gmail.com" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "jpoimboe@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" References: <20250306021031.5538-1-xueshuai@linux.alibaba.com> <20250306021031.5538-2-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: A28E4140003 X-Rspamd-Server: rspam09 X-Stat-Signature: s5o36rmhyw14hmjrdgw8rw7cyfhh3z5j X-HE-Tag: 1741311607-873303 X-HE-Meta: U2FsdGVkX1+8weV2HeOIDmIE/IedCiHUfq+DX9VZm0vP1x4vP0ikaf+uURfALh2bpBsiohDH9vSXQkPan/+rpRueUotjiBA9ZF6yCNSJLhazKSB9dqzs6EE1RcbLiWN6tOclN3Npm5pKa/sZPXBC8L5WLve0dWrgjZ8rOljBKZ2yh0/c7jQZgNaELt/0eIgBhUNe6oGqFdwFnbKkh41ZzvsdZohF1jYQc0pXSBgO8l7aoQQGRGrxtx+b7cNv/RxKwW4BktK62xXGMuKR3HTgtCjJvYatyoC3D8J2Br1M/Uv0Pczug36hW+476XfWyoMUkntvxcBetNnNdNM/QJjnldXAgahjKSDjdtEePh/SybjGYDu340qIuw4ZbKWGCXYRAmm/0ZezfM6pZAFERQRI23yGnoZdDrWi2Y5whiRZMS+cK2QgkPzf4W2PZbyaH3zTcOjE40WXIrnWh5PiQM0HJF9437lsMPBT//T4ZCrYpdAacKJe+FTFz+roW1gE3Ux/zNy0TuSt3ahel3T3M6HujYNOlN8oCCxUu8YkoMrMLfH1j6YkAf6P424aq7to/9J+ABgM1PMg8miPMkg4bneDHNgumfYImgDDGg4kbKmkyrI4I47e8Xo+sAomoCGge8caxbENwv73aPyY4NMOZVrcXCtnC9iOMrCama+IdN6cqHD+Csu1JOnFxqVm2gsDvbTCIGEdKzgn1O631ZGADjBpdMI/Ui43xY5bWEWTgytgRrDD1Six523d2KPbErhVc3VH/KaxelNaISh08EzMlj48zOsn603SckAntFNl6xDrW8JA+1X9tD9nBQ5/IT7HlL2GbkpCHLgRq8P6D65Oek1uDTuuHjRBCYNCm6fHDSPBR2CXKiwFa4syX/qteh8oi0iKy9C5IYAQYRwlSN/7n0JBnqnc6DRSZV3HojR36cL8/qD8NQuAOjczr6oLNQET5jjQhPm9hMzHtGBQIGHIM4E o3Qp6fq4 hh+y8nvGT7URminQGALbKA1AjiADwKgEdCsFhXlsOBxdYzA8vLQ23TOQ3jDWOeLdRk6tJ9tFINpWr4kNjK7jMKcytUSs/dPzpehCmOC0/4zSo+A9xMIMdj2/BGGVActrlq3PldcuR7EVVRFawYhB9hLu9qeUR215M1DDOOrWrcwBg6j2H6lNnhtHW83bYOvJkUVq/iqA/p6aMF2J7GZ3liKXdv7z57ZlHJkhgGnPQ6x9S7u0Bz7kBZe5aqtKbMrKKRey3wNZ1modgM5L0z6nDLIy23pEq7yraXVvAsUXpgwH68oUHtO6nclBcyGQJ9YBg552YZxS3Zj76EfqN4Ne3Vyg/GLpanxToeNNNMEdEEveH+cRgQ9W2REhUVtYNqoxJQsd+XHa5og7motEzzk0GXwSxDgQPPZzkEwpRmDISkdJr0mn1zBW73/Rrag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/7 02:15, Luck, Tony 写道: >> diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c >> index dac4d64dfb2a..cb021058165f 100644 >> --- a/arch/x86/kernel/cpu/mce/severity.c >> +++ b/arch/x86/kernel/cpu/mce/severity.c >> @@ -300,13 +300,12 @@ static noinstr int error_context(struct mce *m, struct pt_regs *regs) >> copy_user = is_copy_from_user(regs); >> instrumentation_end(); >> >> - switch (fixup_type) { >> - case EX_TYPE_UACCESS: >> - if (!copy_user) >> - return IN_KERNEL; >> - m->kflags |= MCE_IN_KERNEL_COPYIN; >> - fallthrough; >> + if (copy_user) { >> + m->kflags |= MCE_IN_KERNEL_COPYIN | MCE_IN_KERNEL_COPYIN; > > You have " MCE_IN_KERNEL_COPYIN" twice here. Sorry, I forgot to format a new patch and send a old version. The corrected one: --- arch/x86/kernel/cpu/mce/severity.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c index dac4d64dfb2a..2235a7477436 100644 --- a/arch/x86/kernel/cpu/mce/severity.c +++ b/arch/x86/kernel/cpu/mce/severity.c @@ -300,13 +300,12 @@ static noinstr int error_context(struct mce *m, struct pt_regs *regs) copy_user = is_copy_from_user(regs); instrumentation_end(); - switch (fixup_type) { - case EX_TYPE_UACCESS: - if (!copy_user) - return IN_KERNEL; - m->kflags |= MCE_IN_KERNEL_COPYIN; - fallthrough; + if (copy_user) { + m->kflags |= MCE_IN_KERNEL_COPYIN | MCE_IN_KERNEL_RECOV; + return IN_KERNEL_RECOV; + } + switch (fixup_type) { case EX_TYPE_FAULT_MCE_SAFE: case EX_TYPE_DEFAULT_MCE_SAFE: m->kflags |= MCE_IN_KERNEL_RECOV; Will fix it in next version. Thanks. Shuai