From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FE0C001DB for ; Wed, 21 Jun 2023 11:18:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27908D0002; Wed, 21 Jun 2023 07:18:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD80C8D0001; Wed, 21 Jun 2023 07:18:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9FF18D0002; Wed, 21 Jun 2023 07:18:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AB1CE8D0001 for ; Wed, 21 Jun 2023 07:18:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 72F7F1A095A for ; Wed, 21 Jun 2023 11:18:08 +0000 (UTC) X-FDA: 80926505856.30.73AD557 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 3940214001A for ; Wed, 21 Jun 2023 11:18:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YWmMSlWl; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687346286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eA/C3UTAELWqz6unXgzX5wgchGsL80SWbmcKSOr32rc=; b=FUWLRFbi8krH25WHJWWIzuKGz60wW6NI7VUYH4Lzfc/PWKdzI4FZquZcNPVSoRA+IMmbMD cHwj4W3aLaIbQJDUsB1jYQmuUQGcvkVP6o70CbGV7RfHP/zCYd4XCwS3ytTg/e/LSmhYVc 6XOGCAYNA0QUIAEKVpcV0tcnEnxaQ3Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687346286; a=rsa-sha256; cv=none; b=sRRSZ9+AsHO8JAONPt3z1TTXeOYy7Un285U0QkeBSSleAbKoal32OH9lm9D6ER1ZxF68Pe ThxYQymtN8Ey9y5QrRz2iJj+YXsTlXwqj564UVXw10D+zNX4akhB8wnJLQXDatP5iquqF7 k9a0HUN17y57+f1uYjCdRvl2101r2J8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YWmMSlWl; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687346285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eA/C3UTAELWqz6unXgzX5wgchGsL80SWbmcKSOr32rc=; b=YWmMSlWlB++0BQAFRnxY7K0Ex0zufH5qKYJVuBWFZQ5FmrsBbA3NJxDdNDedThXRZXTSq3 GsKwzbBWmF8QD89Xr98DzhBzmkljf2rzOuvu6FeDsddCAo0hiyQOc5WxVF7NC8uXWfAPQ7 nZeKHR+Bpb1yMd1HSK7hNiQLzHdbTX0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-SuzMokpMNfmeBlZ7BvMByw-1; Wed, 21 Jun 2023 07:18:04 -0400 X-MC-Unique: SuzMokpMNfmeBlZ7BvMByw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4edbdd8268bso4344432e87.2 for ; Wed, 21 Jun 2023 04:18:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687346282; x=1689938282; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eA/C3UTAELWqz6unXgzX5wgchGsL80SWbmcKSOr32rc=; b=gvQcqP2dSK5KzdxCh1mfaigVkBBMxwog5o3H4yK18j6yfyyyU3Q0Glm3qQ8wCQOf4l TA0MGKfrN35VVoKNoKdVlItTGUzAgNEOYwJuDJtYQI6Lkt/BzdkHk/SJi486myNyKyM2 MrxuAkNQLLjUVX5lx5RMlQ3lENoz6cKDeNUSXcQO+xpNIFalqhExqWqr+Fy0Eba4MvZS gzPLujjFME81IGknWex9cOo/V++6FCcd6NV+OJJItB2fhZlFrUjEx6HMpYSy0U9TR5wZ fdjHSqThJqGnyYcUkPyWVhZoZBVU9dXksp/9Ca8RpiRjIX/Y3w+poLDtYKBrT3H2/wUz DlgQ== X-Gm-Message-State: AC+VfDzseDyXVTUSb9URFHh4BFzQqIffyR4TTQsFcl6A6gXlmkd5r6xr 3CDVqwR/BPG003Va/sA48SIcqlPt7mclq1N64ZtMyXgIH4Vh25ON6uSNcmcwyUOl5p8denIMXvZ uf+eZvZiNwVw= X-Received: by 2002:a05:6512:291:b0:4f8:6e26:9347 with SMTP id j17-20020a056512029100b004f86e269347mr6566249lfp.68.1687346282265; Wed, 21 Jun 2023 04:18:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cbfnyJkssIXiJndC8FHgvzkyIm+QV6Pio81ybA5Qjaap7dDs9ybW2SP9EmjkYP/SLFc0Yfw== X-Received: by 2002:a05:6512:291:b0:4f8:6e26:9347 with SMTP id j17-20020a056512029100b004f86e269347mr6566231lfp.68.1687346281827; Wed, 21 Jun 2023 04:18:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:9c00:7978:3030:9d9a:1aef? (p200300cbc70b9c00797830309d9a1aef.dip0.t-ipconnect.de. [2003:cb:c70b:9c00:7978:3030:9d9a:1aef]) by smtp.gmail.com with ESMTPSA id s3-20020a7bc383000000b003f6132f95e6sm15851624wmj.35.2023.06.21.04.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 04:18:01 -0700 (PDT) Message-ID: <95531f88-a1bd-3347-dc60-8e16de811145@redhat.com> Date: Wed, 21 Jun 2023 13:18:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] mm/min_free_kbytes: modify min_free_kbytes calculation rules To: liuq , akpm@linux-foundation.org Cc: ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230621073912.21747-1-liuq131@chinatelecom.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230621073912.21747-1-liuq131@chinatelecom.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: baoddzb3pakapfw46aipmxsseb9gciyt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3940214001A X-Rspam-User: X-HE-Tag: 1687346286-801817 X-HE-Meta: U2FsdGVkX19/gcLalC5LvKzrkaEq3rc+/FfhqXcAO6XBlphARiQD47pz6zpItnbpLe/C0tgyvzLnaTZwp1u/A0Nuqv23TszzFii/Urz3tAciM+XQtSgeimIzaqsK1UA8RcntOeCerqcp5xWx+EEAr8I42JdOAmQbOz1oWCvoP3B1D6kyN9Q/YN0e95qzX2T3fhnDIFLgN1lJm9Xkzgxioi11jmgYvfsCclkNEZt0+F/MCrVdrZN/cRLTFPEsXbAz0Hz/hKzUVlqGQAwFzdF5atYloSowxwjPqxM6wlgJCMFOKtdKkSxCk6dR3Ul38FmWPquHe4wNRwi1xcRSSWN9Vd2s1u9jp6OPj8qd5IKIi+rsJBvAvAJFtz7X/TDPrbgQ/qzU1lD6Of7y3VVfwqVJM5xueHV5TxBOMNuiECJsOXZ5713T+dxF+TKYG4qGEm8FXQesaWtmlNctAhYBIi2bjNjxLSSon1flm53asa7E+Ecka0a9iHkUVhS+CMjjUsTiE47qsyXANlpJv/BuVxMGlHCqkIK3vHPXY8+/NRk6AgjJxtulynz2fsYALBU/P445JTXLfWyp7/GjWrPI2/dTpsYWNs7omQ3YH4qn1pCoPGZEwHJSK57hcfpJoirCmrVgIkayIiMrgzCpeXy44K18kn0m0kTpDcQbmZHcNxObu9pUZeybB7PBcyph6Hi2f/MfIJ//YXJydsbwCOrUzWs4f+Rk2lrXjvyHmnmyTeg3VlcjJSe0z+DXltwLpvdHNXl2DbCkCUsVsGui/U07qoWwlRQCQQkBEdOswnvXHXE8Vc9EtQ0y4JIZ8ySOD6CppphsHT9B+EB/lJx1TSuyyDngciEBzV4GHW82QwCbZAV7SM0sHpBM8Nzxgq2vr6rMKH2LayMz6rsl1EbYrk4iFZNl4osKZT9VndsJTtseLhw0swUL+94MGRy5oph4WNL3401ZsegRofheS4s5Mjq4jjz fDDl3Fhe 1NfL1Itn9YfegD4Xb7tNS7FWVBr/qW02ez+w1ffRFe6x3ktzEk7bhj3rMw3CWiHqGW7qARTg2s52oCyf6bQ3RUVtcg5zF24+VmCMvnM1we8F+XF1cEsaJiypW+c+nywwv11dwhAOI7htoQ+AswEuH81IiF3eqXuOGTRB3izmNNAd1LRLNsFIOwsOBWQPVFE5/mRMlLUvfWo8LmiMb20n6ETYMRLqDAG9wDftBhehS454U0td9GQE0AagYVfkBL88DHmYsUQmi1fvaT3ef/qWo09zFeyV4YPjka3ypnBxLOjfDHUh6rCfSzNQtH40o5EB98757aC0izPiUbIvV6oYav4c9O+ft8G87risayHdf/Bc8QzZxjwSJ0rOv9Rq1Km74pKJCAsezKqVTL0vA7+lRPask41A+P003AFzM3FYCsobG++M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.06.23 09:39, liuq wrote: > The current calculation of min_free_kbytes only uses ZONE_DMA and > ZONE_NORMAL pages,but the ZONE_MOVABLE zone->_watermark[WMARK_MIN] > will also divide part of min_free_kbytes.This will cause the min > watermark of ZONE_NORMAL to be too small in the presence of ZONE_MOVEABLE. > > __GFP_HIGH and PF_MEMALLOC allocations usually don't need moveable > zone pages, so just like ZONE_HIGHMEM, cap pages_min to a small > value in __setup_per_zone_wmarks. > > Signed-off-by: liuq > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 47421bedc12b..608384712a89 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6364,7 +6364,7 @@ static void __setup_per_zone_wmarks(void) > > /* Calculate total number of !ZONE_HIGHMEM pages */ > for_each_zone(zone) { > - if (!is_highmem(zone)) > + if (!is_highmem(zone) || zone_idx(zone) != ZONE_MOVABLE) > lowmem_pages += zone_managed_pages(zone); > } > > @@ -6374,7 +6374,7 @@ static void __setup_per_zone_wmarks(void) > spin_lock_irqsave(&zone->lock, flags); > tmp = (u64)pages_min * zone_managed_pages(zone); > do_div(tmp, lowmem_pages); > - if (is_highmem(zone)) { > + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { > /* > * __GFP_HIGH and PF_MEMALLOC allocations usually don't > * need highmem pages, so cap pages_min to a small Patch subject should probably be something like "mm/page_alloc: fix min_free_kbytes calculation regarding ZONE_MOVABLE" ? -- Cheers, David / dhildenb