From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE9FC77B76 for ; Mon, 17 Apr 2023 14:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831C38E0001; Mon, 17 Apr 2023 10:56:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E15A6B0072; Mon, 17 Apr 2023 10:56:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A9B98E0001; Mon, 17 Apr 2023 10:56:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B2326B0071 for ; Mon, 17 Apr 2023 10:56:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 285DE16058B for ; Mon, 17 Apr 2023 14:56:42 +0000 (UTC) X-FDA: 80691184644.06.CCBF247 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 8B30B14001D for ; Mon, 17 Apr 2023 14:56:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKuimgoG; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681743400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9AEy9mK6O3Mbv/ulbvFXi8BBb8TRpaehy7L8tKOiCn8=; b=wg+PUQMQ5dOfm/+fErp03xcXs+co4YmulOvsdOhC3VZCwo1fbD0SYGXATMPnrC6Xu3hmtS MBDGdi1rGf43OSYYHDiMjWZOciPb89mWsEds+WRW3WZ0Dz/6qxin+o6DgKcR7T9vSICv3N r+ZrvprDj6S6P4aR8cT1IClDNhw9/xE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BKuimgoG; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681743400; a=rsa-sha256; cv=none; b=M4Yl7aCbL+j5gderdp5kq/FbFOBIwAb335iAsNI8Snt4INRSiNR8L+elYUdrLLD+SoJrxV 1vlUoMSbzA3WBPrtclOkaHDRMS1JV9IdsDo1bR7ZxpxoZuMtu4/swQ4u77ySrT4MmFfOxm 6p9DL/jkM95OroVbbF2n9TbEo9KDKkI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681743397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9AEy9mK6O3Mbv/ulbvFXi8BBb8TRpaehy7L8tKOiCn8=; b=BKuimgoGbPNviT2UjIC2WXEx9bJPYaN/lQCBSOjy3mdjACI602ixNAkwzx2UaWcrb2FdY3 BxPIQ7KfHNwaZyYzsyDs4H0Mwds/X74SY5qzF1RUNNRyfANGqHOPKuQgfzauslQegm6qJa 4VayVM/3zfkQdvw1PhVXYz1UVrylmCc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-th2qWzNoP0q63BWxM3Hq3Q-1; Mon, 17 Apr 2023 10:56:36 -0400 X-MC-Unique: th2qWzNoP0q63BWxM3Hq3Q-1 Received: by mail-wm1-f72.google.com with SMTP id ay37-20020a05600c1e2500b003f16b58cf01so2884442wmb.0 for ; Mon, 17 Apr 2023 07:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681743395; x=1684335395; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9AEy9mK6O3Mbv/ulbvFXi8BBb8TRpaehy7L8tKOiCn8=; b=iEK8DPLHk0w4JoK+4HIt7+tG4sClawoG7uIXTT65J3W/RQVra1EQknjN0aEQVT6ruI KVckxJrClL0SuCcvZgSYfgSofD6rR7dJo2ctt1uf6ZFz3Ejk0ShKBhqLCeWzMxDTvjpu RCPZsh90O8TCswB1aGDmQ9rZII28fJUC6qVbcPGMUxzVlBYF3TpMgxXxRT4k4NZTcPuP N7WOaEc++3aspzYeAeAj2FXwpX+irSMgbjpCpMmgGejmQSEUOwO47cI2Y6DPZilJ1crR sbFVeYUijSYUTEed7OPQ6NSu0FcL61qhsDlSYHmhZR8oNxrGC9F/Sbq+Jysy1FLUNf56 uNOA== X-Gm-Message-State: AAQBX9dBhmn62QN36OonuRCp/Lnj5LMNRyaFWaAV3Vs4bI7e+/Ax/eBD 03QpYJt4yKGQbxBLbumIqw88gROnkaeqQe1YCZav/mN8ckMgO8RbmzvPaxA1FaZPjHgPiN1DNGq cnkyGi3wyk5o= X-Received: by 2002:a1c:6a10:0:b0:3f1:7324:c81d with SMTP id f16-20020a1c6a10000000b003f17324c81dmr2928930wmc.14.1681743395474; Mon, 17 Apr 2023 07:56:35 -0700 (PDT) X-Google-Smtp-Source: AKy350a6ddKymR8nlcmLUE/5sBw6TnJoW0qmSC81AMGo1SYFyxMxj5tFc0W5AcAdnFpqPUjwD1aYVg== X-Received: by 2002:a1c:6a10:0:b0:3f1:7324:c81d with SMTP id f16-20020a1c6a10000000b003f17324c81dmr2928915wmc.14.1681743395171; Mon, 17 Apr 2023 07:56:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id v22-20020a7bcb56000000b003f049a42689sm12161191wmj.25.2023.04.17.07.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 07:56:34 -0700 (PDT) Message-ID: <954d6b1f-5b4d-48e5-02fe-646b3e79f6e5@redhat.com> Date: Mon, 17 Apr 2023 16:56:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v8 3/3] selftests/mm: add new selftests for KSM From: David Hildenbrand To: Stefan Roesch , kernel-team@fb.com Cc: linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya References: <20230415225913.3206647-1-shr@devkernel.io> <20230415225913.3206647-4-shr@devkernel.io> <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> Organization: Red Hat In-Reply-To: <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B30B14001D X-Rspam-User: X-Stat-Signature: 6bezh1ry94kf1qxra3dwczcnfs76picb X-HE-Tag: 1681743398-862535 X-HE-Meta: U2FsdGVkX18QrPZ4CNkEakWUtQuwglA56i0UYTcZoKAOV/aVgqmxkatYo5yZN6PqWpEpnNxpGzNsJGqJWGPyd2LS3slAYuDo1y3g+Y6TYBg2Fqp80c6FzSJCDAjbyAlQFCpMmTJcwvvslG59zkPAONdsMHYVrGgAlbPExajqwTAKTg7KBsE9t1sVEZuqHs5BOIODvMZcD1l8/waXTBy88GmQ/V3J2CaRFgs032MwobIim98Q+lm79AWtfocimJqcQVwkxryKih9S+iRJ+1evSE36NABys1sBNBPqZwCq1fufurdZRQsZ36PL/Ihq594wTnGzAOPdvivRJ4HEzZCCvOVbJp6C4NoygBGpRmPKG++/ivWs1bIg3r3HGGpGOGoL2IAJNDCUb5G0ttdL4yUQdCul9BosHh7AGQbdwj8TAjxcEopcX+wZL4g6txzoZsDJQGxekLHEURnEdp+1zZc9qrCRluEPD4MjPmHDfQE3Pha4kcboKnPAgTPpxHQwOINk6yjWbKYxZb3PyfZJKtDhRgIkPQaWM/YZlV8gGpyiy8OQCZ/lpumiUfyJsTia/BcGHCIPjJKYgxWp++ifMreQUS7XFyn/znVAz6vDiyD/0r8hTmSbXzsH5yC/L8nia0tGcpaUSoeczgCXf/jYbCO0rHuQW9XLmRTEXCu6wSO3sPBOhYKBdkKIm4YkzOG3BMiUIOwH7e1qEvhrc7S5UcZYzYNsVq6i0pJJJhnBiLBPjMaRuYAD96pcs4hnDvz6BA4WP3t8s0V4IXmcKec6MxFZ73iEKGbzHrEcEIzFpTdTGqRibOxb7beWIXRn6CKken303sHBuknWa3238eBmvKzH8hYB/JUJ8rfPLwrnD7z4Jw3IJvMW3dOXcFqUL/7H/CJeqIBHuCBMTaSJVkCAeJwOq5MOzjJ4pTKqjeXNh6PST8VrZwdm5x8lfx6doz63SReelbwNQHp57c0YhJK9pUS WdLftErR aXMxYrGMnpbCC8HZ6MyHF9X+kLlPnLaZX0w0wJVrlpsgVNyKaeyrtSyv4vqnYs59xSktCNwvziHGyglnpJzFUZ2c/cF0697VTXKuJddUjcrqPSlUUI9D7skj3oi44y6fBnj/eHPeuEnmqrh9XT0/vtZziuxrYKLA3rWKX9InBkm3Z5ZhmIeZSDYpUMw00hLtSkqz4UVz8cq2A0K0FXueEAgXDS4UkDRvbtVzrwPwhGvpmii7LrII4+2HZ4Lz8j3NKQ/kCypTMUYUcRImUZ4QRTmQvUV887uc8PqGSxS8Xv1tuTLXQQJcqjHyXkFSTPIxnw3fv6WuaG/ckeOKVNvWoVVFHeZU8/c4hC1sQ6spdJLYeKcoiaN2PQ+eFdge0daFtaVO5p0A/Rc+AkGp1RhqEytrPbvA5j/4Z5mYqbeh51T+1FNA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000206, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.04.23 16:35, David Hildenbrand wrote: >> +/* Verify that KSM can be enabled / queried with prctl. */ >> +static void test_prctl(void) >> +{ >> + int ret; >> + >> + ksft_print_msg("[RUN] %s\n", __func__); >> + >> + ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); >> + if (ret < 0 && errno == EINVAL) { >> + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); >> + return; >> + } else if (ret) { >> + ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n"); >> + } > > Just realized we're missing a "return;" in case of the failure here. > And we should probably fix that as well: ERROR: do not initialise globals to 0 #235: FILE: tools/testing/selftests/mm/ksm_tests.c:57: +int debug = 0; total: 1 errors, 0 warnings, 512 lines checked -- Thanks, David / dhildenb