From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4CEC433F5 for ; Thu, 7 Oct 2021 08:50:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A43D611C1 for ; Thu, 7 Oct 2021 08:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A43D611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0C0B86B006C; Thu, 7 Oct 2021 04:50:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07141900002; Thu, 7 Oct 2021 04:50:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA16E6B0073; Thu, 7 Oct 2021 04:50:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id DB3C26B006C for ; Thu, 7 Oct 2021 04:50:52 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D2E372FE0E for ; Thu, 7 Oct 2021 08:50:51 +0000 (UTC) X-FDA: 78669021102.27.AD3EBD1 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 8004C900187E for ; Thu, 7 Oct 2021 08:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=g/hnrPUQ5KROv8pBt4MVp2ffO2f3NvPXgJ6LS1y/yls=; b=pDkVHTpW8/rfCY93n iC2IazGZX+L/h/DViFNhJGCXORCEzEFSxSuX7J8mIKMM02HdDDRsykJTfDa3bvwSAGKXswwxQASwo WN4JfWO9/mp2l8fhkKP4FCxBP2TImgkuj3QMKji01utniqu6WBk5tJWO+cvkIjqpni146+DciNwao =; Received: from [10.93.0.56] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1mYP6z-005JFi-W1; Thu, 07 Oct 2021 11:50:46 +0300 Subject: Re: memcg memory accounting in vmalloc is broken To: Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Cgroups , Linux MM , "linux-kernel@vger.kernel.org" , kernel@openvz.org, Mel Gorman , Uladzislau Rezki References: From: Vasily Averin Message-ID: <953ef8e2-1221-a12c-8f71-e34e477a52e8@virtuozzo.com> Date: Thu, 7 Oct 2021 11:50:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8004C900187E X-Stat-Signature: ucmnbizdzjd7q5jpbt7rpm586ihc8mod Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=virtuozzo.com header.s=relay header.b=pDkVHTpW; spf=pass (imf28.hostedemail.com: domain of vvs@virtuozzo.com designates 185.231.240.75 as permitted sender) smtp.mailfrom=vvs@virtuozzo.com; dmarc=pass (policy=quarantine) header.from=virtuozzo.com X-Rspamd-Server: rspam06 X-HE-Tag: 1633596651-939981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/7/21 11:16 AM, Michal Hocko wrote: > Cc Mel and Uladzislau > > On Thu 07-10-21 10:13:23, Michal Hocko wrote: >> On Thu 07-10-21 11:04:40, Vasily Averin wrote: >>> vmalloc was switched to __alloc_pages_bulk but it does not account the memory to memcg. >>> >>> Is it known issue perhaps? >> >> No, I think this was just overlooked. Definitely doesn't look >> intentional to me. I use following patch as a quick fix, it helps though it is far from ideal and can be optimized. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b37435c274cf..e6abe2cac159 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5290,6 +5290,12 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid, page = __rmqueue_pcplist(zone, 0, ac.migratetype, alloc_flags, pcp, pcp_list); + + if (memcg_kmem_enabled() && (gfp & __GFP_ACCOUNT) && page && + unlikely(__memcg_kmem_charge_page(page, gfp, 0) != 0)) { + __free_pages(page, 0); + page = NULL; + } if (unlikely(!page)) { /* Try and get at least one page */ if (!nr_populated) -- 2.31.1