From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2558DECE577 for ; Mon, 9 Sep 2024 17:08:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B33C6B01A1; Mon, 9 Sep 2024 13:07:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 663206B01A2; Mon, 9 Sep 2024 13:07:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52AFE6B01A3; Mon, 9 Sep 2024 13:07:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 342856B01A1 for ; Mon, 9 Sep 2024 13:07:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD06D80CC6 for ; Mon, 9 Sep 2024 17:07:58 +0000 (UTC) X-FDA: 82545832236.24.D45A801 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id DD12840018 for ; Mon, 9 Sep 2024 17:07:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BWK1eUbj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725901649; a=rsa-sha256; cv=none; b=I2skNNvHERDMhX4grDASrKdkbJiNv51VNIjgtg6r9KYvlVQ7qP+iKsYv38kEowgjcZIVWs qiBdAvdEXzu6RvVE5aBWUc958+0M013EsnEmYrs6KJYzZ/90HFhz3LiT4N5CbOcre8e54b orLRt6wBl3f71mIXQbJXzYPjagQcSQo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BWK1eUbj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725901649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VRF3dxirgHcKfvRlk9CHgM9zM7W8NPKg7f5/zk/dLNA=; b=Na/EL2tvxXrRKfGLrfsIhS2J26ha8XACyTWqml5r9WgdchFlGtrgwr7UAr9I7bG+5PamaA 2Uc52rnRkKt5p0u61+Lgb2O3cof0jZ673VDYbyajHjhuQttrlvCHP5mFZnEvujmIPqG9y4 nJgSwSQp8zUT4N5FymL6clWufT/Z5QQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725901675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRF3dxirgHcKfvRlk9CHgM9zM7W8NPKg7f5/zk/dLNA=; b=BWK1eUbjKESn/VaCp2fgRHh+aN4rqzFdWpf89kHQG5qPaZGJi3ivWroFFXKBpE9K/bX16C rltHTtrTD59ebXPa8cPj8SYdOwYVsGj3Ir4cS0pFH3bNe2XB7r1++yb9NbQWOUW8IqouTu 0KY7KaQBxmnkvGUWCLq+62xqh8yw14E= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-SZjt_tFaM1aIKD8SJ-_gpA-1; Mon, 09 Sep 2024 13:07:53 -0400 X-MC-Unique: SZjt_tFaM1aIKD8SJ-_gpA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68AB11953950; Mon, 9 Sep 2024 17:07:49 +0000 (UTC) Received: from [10.2.16.126] (unknown [10.2.16.126]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1F8D71956086; Mon, 9 Sep 2024 17:07:45 +0000 (UTC) Message-ID: <953607c5-8ba6-4438-bee2-17593ce5be54@redhat.com> Date: Mon, 9 Sep 2024 13:07:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] cgroup/cpuset: Expose cpuset filesystem with cpuset v1 only To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Tejun Heo , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Chen Ridong References: <20240909163223.3693529-1-mkoutny@suse.com> <20240909163223.3693529-3-mkoutny@suse.com> Content-Language: en-US From: Waiman Long In-Reply-To: <20240909163223.3693529-3-mkoutny@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspam-User: X-Rspamd-Queue-Id: DD12840018 X-Rspamd-Server: rspam01 X-Stat-Signature: pebtjnm7ohii9a6ip196uno8ipxrbtec X-HE-Tag: 1725901675-415393 X-HE-Meta: U2FsdGVkX18aKFl9vjKHgIRjcB4/0SYMCcDaIGh+7xrgAeiscTJ69plPZWQQvq6FeUo6peifrbuiRySKDd13wLwM9AzzQcwDmzfpEzfHnzGm2fM00d1P4f08VbcMdLBy78dzUBSB4E08J/O8QtAi0/upVJLla0QbHvn8lYyRcQNnJ/sRIyQqDCeY7CPSLZrxAExtMeRzyIMk8nTH0EJBaiBISXPWlb0WL74sFkxVv5qX8zPylmlHQPkXhXybJF0wxfuOxuvcIlnVZ/jKn78hmV3U4kkUkSVVg3nYNXAWk8G8QsLC2z0YjURspMpxbJDwscrcjDfYbFOSG+fkXKwktpRk3zJzgxhYRqY+ydazgW+Fr6T/s5F/TOYWpB8fEqBKCKAAKPgGY9CRMrctrXEZkdTvdlXcmAvYc57lcRr/EgNxtSAWLdhZmYVsakhWRBrV5Fc/dkvR2otQk/zg2n5mxhL+53z2EkDZAQZhJ8c17dYMFnsBN/vJhls31YDgQzZCSi46AG0GeZQGqQIklaXZPlTSzHl8I6I8YE99e5t0GcmXkvVodscqJoh0IG2siNrVYzDXrDYrTlqhuSDpx2E7Yj38KtpiQNvhdmM/bVFywvHnMYOwmMDv0ryibMgywMtanBETHJHPtwObHTLBYZEMApz0F3Xj3hwLDKesFBnt1HCKyFR4og/W0cWQgUMRudpvfGjYzH1yG0jLCsjTrHKDsL94XOOSrgQ+oB0u3p4rFQqrG5ywLpD3KtQ+LlwoDo0kn4R7kUfjpLRuzsBh5Wo0udNAwQht52Lh15Ycj+NQDGCeRn+rdv5heV4BeZioc8rwcHfjoCRbKOQCKq6FmnykPdfC2DbueFGt+t1TraOWGD2PRdfLo2rMcGOctKHRst7s/Zyr+o3mWkTScMndYDuxZZzi7uOSHzQOlZNFzF64OwCq6+HG6rLUqzq93qugiRpwlvpeq+Pl4AVdieuHgFx oJvE6iP2 c3Wqji7QWPP5NjXjSyFFcrdirilY8iamTSsE5WCduUX7TwULajOjxC2EYjvHJcKR1mHfENfZaB/B21kLIRBmTEugT2KdWm8az8gx5tXdQqZ8VPUSpbExlQujZrSGHVo58/ZHi7L66b5FtJfR57Rl1sLA8cpiCdRRGIMcKn2C9K7aGpM75YtBVhtqOiVnOkPuLgNmUtlNscE6lYZgM2j8JdvU281upiLlptrRbdbvck4AJDninacPZVmLgGUWhyT0axHYEcZrAIChnDvBLE/WM4iSn7Hj+C9gTEbP+a4O4EAgRp1+sf1B/K54N13KvDaRbmV46pZTCnGbl+OeFvmB6JzwvMSEmpkl3oPPo/2hlzgm6pECAO7SHOsDoAbepCVe+3bHRyIoIN+Ph6wSsDF89ToTdHB2jnU7rRxvJ0w+mcyNh4yQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/9/24 12:32, Michal Koutný wrote: > The cpuset filesystem is a legacy interface to cpuset controller with > (pre-)v1 features. It makes little sense to co-mount it on systems > without cpuset v1, so do no build it when cpuset v1 is not built > neither. > > Signed-off-by: Michal Koutný > --- > kernel/cgroup/cgroup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index c72e18ffbfd82..90e50d6d3cf39 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -2331,7 +2331,7 @@ static struct file_system_type cgroup2_fs_type = { > .fs_flags = FS_USERNS_MOUNT, > }; > > -#ifdef CONFIG_CPUSETS > +#ifdef CONFIG_CPUSETS_V1 > static const struct fs_context_operations cpuset_fs_context_ops = { > .get_tree = cgroup1_get_tree, > .free = cgroup_fs_context_free, > @@ -6236,7 +6236,7 @@ int __init cgroup_init(void) > WARN_ON(register_filesystem(&cgroup_fs_type)); > WARN_ON(register_filesystem(&cgroup2_fs_type)); > WARN_ON(!proc_create_single("cgroups", 0, NULL, proc_cgroupstats_show)); > -#ifdef CONFIG_CPUSETS > +#ifdef CONFIG_CPUSETS_V1 > WARN_ON(register_filesystem(&cpuset_fs_type)); > #endif > Reviewed-by: Waiman Long