From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A05D4922B for ; Tue, 19 Nov 2024 16:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E55C26B009C; Tue, 19 Nov 2024 11:23:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E051D6B009D; Tue, 19 Nov 2024 11:23:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7E9B6B009E; Tue, 19 Nov 2024 11:23:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A97246B009C for ; Tue, 19 Nov 2024 11:23:04 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52DF4140383 for ; Tue, 19 Nov 2024 16:23:04 +0000 (UTC) X-FDA: 82803363384.28.3D79C76 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id A68C41A0002 for ; Tue, 19 Nov 2024 16:21:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TUT4XGjl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732033315; a=rsa-sha256; cv=none; b=VdNL5djut16CWnmDyledQdlByyyKnIqCx6HtzYcYebi5RqvCrnY573B+MTmDsmpzApr2kP eZBvP4eUdXPSwZzCFeyJeVANZvp3yVgsYXP3j6KpYaQkZCc9yIzavQX+FUZz3lRmAkmgMX SvkHYcekvoO8GKhzbAL5fX3fQsQUdZg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TUT4XGjl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732033315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=suWdsjJ5WnUgZV8pnJXIYBOLHIoG3Gy/626N1DpjAyk=; b=5hEt1hfPcVFNna3On0p5ObhOHGQ0aSkHS4Wx8GFdR/OHkD0omzZa5AMFIliu8GsBIyF//E DRaY7xyeiKYkD3oehs+nBHZ7RwlyBFmGnQbMuhpTC3QWlz+8V9vPEylNR+EpwyDuvYQ5a+ XZypNEnAhSu7HRgUqrq1dDBQwtqIpjg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732033381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=suWdsjJ5WnUgZV8pnJXIYBOLHIoG3Gy/626N1DpjAyk=; b=TUT4XGjlK127KVQVnPyE50pxxOkSP53NrIHL/jb39vATleIxhA5ZntHC63C7WZxCGI1YgI 6OSMjjYkjQ4671RFp+/5fJ7lR1I9fzPlha0Vg1zasynXYCWkmllPmj0N9pgy6E20saCJzx 5RLqhV8yZ1u0/I2QK5pOqMc09n+9tJ4= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-Z3JT5039MwqhSwhf2rWsFQ-1; Tue, 19 Nov 2024 11:22:59 -0500 X-MC-Unique: Z3JT5039MwqhSwhf2rWsFQ-1 X-Mimecast-MFC-AGG-ID: Z3JT5039MwqhSwhf2rWsFQ Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-3a77085a3d7so15513525ab.1 for ; Tue, 19 Nov 2024 08:22:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732033379; x=1732638179; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suWdsjJ5WnUgZV8pnJXIYBOLHIoG3Gy/626N1DpjAyk=; b=EY8hMCHgDmfi/BOQ1jlHfRhZwCXIJK1ZRKdIyFRwKNdRRwVYtU6aGzSCHL/SsVgLEX L8JXvQuY3APdnz86Vfu1bNkyaWHF04+t+zNsEzfZKK3jYLDMuBq939xjFMGTQ0T+loCZ c6rMXyn+cdze+TmVC8uRJLBWeZ8aIugxMuECLpl9eSFYUPm7ZxCD12eg7HSpm7niHTgy He3fO2xJuSXQluIdSS9SJmA5U4tDkp/yfR548ckVqSUrudVhI7qlVjYphbEgrJuhhUnd 56qx6M8Po1ZK4W5W64/cuV29Wh4zwdiXNjQd216tosicptJsLFkRi/VRGWP3Kz0Yb/kZ dpww== X-Forwarded-Encrypted: i=1; AJvYcCWoechJSoWPSLyUNdwE8CJVX6Pn1uLZgU9drz1WkD2+KePIJqksrKBcZlK4Bui81kdiAhGEJ/yrqw==@kvack.org X-Gm-Message-State: AOJu0Yw7SyQKZQfXo62UKDvuyaUHyzwaiBFCQeAB6/darrhGLfv3uEhx KiWBIm+UbysS2DZxDqPzNsc3TtjZm0QDJGycy04TDV7cnjElyDwgZ8B469DmC43gNwHBNVCNzlr YmCvzwkEpk91IRolJPz7GwwKBtNPIbcOsr/wnA9LuXjcTfZuh X-Received: by 2002:a05:6e02:1526:b0:3a7:645f:6152 with SMTP id e9e14a558f8ab-3a77744e30cmr33621765ab.8.1732033379145; Tue, 19 Nov 2024 08:22:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiseTfVZI8CsQcS8/9Er7MhjJVsr44kaPa/nmeikEF5kUEcerPDk12H3KMCedgJZbYdTUn7w== X-Received: by 2002:a05:6e02:1526:b0:3a7:645f:6152 with SMTP id e9e14a558f8ab-3a77744e30cmr33621435ab.8.1732033378760; Tue, 19 Nov 2024 08:22:58 -0800 (PST) Received: from ?IPV6:2601:188:ca00:a00:f844:fad5:7984:7bd7? ([2601:188:ca00:a00:f844:fad5:7984:7bd7]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a77ffe8df6sm1870915ab.72.2024.11.19.08.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 08:22:58 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <95194abd-1ec6-4db3-9f83-4d482b2fac50@redhat.com> Date: Tue, 19 Nov 2024 11:22:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kasan: Remove kasan_record_aux_stack_noalloc(). To: Sebastian Andrzej Siewior , Marco Elver , Peter Zijlstra Cc: Vlastimil Babka , syzbot , Liam.Howlett@oracle.com, akpm@linux-foundation.org, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, syzkaller-bugs@googlegroups.com, Andrey Konovalov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , dvyukov@google.com, vincenzo.frascino@arm.com, paulmck@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, josh@joshtriplett.org, boqun.feng@gmail.com, urezki@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang1211@gmail.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, tj@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Thomas Gleixner , roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, rcu@vger.kernel.org References: <67275485.050a0220.3c8d68.0a37.GAE@google.com> <20241104114506.GC24862@noisy.programming.kicks-ass.net> <20241119155701.GYennzPF@linutronix.de> In-Reply-To: <20241119155701.GYennzPF@linutronix.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mRYE0ZT8hk653CzFsHg6PNzrdHtNn6xX0FX9icZfSIU_1732033379 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A68C41A0002 X-Rspamd-Server: rspam11 X-Stat-Signature: a7fch7bxa3zn89eymjqew6sp9zcx1zbj X-HE-Tag: 1732033318-798872 X-HE-Meta: U2FsdGVkX1+SZLLdlhRMdZ5zyINVtb1NWJtFiv/Kwmntg6qanDmEyI6EPyPgeMyhgW+jTNDZKjxD+C09NYcsuyqHzziEfHlmgecVYDmBIcADqFIcD+Qg6X37VrSkmQOKBcwgDLIrGAKS3k4aldVUNAryOfVg7HT1AtfZrFi59JSG/qsubLPkv7kyPnng3OCGqk4Rn36fmKY76zoYOWeU/h4k1S4LyJ3Wl+3tb8fXVaP70vIZ62SpoHZIfvQZuqI/pmYb/85yFuiwKlCk6L209byRU6MXsFUm1AfdxHthnx72fV/pkOe/wwiRCUAF09J8qilxrF1DsJ3oTqPlivie/MCyymNdVA6IePQBmSk+Tui/wjX/Pcbi5D4ZuiMu1+3T18YH/rkHSevDakXcRwsPS897bkjrA9t3SAdT2qiXCH5rBM3zVsdBK/IM7irTbsptgPdqSlg1CH9/MM7OQs4C8DuB1TZWMPOnPBxSjdK0nT7ir4v9ImVxdXcPNhMLDV5FkJBjxXO5OzIwAPR1nPWyI6GJPyf2zDvhOeD3pZ1YXbeouaFERYNDHom0vE/1EwedqoV1AJBm54HuXjNSRbV2GUzSdnWwni9ySi8BLEDJtilbQjCWCCbW3Gkbj2AJP/Ry2Bq+BZik/9SO6AiuL4b6al9QRsGwh3rCexy1GXFEQyMAzeUrPMKDssr9HmWkhY855/1gMWki1n9pvOaQ46iLHEXsTEuWuVQlI1NjurXeNZt+bYJq3JvTnMw/Cf60cxoqrOb6/CnpyDjaHlqwxzhXmlC6gYIc//EPz++gA3hII5v/FX5ISJ/A7o3e4CZkRLP0GHwhkAdep1ycMLQUQb/uPN+e5Fm7ZEgTSgMuIPN3mlv995WMKgZUCNW4Zcd5Jz5chZK3UZahzaZQJaJS9XoIFMwRB2vqR1NuZRXZfBQvNvsgXjoE+ES9bEJpg0bYyGNRv1MSWKFlgeIT/HKfD6s Qvvc0K93 lw8DnWjm8dX5qK+QOWYExOIIOxKYNmRkXhOKIFi5U8pR/gU9mzk0ESVHBUCtXB4m7rvk2/51woT/NNLo+JN9YxZJF1w0LKX8A2+y1Pr5oPUZUJ8WGi4acgHAi6+uFg1sdyTmq7EIQMtaW7sUWvsP8AWsIA0DYT+uhq5kE96KaUPlSPtYpYo8Ghy07wLtcL15odCvwAIIEDGVlr0hzakS4qXXj/6SF1aO/aXmHlR4FvRt+oS98TY3c0pH+cAQ1bKn21e64J3+01Z4/7HC3fyk10KBrfrYZ3ytHslPKRTCZP5B8NUb5H9VfCW/TLXC+Xerw//fRQ5GmQD2WTFtud534h6fbjR9cz1ZzaRh2WULddoVjeiEQt1kJ8bY1p2pycd0WaNmyyG2qIQ5JMF2UzBPkYzhHqWsdr75SJ5rZqkJDJ3NwgxC5zZSoplj9cCRowl3pK2SCAEntRPdrC+aRwIoij4CDzP+4mZH+Fk0NssEqwjBx522fUTLxtuTaG5UL+22le+KUkbUO5hZZh9jhhKguCBt/OEMUfPAd3CFxIP8gU5k1xHS/K1PRe2PoEn9B1z7rWPGTFD/zVrjO+hI5BI6FcfUfuD0Jc7XgNJvXypUFKscCOycbZrnxIk2A0b8D0Mi5ZR0GLc1x8MXyDSWL7pAuHxJ3HYr7Juq4BahCtwC3N72bqW0AsuWt9Wg0SGh+ZL2/JJLDr38wlTdfAv/9KAuEYlVlgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/19/24 10:57 AM, Sebastian Andrzej Siewior wrote: > From: Peter Zijlstra > > kasan_record_aux_stack_noalloc() was introduced to record a stack trace > without allocating memory in the process. It has been added to callers > which were invoked while a raw_spinlock_t was held. > More and more callers were identified and changed over time. Is it a > good thing to have this while functions try their best to do a > locklessly setup? The only downside of having kasan_record_aux_stack() > not allocate any memory is that we end up without a stacktrace if > stackdepot runs out of memory and at the same stacktrace was not > recorded before. Marco Elver said in > https://lore.kernel.org/all/20210913112609.2651084-1-elver@google.com/ > that this is rare. > > Make the kasan_record_aux_stack_noalloc() behaviour default as > kasan_record_aux_stack(). > > [bigeasy: Dressed the diff as patch. ] > > Reported-by: syzbot+39f85d612b7c20d8db48@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/67275485.050a0220.3c8d68.0a37.GAE@google.com > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Sebastian Andrzej Siewior > --- > > Didn't add a Fixes tag, didn't want to put > 7cb3007ce2da2 ("kasan: generic: introduce kasan_record_aux_stack_noalloc()") > > there. Right now task_work_add() is the only caller of kasan_record_aux_stack(). So it essentially make all its callers use the noalloc version of kasan_record_aux_stack(). Acked-by: Waiman Long > include/linux/kasan.h | 2 -- > include/linux/task_work.h | 3 --- > kernel/irq_work.c | 2 +- > kernel/rcu/tiny.c | 2 +- > kernel/rcu/tree.c | 4 ++-- > kernel/sched/core.c | 2 +- > kernel/task_work.c | 14 +------------- > kernel/workqueue.c | 2 +- > mm/kasan/generic.c | 14 ++------------ > mm/slub.c | 2 +- > 10 files changed, 10 insertions(+), 37 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 00a3bf7c0d8f0..1a623818e8b39 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -488,7 +488,6 @@ void kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > void kasan_cache_shrink(struct kmem_cache *cache); > void kasan_cache_shutdown(struct kmem_cache *cache); > void kasan_record_aux_stack(void *ptr); > -void kasan_record_aux_stack_noalloc(void *ptr); > > #else /* CONFIG_KASAN_GENERIC */ > > @@ -506,7 +505,6 @@ static inline void kasan_cache_create(struct kmem_cache *cache, > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > static inline void kasan_record_aux_stack(void *ptr) {} > -static inline void kasan_record_aux_stack_noalloc(void *ptr) {} > > #endif /* CONFIG_KASAN_GENERIC */ > > diff --git a/include/linux/task_work.h b/include/linux/task_work.h > index 2964171856e00..0646804860ff1 100644 > --- a/include/linux/task_work.h > +++ b/include/linux/task_work.h > @@ -19,9 +19,6 @@ enum task_work_notify_mode { > TWA_SIGNAL, > TWA_SIGNAL_NO_IPI, > TWA_NMI_CURRENT, > - > - TWA_FLAGS = 0xff00, > - TWAF_NO_ALLOC = 0x0100, > }; > > static inline bool task_work_pending(struct task_struct *task) > diff --git a/kernel/irq_work.c b/kernel/irq_work.c > index 2f4fb336dda17..73f7e1fd4ab4d 100644 > --- a/kernel/irq_work.c > +++ b/kernel/irq_work.c > @@ -147,7 +147,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) > if (!irq_work_claim(work)) > return false; > > - kasan_record_aux_stack_noalloc(work); > + kasan_record_aux_stack(work); > > preempt_disable(); > if (cpu != smp_processor_id()) { > diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c > index b3b3ce34df631..4b3f319114650 100644 > --- a/kernel/rcu/tiny.c > +++ b/kernel/rcu/tiny.c > @@ -250,7 +250,7 @@ EXPORT_SYMBOL_GPL(poll_state_synchronize_rcu); > void kvfree_call_rcu(struct rcu_head *head, void *ptr) > { > if (head) > - kasan_record_aux_stack_noalloc(ptr); > + kasan_record_aux_stack(ptr); > > __kvfree_call_rcu(head, ptr); > } > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index b1f883fcd9185..7eae9bd818a90 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3083,7 +3083,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) > } > head->func = func; > head->next = NULL; > - kasan_record_aux_stack_noalloc(head); > + kasan_record_aux_stack(head); > local_irq_save(flags); > rdp = this_cpu_ptr(&rcu_data); > lazy = lazy_in && !rcu_async_should_hurry(); > @@ -3807,7 +3807,7 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr) > return; > } > > - kasan_record_aux_stack_noalloc(ptr); > + kasan_record_aux_stack(ptr); > success = add_ptr_to_bulk_krc_lock(&krcp, &flags, ptr, !head); > if (!success) { > run_page_cache_worker(krcp); > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index a1c353a62c568..3717360a940d2 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -10485,7 +10485,7 @@ void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) > return; > > /* No page allocation under rq lock */ > - task_work_add(curr, work, TWA_RESUME | TWAF_NO_ALLOC); > + task_work_add(curr, work, TWA_RESUME); > } > > void sched_mm_cid_exit_signals(struct task_struct *t) > diff --git a/kernel/task_work.c b/kernel/task_work.c > index c969f1f26be58..d1efec571a4a4 100644 > --- a/kernel/task_work.c > +++ b/kernel/task_work.c > @@ -55,26 +55,14 @@ int task_work_add(struct task_struct *task, struct callback_head *work, > enum task_work_notify_mode notify) > { > struct callback_head *head; > - int flags = notify & TWA_FLAGS; > > - notify &= ~TWA_FLAGS; > if (notify == TWA_NMI_CURRENT) { > if (WARN_ON_ONCE(task != current)) > return -EINVAL; > if (!IS_ENABLED(CONFIG_IRQ_WORK)) > return -EINVAL; > } else { > - /* > - * Record the work call stack in order to print it in KASAN > - * reports. > - * > - * Note that stack allocation can fail if TWAF_NO_ALLOC flag > - * is set and new page is needed to expand the stack buffer. > - */ > - if (flags & TWAF_NO_ALLOC) > - kasan_record_aux_stack_noalloc(work); > - else > - kasan_record_aux_stack(work); > + kasan_record_aux_stack(work); > } > > head = READ_ONCE(task->task_works); > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 9949ffad8df09..65b8314b2d538 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2180,7 +2180,7 @@ static void insert_work(struct pool_workqueue *pwq, struct work_struct *work, > debug_work_activate(work); > > /* record the work call stack in order to print it in KASAN reports */ > - kasan_record_aux_stack_noalloc(work); > + kasan_record_aux_stack(work); > > /* we own @work, set data and link */ > set_work_pwq(work, pwq, extra_flags); > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index 6310a180278b6..b18b5944997f8 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -521,7 +521,7 @@ size_t kasan_metadata_size(struct kmem_cache *cache, bool in_object) > sizeof(struct kasan_free_meta) : 0); > } > > -static void __kasan_record_aux_stack(void *addr, depot_flags_t depot_flags) > +void kasan_record_aux_stack(void *addr) > { > struct slab *slab = kasan_addr_to_slab(addr); > struct kmem_cache *cache; > @@ -538,17 +538,7 @@ static void __kasan_record_aux_stack(void *addr, depot_flags_t depot_flags) > return; > > alloc_meta->aux_stack[1] = alloc_meta->aux_stack[0]; > - alloc_meta->aux_stack[0] = kasan_save_stack(0, depot_flags); > -} > - > -void kasan_record_aux_stack(void *addr) > -{ > - return __kasan_record_aux_stack(addr, STACK_DEPOT_FLAG_CAN_ALLOC); > -} > - > -void kasan_record_aux_stack_noalloc(void *addr) > -{ > - return __kasan_record_aux_stack(addr, 0); > + alloc_meta->aux_stack[0] = kasan_save_stack(0, 0); > } > > void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags) > diff --git a/mm/slub.c b/mm/slub.c > index 5b832512044e3..b8c4bf3fe0d07 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2300,7 +2300,7 @@ bool slab_free_hook(struct kmem_cache *s, void *x, bool init, > * We have to do this manually because the rcu_head is > * not located inside the object. > */ > - kasan_record_aux_stack_noalloc(x); > + kasan_record_aux_stack(x); > > delayed_free->object = x; > call_rcu(&delayed_free->head, slab_free_after_rcu_debug);