From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47746C43603 for ; Fri, 6 Dec 2019 17:26:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A156206DF for ; Fri, 6 Dec 2019 17:26:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A156206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D448F6B16F1; Fri, 6 Dec 2019 12:26:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF43D6B16F2; Fri, 6 Dec 2019 12:26:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C314C6B16F3; Fri, 6 Dec 2019 12:26:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id AE9446B16F1 for ; Fri, 6 Dec 2019 12:26:34 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 66C65181AEF31 for ; Fri, 6 Dec 2019 17:26:34 +0000 (UTC) X-FDA: 76235395908.23.beam19_1c29130d4fb07 X-HE-Tag: beam19_1c29130d4fb07 X-Filterd-Recvd-Size: 3304 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Dec 2019 17:26:33 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Tk8dtRm_1575653168; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0Tk8dtRm_1575653168) by smtp.aliyun-inc.com(127.0.0.1); Sat, 07 Dec 2019 01:26:17 +0800 Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes To: John Hubbard , mtk.manpages@gmail.com, cl@linux.com, mhocko@suse.com, cai@lca.pw, akpm@linux-foundation.org Cc: linux-man@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> <0dc96e40-5f2b-a2fe-6e5f-b6f3d5e9ebde@nvidia.com> From: Yang Shi Message-ID: <95170ea5-5b62-9168-fcd9-93b43330a1b4@linux.alibaba.com> Date: Fri, 6 Dec 2019 09:26:05 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <0dc96e40-5f2b-a2fe-6e5f-b6f3d5e9ebde@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/6/19 12:25 AM, John Hubbard wrote: > On 12/5/19 5:34 PM, Yang Shi wrote: >> Since commit e78bbfa82624 ("mm: stop returning -ENOENT >> from sys_move_pages() if nothing got migrated"), move_pages doesn't >> return -ENOENT anymore if the pages are already on the target nodes, b= ut >> this change is never reflected in manpage. >> >> Cc: Michael Kerrisk >> Cc: Christoph Lameter >> Cc: John Hubbard >> Cc: Michal Hocko >> Cc: Qian Cai >> Signed-off-by: Yang Shi >> --- >> =C2=A0 man2/move_pages.2 | 5 ++--- >> =C2=A0 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/man2/move_pages.2 b/man2/move_pages.2 >> index 2d96468..2a2f3cd 100644 >> --- a/man2/move_pages.2 >> +++ b/man2/move_pages.2 >> @@ -192,9 +192,8 @@ was specified or an attempt was made to migrate=20 >> pages of a kernel thread. >> =C2=A0 One of the target nodes is not online. >> =C2=A0 .TP >> =C2=A0 .B ENOENT >> -No pages were found that require moving. >> -All pages are either already >> -on the target node, not present, had an invalid address or could not = be >> +No pages were found. >> +All pages are either not present, had an invalid address or could=20 >> not be >> =C2=A0 moved because they were mapped by multiple processes. >> =C2=A0 .TP >> =C2=A0 .B EPERM >> > > whoa, hold on. If I'm reading through the various error paths=20 > correctly, then this > code is *never* going to return ENOENT for the whole function. It can=20 > fill in that > value per-page, in the status array, but that's all. Did I get that=20 > right? Nice catch. Yes, you are right. > > If so, we need to redo this part of the man page. Yes. > > > thanks,