From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD95CF9C7F for ; Thu, 26 Sep 2024 12:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EAB26B0095; Thu, 26 Sep 2024 08:57:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A606B0096; Thu, 26 Sep 2024 08:57:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 614126B0098; Thu, 26 Sep 2024 08:57:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 427AB6B0095 for ; Thu, 26 Sep 2024 08:57:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B49A21609A7 for ; Thu, 26 Sep 2024 12:57:53 +0000 (UTC) X-FDA: 82606891626.10.E1966C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 6D7A4A000B for ; Thu, 26 Sep 2024 12:57:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTS8xLMH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727355373; a=rsa-sha256; cv=none; b=LW9d2fw/hyJwvvzH/jrcTcmss0twbkmsZpsgfDwnwn6gUmtz5cEfPqx6wm+bBd8AVkIRmN bbUxbxAEE95Gz68HZbVwtcd1yL7UT0xEEMI3MOiArXIDrJ7TrMyNpsGcoV5cwTEUHjrSyk oZI2Qn4F9Ief475TYo4Y1nt/Z8kVN6I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RTS8xLMH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727355373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w5aVhgojZdD2dt5T9DQtW5tsGpyubA8XkXZ34ExGK2s=; b=KVvx1Moz6FARcG9Ju9ouCUt6myoGM8TEZOGwCDS4/rX/iWA+LhhlLofmxSFhNaSg6CdSoV UhV5SlYetnMyjuy52IfrY9YDzWMl7i9BHv6bAyRo9Mfnk0DiqoTkidz2lI/tnVoYUoeYEq MBsFqcQMPWimKQ5RPVSTfY4R4wzapdQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727355470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w5aVhgojZdD2dt5T9DQtW5tsGpyubA8XkXZ34ExGK2s=; b=RTS8xLMHfeI8ksn2M7NLChW/KmqKlccWTUaYE/S4RXYIO0grh06H12UquSQKA4Zt/bliHw 0yXdhgHhSKv0BikH9jZVB3Xz1AKO3qIoPx/Gl/18/M48APeDA+UfqHRB73G6O1KBzXlRWT U4ErnYPdhdbajEZJJ1/kGAAzIeBXqIQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-LPJ5jD1sMtSYdejjPoXfcg-1; Thu, 26 Sep 2024 08:57:48 -0400 X-MC-Unique: LPJ5jD1sMtSYdejjPoXfcg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42cbadcbb6eso7022725e9.2 for ; Thu, 26 Sep 2024 05:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727355466; x=1727960266; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w5aVhgojZdD2dt5T9DQtW5tsGpyubA8XkXZ34ExGK2s=; b=NacJhtDjk7ftZFVzfi94oH/qYXOJG4YMqDWGEKtTUSV4YWgHH9Fbez+yCLuwOaHZA8 X00OFTSFD6FWI4Ly4FO9EGgx3Q0K8cUQ3wPzZ6sQ90sDK5FqqnKJha0rMCAepi7StA8f Xu6vB+SITcDqf8RC3QuywjWEhrMS92rVMy55kl8hG2SuEXBO28btpEvN7Vbsjn/hYfBo M0ZFl68LLUk8tebKUlluGOpLeaDhcUQRm7Jg+08ye1gfaFVJDvusSk6ctky9FRsuABKS I5g1C7QR8hK/PaBSDxJ9ehzfTM7kXHXjiLQhVoRTLQzJRHh0u69VT28x0rKZP0ApLTGY U0XQ== X-Forwarded-Encrypted: i=1; AJvYcCWzg4lU1Py67RqWZEXJe7IodzWwlqi97QkdZfxocFsXsPbkBYedOlkS8xsd3+vAlMXryGGcqRJ14A==@kvack.org X-Gm-Message-State: AOJu0YyDcP91wKO4GE6jTx2EV8sVgCropZS2WXTjK99xm15Na4xqDICl dqPJ9Wdtv/5SuVGct06d5vIBpZ9fVAdbs+S2vQoLJpWDAvqdCYy7uKWmHT89I3wHrXvyT1WEP8S vvzvPaluuaYZZ2XqW5rtzA/VoNiy8voQw3dQKIMLUS/sDQcQOQf4PmZIoldM= X-Received: by 2002:a05:600c:3b18:b0:426:66a2:b200 with SMTP id 5b1f17b1804b1-42e960ae1b1mr53738865e9.0.1727355466314; Thu, 26 Sep 2024 05:57:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEns+h3Z/jyL/s/5q4yB6cInewHtGCCPEdYNLeLgTPkO88oUEnZ2JJwv+TTp7jHQm/GrFkX7A== X-Received: by 2002:a05:600c:3b18:b0:426:66a2:b200 with SMTP id 5b1f17b1804b1-42e960ae1b1mr53738685e9.0.1727355465864; Thu, 26 Sep 2024 05:57:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c744:ac00:ef5c:b66d:1075:254a? (p200300cbc744ac00ef5cb66d1075254a.dip0.t-ipconnect.de. [2003:cb:c744:ac00:ef5c:b66d:1075:254a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e96a36597sm46260575e9.31.2024.09.26.05.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 05:57:45 -0700 (PDT) Message-ID: <950cf384-03f4-466a-ac10-61c02dd2dc48@redhat.com> Date: Thu, 26 Sep 2024 14:57:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 1/9] mm/gup: repin_folio_unhugely To: Jason Gunthorpe Cc: Steven Sistare , linux-mm@kvack.org, Kevin Tian , Nicolin Chen , iommu@lists.linux.dev, Andrew Morton , Matthew Wilcox References: <1726319158-283074-1-git-send-email-steven.sistare@oracle.com> <1726319158-283074-2-git-send-email-steven.sistare@oracle.com> <6aea6530-9f9c-4a9c-9c9c-2c29e8ae9e9d@redhat.com> <98004c8e-f941-480e-b1be-8f6fd925871a@oracle.com> <27f8ff84-76cf-40ee-b391-e226218e5600@redhat.com> <20240926114000.GW9417@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240926114000.GW9417@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D7A4A000B X-Stat-Signature: p1cfh1atb1wwpnpq8fjajpjkahogt56a X-Rspam-User: X-HE-Tag: 1727355471-171393 X-HE-Meta: U2FsdGVkX1+PLypH0Eph8Z8J43unLjztXCrXhBGIPRbBTgMb++NVO3/rC5XvXzfLDCr0mYSSsSG99UxwSyPPvNI/yN/C9rRmCXo63QFU+/p7uB3xnkiXApHTDUHkpjDaa2jzQasS1vHJ3Sw0cOHSW8SVg8oGH4fZBDF37nlRWblexVzHEg+BXAiz413zOOyP/PLDJHFEU7JRJpp3X7TeEp4+MENaayTpnXcdjInSn3zkbLIXuWz0S7mQ8AD9G55mvCVC7RO60DhY4vgjjCWN3TLzPMDK2QLt3pdHwVrq1GXzGEaN2KHNQLIAWH1AY1cUW0tcSNWVHKtk3pDMFgtesFLHiGosb/oHSkc9lReoaEGVYQiVCRssQJ7nhOupOxH3WrQHeC+righm/2QHWywxkQPWa2XJFqnzCmENZevl5oO1nx63QVRjrXcNJkgA9g18+vOU6G0qBkk+XaBEUfDOOao8Otq4C/t1/pNuP1299D3FOulaskGRVC10ADh+6QnLWG+nQJUEPm/V2CGwIHYEKFh8hsdWNOhfMjjJsJHiGexHz4pnea0Au0SICUdzpAGqkMb+PI8WOPD+Nl0iQYEYFhSQdHjXBgm8f0mJXA9k85/nfEgUPHs/hc9DSJk24LrBLFilhiK5Trg4sYpeO8RK/Mo19vScURSzXuZJTQnRXn472IHl5RrIdZa3dNBXMGoKUsEz2DA6htr3hOJEctsa8FvvJvaNGa1oVHSOfu60imUzCiiNcHZQyi03JQuZScAHCJ/hWvhVQMY/dUSu/X0UUZuBZ0zhSHvjb0aAq+bteKx86ZnQDJttSKQIx3OdhI0G+74L8Uv1ccErQ7rd6lnGtiEFHyYp72wovZKZtiL/zTCs/JWm8nFffwU++64pEdtmNf31jBMd4lVSaSo5ly3D5XOnsC8kDGc+POM5yWNqh6WEMnmTjahUtIe1Wfqi6/CvkwPwtAuFlR2E5m12VzT imyKlJec 0uXs8yyz8EinHdxrtPViFMFapv3G7KsAODL/0AJ+Q0MGdV7wDr9TKmM5VopifUKCp3MtpLllxMiw7tdzey0oe7lbkSm+dGPVRt9Rb4B+mguDJ6oGiRd0qJpciRJvEFcnUpd3jqs37aimAc6hD3jpG1Ba/Z9Mbfpi9DSne/br/XV4OhxuQ3vs3hKlP64FCG+qafyZ/dIXYOh5YCHnx0fF5MN0fq+LDK7xa3zv1EhmQJcPhCl5Gp6IRvZviv9ybSF0Aaar1dHiUbw+PJaYLDh9XJ93yFP551cCcN1J8txqXFMik0NUQPlQMTavYenFmmHnLliZ+qtrCUyt/rfceAgGa6sJkOlzbwcC70RAC/9SdN0uEzF+rGg5lufqluW+5c/q99aKiBkRBIDOksYMmUS+h9hkrkXrLFH7NxzPl7PndJBwoAZr7GU1WB48CRt+o9BLNtxtA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.09.24 13:40, Jason Gunthorpe wrote: > On Thu, Sep 26, 2024 at 01:32:09PM +0200, David Hildenbrand wrote: >> On 20.09.24 15:28, Jason Gunthorpe wrote: >>> On Thu, Sep 19, 2024 at 10:11:38AM +0200, David Hildenbrand wrote: >>> >>>>>> And repin is really misleading. We are simply adding more pins to an already pinned one ... >>>>> >>>>> Jason suggests a better name in the other thread. >>>> >>>> I would prefer something that simply adds more pins to an already pinned >>>> folio. Much easier to get. >>> >>> Yes, but also nobody should ever want to do that operation, it should >>> always be part of some kind of "splitting" sort of behavior.. >> >> I remember patches from Dave Howells that needed that for O_DIRECT handling. >> Never say never ;) > > Wouldn't O_DIRECT be the same splitting thing? No, I recall the implementation had to duplicate pins, not split. > >> Adding is much more intuitive than splitting ... just like we add references >> when splitting a THP, using folio_ref_add(). > > Well, sure, it just seems harder to document so people can use it > properly. As soon as we have large GUP and splitting might go to multiple PMDs, multiple PTEs or a mixture, just being able to add the number of pins you actually need might be cleaner ... Let me have a look at the latest reincarnation of this patch. -- Cheers, David / dhildenb