linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: David Hildenbrand <david@redhat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area
Date: Tue, 1 Apr 2025 16:53:53 -0700	[thread overview]
Message-ID: <95068a38-2540-4518-a335-5c09e7a25b96@nvidia.com> (raw)
In-Reply-To: <3c90c3f5-3ec7-4ea9-b482-840f21db52ea@redhat.com>

On 4/1/25 8:26 AM, David Hildenbrand wrote:
...
>>>> be a fair bit more disruptive.
>>>
>>> I almost fell for it, until I looked at the calendar :)
>>>
>>> On a serious note: "struct vma" ;)
>>
>> We should put this in a helper struct
>>
>> Maybe:
>>
>> struct vmb {
>>     struct vma *vma;
>>     bool is_file;
>> };
>>
>> I think this would solve a lot of our problems and probably eliminate
>> anon_vma or something
> 
> If that solves most our problems, imagine what a "struct vmc" could do :)
> 

I was almost ready to ack all of the above, until I realized that
it was too disruptive, because it's written in C.

In order to be as non-contentious as possible, the whole thing should
be done in Rust:

struct Vmb {
     vma: *mut Vma,
     is_file: bool,
}


thanks,
-- 
John Hubbard



      reply	other threads:[~2025-04-01 23:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 12:25 Matthew Wilcox (Oracle)
2025-04-01 12:35 ` Lorenzo Stoakes
2025-04-01 14:17 ` Liam R. Howlett
2025-04-01 14:21   ` Vlastimil Babka
2025-04-01 14:46     ` Johannes Weiner
2025-04-01 14:54     ` Harry Yoo
2025-04-01 15:17       ` Mike Rapoport
2025-04-01 15:11 ` David Hildenbrand
2025-04-01 15:20   ` Lorenzo Stoakes
2025-04-01 15:26     ` David Hildenbrand
2025-04-01 23:53       ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95068a38-2540-4518-a335-5c09e7a25b96@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=jannh@google.com \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox