From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600C0C3ABC9 for ; Tue, 13 May 2025 10:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 522826B00C5; Tue, 13 May 2025 06:39:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2DF6B00D2; Tue, 13 May 2025 06:39:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34E6C6B00D3; Tue, 13 May 2025 06:39:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 118506B00C5 for ; Tue, 13 May 2025 06:39:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 278E359973 for ; Tue, 13 May 2025 10:39:14 +0000 (UTC) X-FDA: 83437537428.05.0067BA2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 04A4814000F for ; Tue, 13 May 2025 10:39:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=f7v8jFmz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4jAUwsPM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=f7v8jFmz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4jAUwsPM; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747132752; a=rsa-sha256; cv=none; b=vqQUy8I7aLDn4pmGBY1DYxKRoo5/++UpVbG8pepihtLz7c1PMfg1QYgFaWGX2A4G5UAlyj wzIwZGUxP3rHaQcrYkcKarr3Xxz4+mYfUILctY9SbntV38eq6rJ7+Yd8YTG5YtKG7tu4xq zPUQvqte/Lfu+UEfBrLX7Qid0rAWBiI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=f7v8jFmz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4jAUwsPM; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=f7v8jFmz; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4jAUwsPM; dmarc=none; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747132752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5hxbMAZGtcmyIepkJJQaXLIyots0rkHD4hyWC3BPQoQ=; b=pw8XOMDDYV3jyGRu5VC1s7GWm/oAgBeKMrrtiW5rW8+S9uX1Z7NMIT3ros7Y6oseJWikIM Z8jlMrOeMpjtef0y85P3BVmZbmrbo7j3i73PNOvSM7Ayc9RiCpwamfcjZ8tKsQ9HhQExX2 W61If/MUNHpWJ99uBh9LZa70TJd2wVs= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A88771F78C; Tue, 13 May 2025 10:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5hxbMAZGtcmyIepkJJQaXLIyots0rkHD4hyWC3BPQoQ=; b=f7v8jFmzltzCs218hCbhOuVYeyJFcEgUF6NdXddsQIYHYpOhLyvVDbDeyeudE4oHVMeDqZ osS3feVgZXbdGvDjaiddNA7toQYe652tIYLI1qD18vSsc2BKM8d4hZNIxoNYQOs0WCanOl f7XBmmf4RZjQQPr4al9PBmpeYJPEh6k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5hxbMAZGtcmyIepkJJQaXLIyots0rkHD4hyWC3BPQoQ=; b=4jAUwsPMMM1gHwWKMPnKIBF+tUflkOFzFOqu6bVCMzg8Q6EvYKrH4jozAovJfYSuCv22bQ wVoZq4aD2J3D8OAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5hxbMAZGtcmyIepkJJQaXLIyots0rkHD4hyWC3BPQoQ=; b=f7v8jFmzltzCs218hCbhOuVYeyJFcEgUF6NdXddsQIYHYpOhLyvVDbDeyeudE4oHVMeDqZ osS3feVgZXbdGvDjaiddNA7toQYe652tIYLI1qD18vSsc2BKM8d4hZNIxoNYQOs0WCanOl f7XBmmf4RZjQQPr4al9PBmpeYJPEh6k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5hxbMAZGtcmyIepkJJQaXLIyots0rkHD4hyWC3BPQoQ=; b=4jAUwsPMMM1gHwWKMPnKIBF+tUflkOFzFOqu6bVCMzg8Q6EvYKrH4jozAovJfYSuCv22bQ wVoZq4aD2J3D8OAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85583137E8; Tue, 13 May 2025 10:39:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zdqOH04hI2gFIQAAD6G6ig (envelope-from ); Tue, 13 May 2025 10:39:10 +0000 Message-ID: <94f2532e-040d-4b09-a82c-3cfa9c67c469@suse.cz> Date: Tue, 13 May 2025 12:39:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 4/7] memcg: make count_memcg_events re-entrant safe against irqs Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250513031316.2147548-1-shakeel.butt@linux.dev> <20250513031316.2147548-5-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250513031316.2147548-5-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: h8zbt7x14c37nqm1gxbe7j6p11mtp11c X-Rspam-User: X-Rspamd-Queue-Id: 04A4814000F X-Rspamd-Server: rspam06 X-HE-Tag: 1747132751-378584 X-HE-Meta: U2FsdGVkX1+xd58gplpr6wZ7wvlpKyC0KsvSyDSPGS+ixLpe6PXCfXfejkNkX6SO08SYnYpFXZ0UWmli5d+8N354X+VNndJDp4NDwuOiOKo7NxrVGaTfVAFJvqZWvStOwe4w5dyKlshluekXwEirhduOqqWVU6UgzE5021e6w0dopLE9qQvIEfB1KmUTZ/NI2k1rcBUcqCwS4CUxxmxOVORMtMLTgvtmz0/cZ3fOlfYvNrK2OllC0WH1s/fFOAmq2Sozo21xbKWDdIoX9Tq3d5FJ2h6ABhuTdQaQIJareznjHkxXC3Rn4EIiVQ4oJhFiZ0BzUH8dXXzaAjV8cpRR4s8WKG1iIKr07vkuKM+milP+1WV8URNLsCDXWbecGEs0nMKFlBdnwyf0dVKnsGU5RI9tWsAgxpM+NhfCFlwejTdojIsSzosd/ufxGEgP8DVNeggKCm41gGnIvBvegdcSDW2p/UdWpu6AlJljikcsRCBApjVUAfWkAEVndh/sIxYExTXnVJhQTagE/+AKP17O2TouPLCxa1epJ+ufutrS/ymBiz7ZDVjmHQwQiUEkxDJsjyVeH7/pZwFaoGl5bf081jKqdt7utbXxFhGylFAr0CqEK8uZTdn0zt6WHEdWfAq8DB1mZhzTt7t+IwGDK8MNvthHXzfxE9LpfSVwddF5kWTy9lGN1Y7Xr8tTF6NnYPZxReayrb2WYzKKG5IuspXPJaiiPo2dTtN5W4Y2IE6f9zeUncQD1ZYVIy5/NROVYCFpYorOLrzbLSoDE25iHhNGUKLHgnNPAPBWAN5KzsFBRucML3R7is+ZqARXarNb0up6jKz3wPMx2fBdDOwiv8skY35WAt1zvQaWggYkJl8MOu3q2Rmgu0YWeKVKkXzhsDXD8W5mRHtim8LoGOKf6AzhIDWa/CzCxg29A+X+i8CDsMbM7vWs9uqvIOOoAEFINUc621MrfPWmtYTFpPbRmw5 0U96r+19 ELHZh77At0ILb5Ss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 05:13, Shakeel Butt wrote: > Let's make count_memcg_events re-entrant safe against irqs. The only > thing needed is to convert the usage of __this_cpu_add() to > this_cpu_add(). In addition, with re-entrant safety, there is no need > to disable irqs. Also add warnings for in_nmi() as it is not safe > against nmi context. > > Signed-off-by: Shakeel Butt Acked-by: Vlastimil Babka