From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D476EC02185 for ; Tue, 21 Jan 2025 05:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08B3C6B007B; Tue, 21 Jan 2025 00:58:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03B186B0082; Tue, 21 Jan 2025 00:58:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6376B0083; Tue, 21 Jan 2025 00:58:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C1B006B007B for ; Tue, 21 Jan 2025 00:58:31 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C3BD44B93 for ; Tue, 21 Jan 2025 05:58:31 +0000 (UTC) X-FDA: 83030404422.29.16C628B Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 0DCFFA000D for ; Tue, 21 Jan 2025 05:58:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=I6vHeALL; dmarc=none; spf=pass (imf25.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737439109; a=rsa-sha256; cv=none; b=Ngj5gEg2n7ZbZqz5pltnPhpMMq1v5hi72rXSoYE+SRyYKwj8I4lNBetXqaFrOZ9SFGlZQo DP02+Ei8OgV+dhMlzPOLTlgVjp4E0AQwScaByhXrnkvdnzQ+baVa3Av7rqH64Bb/JQ4j+Q NkLsgZbHaHdI/9wed2MXHVtnXfCllb0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=I6vHeALL; dmarc=none; spf=pass (imf25.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737439109; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gf7BTqhynulFlNvhIKJUIKF0QGOZDxgKInp8xKSEew0=; b=XBX1pALrGtbooaWB0WvAvDm2jjArE/Bwy4ZS/qAi25vuOKM4NNGcJqa/7XSYlgV3FzHVr3 qpClyfOT3mFM2Sjd8qqleWENSTeIr/tdsIOXChykGt9Q30/GzBP9pBt816BtSOqIGS5SXC ecIX9N9qAUUL5e8CpnXHzZuAC+fZmx0= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21654fdd5daso87561605ad.1 for ; Mon, 20 Jan 2025 21:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737439108; x=1738043908; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=gf7BTqhynulFlNvhIKJUIKF0QGOZDxgKInp8xKSEew0=; b=I6vHeALL7DroVZktQcQOwGNfE7/KtPR44kXMC2DPHF4HxIcApEU7CHSg3us/OXCMPS /hyuFNYBT4CrJ6uXYLGRalhIUTNK5rVVCIqmWvDelRM6FaqPmk6jz3s472VWVbSmZX1h AQbDpAUJklavFtb/8rY5F8Pp7I3Z7FV8FYXf6HYKWn7vlo3R3AQ/xJ9yALn4dzMzl/ON 79Zw1oOPVp1CC1ElCwAQYaUjl73gMYL1lc8zpXzGlzbijem5en9plmW07vLOF9Z9wU86 FGrMG3sF22TZhwQ7RK0m8nMit0A7dQLzM7IosYdpWWF34rKnZDvwQkw+ASeTmCh82AO+ 0TTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737439108; x=1738043908; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gf7BTqhynulFlNvhIKJUIKF0QGOZDxgKInp8xKSEew0=; b=l3uHiGRuSHpVwlm8iNxvTCQz+9COkeM+7WhJ2ykdez91x2XaKum7pPd+ZGRHw6UgKd +RQiQykDfkUljNgLiY2WOT6koXzNjuuLxTJreJBYnNaXHY73upRmit3IJsuGW840jfNL fHLH7CPlbajKZROXChkMxIxMLcGHCsd/ZsAmI3VFFuk9Sz1LSEFlJ4uXUGEM91qgjAuZ B2imKDNCnU8bRjfcNaL3qMSZ35LYQtUlemPj+O5FO9s6hVqxYR0sr0O2h/4zK5dRnO+t d8W2/F7JebgTiZEmtc40sfQO+UogL9j0oXkdHW40ZuDjeIt+KyMxcrg1fL0SDdty+HaB qz9g== X-Forwarded-Encrypted: i=1; AJvYcCWW6Mi6xlJenp67bIWEpgHFGEZhcoog+r9Pe77paZOUlxWgXTuhEo2q+21moQ2l/Ntqx1LGM9PSag==@kvack.org X-Gm-Message-State: AOJu0YysyiWKf8BZiQbJFGgeGWa48L4CJcnPkUFl2qDkaNhCKUU1XhKq 8RljVH1lgwznZ49QeezJGDQMCTl4r3/JElvBM/Omy16hJHnSpkCc X-Gm-Gg: ASbGncvJ+SJ/V8ebFFElHgTBX4Jo+v93NltHTyMOGVhMSvxmj233V01xfJxkqCzp2Ce SKFQ16y2G7PP4u6LIoE5h06O5BivboIXpguOSBvqSHmuM+SXnh1qdEIIaJ6TYCvyPXqYCdxwv7a q+XCt8fCMq+WtGEm2J5uzrCqvyjypYuoxQH+Hu9ImJLicMQc/bwItywjac76tYhV7boPuHVryES MOi4NyMo5D/n6FdF6HVvmnBIrf6lwqjkFDrbS2p44ks6gVJUItSqjKp0E2EqNRaiJBJraaaJrj6 VNWyZKWGVPJ0jwFKNM8UIHxtC23OcYfQhy8SADPKiRw= X-Google-Smtp-Source: AGHT+IEmD+PLXN9nGshymvI8pZzDavtDT8AQK4+DovovAQNvIewFqB/kXP7iVm8P87Ljs7TkRBUH/g== X-Received: by 2002:a17:902:ea03:b0:215:b33b:e26d with SMTP id d9443c01a7336-21c3550c5d3mr262719185ad.21.1737439107609; Mon, 20 Jan 2025 21:58:27 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2ceba740sm69919465ad.79.2025.01.20.21.58.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 21:58:26 -0800 (PST) Message-ID: <94e15b07-bc0c-4c14-8dc7-d488491b42c9@roeck-us.net> Date: Mon, 20 Jan 2025 21:58:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Buiild error in i915/xe To: Linus Torvalds , Andy Shevchenko Cc: David Laight , Jani Nikula , David Laight , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Rodrigo Vivi References: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> <20250118221123.5bb65e64@pumpkin> <20250119090935.7c690f85@pumpkin> <87ed0xrcb8.fsf@intel.com> <20250120111551.435176c4@pumpkin> <878qr5ras2.fsf@intel.com> <0a65de6c-74d5-4d3e-be75-0aa9ecc82da1@roeck-us.net> <20250120184143.47615b21@pumpkin> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0DCFFA000D X-Stat-Signature: nkwzadgo79hh37a59e5zjgbdbidd8otx X-Rspam-User: X-HE-Tag: 1737439108-819193 X-HE-Meta: U2FsdGVkX195FqUbfQHN69XbE9Etfzw2Ea3Y2kkJVz7x+vVg+Db+BYPyEWOlMP+JHP0gh2HeOjwZaHzDpNj+Fi5gbkZO8otYjip9LlfLR99XuepRVrQiI/UDwqSdqVkr9pyP9AM8ze8IKtZFqAvJ+/P8NUX7EPAmM7+ljo8MjXwor444xvLnjq4w5xW2Xyg7iKnG3/qZwH9j/ll6Irsh2o9kncWBytU3kBqKJTthi8m+nUkMwU62Ngq8vxo+O5/1moxtLGVLnP8hOEvkQcSACOpLiOBOAccfCawuFnK1j9MusIUZe13LMlkwhHxTY8qZKsFNE+UoMwkDwyh3o1mtgYCGRp9HZtt+Cdk2N6QTkyIta+HW9gn+Idw8Y3Bwt88wiLrwFrn9HlyL1y+usOIu5VInuoWqfaQtwk+paLGB8Ht6Wsu8gqCrydZ1BOk1fu9DODjzniiqwG7tdH8mR2xtZQMvxFS+A9wvZabgId2i9Zb72GXe9JYttImJQRjZdk4uoHV8oJkueM8xPwWxCPgIwS3TQFjvt/U9alR3aLShXferKt1aSPH7tuUOAGEu9poSxlgQDAJamsc1DMjyujGbtrZ20RLxbj8OYw1K1tKCelE5qQiyedgDLIiuqgwTVyaKIH5E/X7KfeM0KPJPLpShvy11sWwYfk89HBxIm1g3o0xVgPrkn4s4F4qOMoUgsnc1+9xN5NXKIyJ2IPZMzOA2biQXhVKLibxfCxHrkmDP53W0+rf2qJGcIP16AJ4sUMAoCjfZrcMmqL3ZRfdzzI33zFbFh4RR1dFxn6ILkK6FY9zFZpsTJvGT2QsJJaZofQew4LIoBPaHUJNlIrulthZ1Z6e8C44npouvg3SbiZuQDCQ1/dm3pvP8NTAoz76Yahn/FrfRJywoPmlmlM55FO8R62VPpP1BQAWwSQzdis1LEUcEvnwgI4jk7yHeSSEwysZfiBGUhIIkhGV2EJKD+TZ lO5goCLH T2iBCWuRcMQ5Gx0OrHt2U8x0ZJZgiBI9Gs1xri4+2QVEE3b3xrr44xgNLlIqw+WsaZ+JE3Kg+MfZ+yCQH/OBTtesZXaJKi6kvnXVhJtLe9X0RXO4MmKRLBulzmBLJM1ZQhfxzHOO6bUcvDWQ+cK7I/Xi8inxTtAuFbWPEATz+7oaP05ZNVFme1g0UItg5rB2OW6pQvVbW69SU5nwQ+XY8OIgAq4DZO9WKrYk7pHuCZb+80F27qNWlOQkxisgkEvaD+XJCnDHCPXAW70eRYEDvR5lRFpqa6iGwYeoZlUt7fHExgxHnEjp0AaZ8epTRf+ngJG/++mzHOrPDOkSMLYFi4i0UE65MX5k78ClpL+MBtITFtjdzbi81PtrL4eNefNx7hoNKJ7LjMA900sdGboJ0cmB761evCHGOBYdXcrlSCvzwLvl5DXRojSDZAlxv0aYl7vQ55grFVQguU/GNaX786hR9qq8+RJm1CmifR/ORY62RXio+xpBtH+QawP58eB93mOvEgCXe8Gi1HEULxDM0JYSMFvzdwMVOPzYQFnGFfOPDhyMkDWitMXtssM9UYRrZk/wNvuloepuAntqtVE335pia/EywN/d9FWOetE5NfIghVZNJfZze+2K0Mqft3GyWG5P7VZAhDji+SQw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000081, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/20/25 11:14, Linus Torvalds wrote: > On Mon, 20 Jan 2025 at 10:55, Andy Shevchenko > wrote: >> >> Excuse me if I am missing something, but clamp() has a warning inside it, correct? >> Why do we need an additional warning on top of that? > > Note: the warning in clamp() only finds compile-time obvious wrong uses. > > It's really meant to notice the trivial case where you clam with > constants and just got the order wrong, so you do something silly like > > res = clamp(in, 15, 1); > > but it does also end up catching slightly more complex things where > the compiler can figure out the range of the clamping. > > The build problem then comes from the compiler doing various *other* > code movem,ent and optimization too, and - like in this case - finds > an error path where the clamping is done "wrong". > > I think the real issue in the i915 driver is that it does that > WARN_ON(), but then it just happily continues anyway. > > So if the i915 driver instead did > > if (WARN_ON(..)) return invalid value; > > none of this would ever have happened. > I'll take a stab and send a patch combining your and David's suggestions. Guenter