From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D609EE7542D for ; Tue, 3 Oct 2023 07:12:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35A96B01AE; Tue, 3 Oct 2023 03:12:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE5206B01B1; Tue, 3 Oct 2023 03:12:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88FB6B01B3; Tue, 3 Oct 2023 03:12:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CBAA46B01AE for ; Tue, 3 Oct 2023 03:12:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A96A61C9ED3 for ; Tue, 3 Oct 2023 07:12:22 +0000 (UTC) X-FDA: 81303281724.14.FBDEE5D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id 9D6C340020 for ; Tue, 3 Oct 2023 07:12:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aZWF76v8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dUPWRDhH; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696317139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ML0Bq3fUJtjxTm9VqpWVCcW1VPuRT3wjKkahW+Cqogs=; b=tFrrzbdnokLip/sXG+vMMADYoZivd/hgb1RAHPbt02h8Z06ycd/W0uFcwuYr9qOZMipQbX pFxdxdw3uxhe5RIrikaIkp4KVY/Ex/I2KMo6S9YkRd1FAIVi2WCHppS5VsGWpwJVtUtkdZ 9N3hK+1qujiOBnboDCE1ZIZnRE9lIqc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aZWF76v8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dUPWRDhH; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696317140; a=rsa-sha256; cv=none; b=odWK3mp8xX9YTheDxcVmPkHYpTgwhIG9nWy7vWlFRBw/JaFNPNQrJhKCdYer3LZXwu5FYT SQjbWtwB0mmY5TIHIYYoqplBPdeD5DUUNrHtNU1crV0lsOOym62Oj9GByrJ+MFmXsEmYoc JVjcCay9mOktDMLvyhRFsOEu0tQQKeM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3919821892; Tue, 3 Oct 2023 07:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696317137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ML0Bq3fUJtjxTm9VqpWVCcW1VPuRT3wjKkahW+Cqogs=; b=aZWF76v8QkH/RTbw/6ETYEGwaZm4Kr2napQ95HcZQO0wEDN0ceLYM0ryXqIa7B84zUhQ4N AvNM57dFWIRdLGvJILhvIZBHfdPUoSwVX9S/ZbnDehqYEy8wRj2br83GFWJjLBPdJturBH ey2o1zpGCZUdaM+YpvCCab/AU1QBRMQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696317137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ML0Bq3fUJtjxTm9VqpWVCcW1VPuRT3wjKkahW+Cqogs=; b=dUPWRDhHDiYcRk3VBbo2F+9BZZFCfkN8RvGuPqZ0lSF81r2iOCoqL5UTXdPC9ZMI3cZtAm jFDeNK1F509htLBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29C55139F9; Tue, 3 Oct 2023 07:12:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kuBqCdG+G2XcEQAAMHmgww (envelope-from ); Tue, 03 Oct 2023 07:12:17 +0000 Message-ID: <94d84c27-ad7f-3026-f105-ee7ab5a5e014@suse.cz> Date: Tue, 3 Oct 2023 09:12:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [vbabka:slab-remove-slab-v1r0 7/14] mm/kasan/quarantine.c:145:23: warning: unused variable 'flags' To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org References: <202310031433.kyisgGOt-lkp@intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <202310031433.kyisgGOt-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9D6C340020 X-Rspam-User: X-Stat-Signature: iseendj9zbkeuqqhpj76e375qokno1j5 X-Rspamd-Server: rspam01 X-HE-Tag: 1696317139-554788 X-HE-Meta: U2FsdGVkX1+99fEUpLxZplHqcp78KIXZOEjhPs3p19M5d8KgRldzk/25jJZ9S4VSdhn7Bv+QZLg+eB/NHqoO9i7T0tuazdEhbVSBCeVCSZeAg5hpVp5D6dsu29URMVWUO2u86RnXCplfJ0MuZSB9tb1Dan8Fje4LO5HYb+qs5oV6WrxPC0IIfiPiB2YzDd4TxxaZ29ZUOI6e3EwtE88HoiTOC1pQgLI2KY5L+Hc1B0Vp3rxNbkYC6TbWwdUi3Z2niaJUppo1CBTsbwFz3EcXx3BrZcoGw9jBuxfB2JltqsugldOHgkdClShARyvJvT1/MqszQ4CRFgFZGSLdC3cKXST3mkv+SP5a5ldB/WSFeyV8xWZaI1+PayaEKFZM+dbYJJXFNOO1V/lg/w0EP+l1MUolngZMQ7LDYcNVQwHVpRXspNOZyuCFNXrtPaHq5RVnROC7/e56Dzhp1s4OBNqN+ciBc1blqXUgvJRF6TZhGVe+yjCBSCNHqd6ZxgihVk1JmquHTW9IUWXi/KuOAZRyA9dBtzMYJw5b6Y70XXe0FqB0vAJC8Npm64X1b77eleW6ID3BhkhgVsuY2O7C3fRyv3C+LEkok6bJuRL6Psoa4zWw+uOeWf47B2j0/eSuATD1U9Y/y/u0fRAsmXrcr39tehKtEP9ezh1HerXZtLYWPVkmonHQxHcH5vKTAMXGJyYZ/OUBXa5qTM/fv2wk8bLtipeQ3NJaSEeHWQpz77zFOlZge12UOl42PBVcP2bJXClV0H1twsACnL8Cz4fmChnGGeF9XGm8lpk3pA2xgpBzhilZsrnnUSrcSqryGEAUWIWnlpFll5G5ZMq51Tk+ujdsC8DG+s78KHjqvFbGglWtdwISx22C6a55bnUFJeD9si+oDQDxVTxB2DVNbPYrP+qgJqc+m0arVQnh+v3NeXRKtvxN68u3tDnIZJGIT/H6jCkaBhk4DY06YXZ4pfmzXPz iGooBTUb DLDTMSd+yvmAzgGmIUdxvURRgOHaDzTSZRj+oDdcx2n1vQERcPvtvM4ysLPFgbpXgBElZc9T1kwpZoqPzkN8w87eHwUXxvkbQ+hL2uJgBdZ7I2s1IKcKYKBfVsSEr6el7FmAay/sjk0le1RNAPfBuZvjIziTnyJMq6BsPPPwooC5InysWbuSjjNyHgRLin3Fh3P35MO85wIC7/vsurwo2utPrkg+h74y5ei3qMrCIvwwgzBlrglKAwu0CppvaNUqxQQ9GkBjesbKObYx6nKiawwtyX34muQVyZPiHKeXdcqxWLBb2rhtg9oFNCrpPFkK6Z/1bhthXcuk6Uv7siJ0gLdB5g8J6vNVFG4u2ayZ5fqmlPSwAXvUucLxX65j8bcbBQ0oDcw3FeNWGVo8ONbWaAsI9g3MNkvAriMltSRm47dbNVk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/3/23 08:56, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git slab-remove-slab-v1r0 Hi, appreciate the test! Can you please adjust the Cc list for the repo vbabka/linux.git so linux-mm is not included, to reduce the volume. This repo it's where I put my own development branches for review/testing. For vbabka/slab.git it's ok to keep linux-mm as that's the official slab subsystem tree where accepted patches are merged. Thanks, Vlastimil > head: 227c2d309e94ff014379c57ecadff7df03a1e349 > commit: 175f421def9a7765457d1434f9df37303ff1ed9f [7/14] KASAN: remove code paths guarded by CONFIG_SLAB > config: x86_64-randconfig-006-20231003 (https://download.01.org/0day-ci/archive/20231003/202310031433.kyisgGOt-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231003/202310031433.kyisgGOt-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202310031433.kyisgGOt-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > mm/kasan/quarantine.c: In function 'qlink_free': >>> mm/kasan/quarantine.c:145:23: warning: unused variable 'flags' [-Wunused-variable] > 145 | unsigned long flags; > | ^~~~~ > > > vim +/flags +145 mm/kasan/quarantine.c > > 55834c59098d0c5 Alexander Potapenko 2016-05-20 140 > 55834c59098d0c5 Alexander Potapenko 2016-05-20 141 static void qlink_free(struct qlist_node *qlink, struct kmem_cache *cache) > 55834c59098d0c5 Alexander Potapenko 2016-05-20 142 { > 55834c59098d0c5 Alexander Potapenko 2016-05-20 143 void *object = qlink_to_object(qlink, cache); > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 144 struct kasan_free_meta *meta = kasan_get_free_meta(cache, object); > 55834c59098d0c5 Alexander Potapenko 2016-05-20 @145 unsigned long flags; > 55834c59098d0c5 Alexander Potapenko 2016-05-20 146 > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 147 /* > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 148 * If init_on_free is enabled and KASAN's free metadata is stored in > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 149 * the object, zero the metadata. Otherwise, the object's memory will > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 150 * not be properly zeroed, as KASAN saves the metadata after the slab > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 151 * allocator zeroes the object. > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 152 */ > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 153 if (slab_want_init_on_free(cache) && > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 154 cache->kasan_info.free_meta_offset == 0) > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 155 memzero_explicit(meta, sizeof(*meta)); > 26dca996ea7b1ac Andrey Konovalov 2022-01-14 156 > 97593cad003c668 Andrey Konovalov 2020-12-22 157 /* > f0953a1bbaca71e Ingo Molnar 2021-05-06 158 * As the object now gets freed from the quarantine, assume that its > 97593cad003c668 Andrey Konovalov 2020-12-22 159 * free track is no longer valid. > 97593cad003c668 Andrey Konovalov 2020-12-22 160 */ > 06bc4cf6cdde690 Andrey Konovalov 2022-05-12 161 *(u8 *)kasan_mem_to_shadow(object) = KASAN_SLAB_FREE; > 97593cad003c668 Andrey Konovalov 2020-12-22 162 > 55834c59098d0c5 Alexander Potapenko 2016-05-20 163 ___cache_free(cache, object, _THIS_IP_); > 55834c59098d0c5 Alexander Potapenko 2016-05-20 164 } > 55834c59098d0c5 Alexander Potapenko 2016-05-20 165 > > :::::: The code at line 145 was first introduced by commit > :::::: 55834c59098d0c5a97b0f3247e55832b67facdcf mm: kasan: initial memory quarantine implementation > > :::::: TO: Alexander Potapenko > :::::: CC: Linus Torvalds >