From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5D9D591AD for ; Mon, 18 Nov 2024 19:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 933066B007B; Mon, 18 Nov 2024 14:55:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E2306B0082; Mon, 18 Nov 2024 14:55:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783206B0083; Mon, 18 Nov 2024 14:55:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C9E56B007B for ; Mon, 18 Nov 2024 14:55:54 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F1BF81C6230 for ; Mon, 18 Nov 2024 19:55:53 +0000 (UTC) X-FDA: 82800269958.24.8B47529 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id D570E40005 for ; Mon, 18 Nov 2024 19:55:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G3ul4A7g; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731959569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LSvyAQv1+ggFO7FzXZmVJ0TcwTO7ndHdw19A4U5vr4A=; b=bHbl0RW0GlSM+I8PFjGcibFSRJ6UqPnCZChgY5E3gKGJx9wUwGWo0vQYoF/Z1GMdrljSDm apjfyGVtCYg3SXpnr20uw/NeTh9Vqq3krCmxILbpQLxSqJZ9ZA8ihRAJh9jm8xmTP/FprO AZ/0n3N15ZUkFnd2TQDAKvFXXveXZjk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G3ul4A7g; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731959569; a=rsa-sha256; cv=none; b=TAs5dq6ojrI7v9/90n6i8DRUlEJ0B+BKaslntVTrS4AGfzT3ykNmW+fJSuPRBEfuPevKmI ITFgGQBFDisnGEeFEPWjtXCQqINi+Fl4r2QhKiWBTWphy7ZiLdnIAU84Nc55vohfSo2/AI CGdGngvOhqxTaHO2kMrwJFjPmJfEvMY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 051315C5C45; Mon, 18 Nov 2024 19:55:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CCB7C4CECC; Mon, 18 Nov 2024 19:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731959750; bh=RtkieysrvqlURJf1zWx+ZCsnD3Q1ZsaX2rsrG98ofF0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=G3ul4A7gUmN2NyTDan3LjfEV5OFPp14CKjgqr+MXAYvz6I/ZECJjYg0Kiq/sVYCox KR/3gNMIFcRxboLSiJ/72WmmObw3vot8EXp9yvfw9GsByAXYeRnaYUdvxDZSSue8cI 7hWTs98KXg5OSNrF9Kp8sjywouah/cj9haXFZwFxzT83j9T4O0kPef6Zo2mwZBLRkJ P1mgmg0aAh7dzYr0LSLHAQUf3I8As7EPLdbY6UsdXhMVp4/Fba6sXvixftc7AAe91w rrcPhtWTHNhhPNcc5DYv5JMvTtl+up4mM1ggLCvPnxCikhP/di2pqkq9VDfKIFQCvP RXGmNmjtkQ6PA== Message-ID: <94c96fd93a065323c2520ca399612e2d6c353f49.camel@kernel.org> Subject: Re: [RFC PATCH 1/2] libfs: Return ENOSPC when the directory offset range is exhausted From: Jeff Layton To: cel@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Hugh Dickens Cc: yukuai3@huawei.com, yangerkun@huaweicloud.com, Chuck Lever , stable@vger.kernel.org Date: Mon, 18 Nov 2024 14:55:48 -0500 In-Reply-To: <20241117213206.1636438-2-cel@kernel.org> References: <20241117213206.1636438-1-cel@kernel.org> <20241117213206.1636438-2-cel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D570E40005 X-Stat-Signature: 5aqph5fa8cjy5odrfphjy4udbyis6hwy X-Rspam-User: X-HE-Tag: 1731959713-797401 X-HE-Meta: U2FsdGVkX18BRPbo4VyowaJ8aaKhHfoR/VxYmIOFdGATpQeJxZ4gQo36j3HllijkKxnRNLWhVAaXt5SVveKWu3G4dQsDfT+0whmP4nOSn8Tfp7EeRCODnOzd95wo3AZN+JzGYtnnA/pE2p5yyjWinq+tLAOmi38zFsh12Vt8rEVqH7fObL70Ti3VdXu5u0Ic/75/wvJUYGTCKgDqH0WRm863Iail65LG31uP6UROWcDeuTIMPsx/zZBWKN6jc+TPZ6CSk86Yx85Z5ZE9EyhIDrftyqRrcJUniqLoAHvQOdQE/lGSSnMQVOXFSppBFHk4NJTAOLncJVOT2peIi9IxpuDi5U3Uoc8gS7E2gBGxrkoqe2pjkmcinQMOveWsMQQJAFXiw5kukCEMWpUnnKHt9dBXbgsV4XWYLq5usBCcGkrRekfy+g9rofsW6zjYhH3cCCbb9yIE4jlU3cBNfFKTxxzzMb4bieS34FVlqGFV1xTkUghd9UIsQ/XVRfHWRThqjSmdN6Ws1QoxxyD2Ve+KcItxYvwOZY20gn9yqcX87+DGa47q1yDXa4JuyFqoRPBsV3B5HfYOKf4VpyJ8v3kK2WMScy2RrmArflERhneiAbmJMwFYYoD3ontEmUHqEG2cEw+xS4HLKPpuPicLB3BHtkYECij28/IgAkifykbi3MeBsKSRQjz9wtplTyj2LS31veJexZuBq3AmX8i0qTWh4syhWEsowAfq9dr41zB2gxhVqMaR96nFGYAsWcvxoL0v06romR1TIfzEx5Bg/X9qfaLuDQv9WiJhIKQ/7XcMu5aWbJYRj8GhbyY8Qqfx8I2bhtyOU2yrjeekzH9sQGYUPZejz5FEcuOMqJPN170ffoEMJTWNfbstzP5WrQsAr3wxIG4qtOKpZe195QeBvSFBCCQds/y/cin4ImFXtTaY/fgprsQ/eP6YEnXTOLMxfcy8rrRe+tQtOPrj5b8rXcf qLDhyAN7 N2YxYmWqX5gRnXMkLUlU//YFqSU/4aen5fGfkrf8IpyYfEk/zWEWHFs/9yFx4+Vg+DnipzOTqAVNNpWB0ivpBuyuy9NKrSQVULz0zmdnlIj/NNB8Qs32J7GyLpIN/LRohDSGxYavX8qi5cLRESG4Zfwn3nwVMo4ftyRN0t9Zvc1PG3O5HEgMiZlvjHhN6WbmYunhQNefKNzJJdkgoZhqESwVNmHG+F+KnJBLoOSjm4Qe5THM0R96la3lW7QF/A3dxu9wNoFFSyXAd+d8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 2024-11-17 at 16:32 -0500, cel@kernel.org wrote: > From: Chuck Lever >=20 > Testing shows that the EBUSY error return from mtree_alloc_cyclic() > leaks into user space. The ERRORS section of "man creat(2)" says: >=20 > > EBUSY O_EXCL was specified in flags and pathname refers > > to a block device that is in use by the system > > (e.g., it is mounted). >=20 > ENOSPC is closer to what applications expect in this situation. >=20 > Note that the normal range of simple directory offset values is > 2..2^63, so hitting this error is going to be rare to impossible. >=20 > Fixes: 6faddda69f62 ("libfs: Add directory operations for stable offsets"= ) > Cc: # v6.9+ > Signed-off-by: Chuck Lever > --- > fs/libfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/fs/libfs.c b/fs/libfs.c > index 46966fd8bcf9..bf67954b525b 100644 > --- a/fs/libfs.c > +++ b/fs/libfs.c > @@ -288,7 +288,9 @@ int simple_offset_add(struct offset_ctx *octx, struct= dentry *dentry) > =20 > ret =3D mtree_alloc_cyclic(&octx->mt, &offset, dentry, DIR_OFFSET_MIN, > LONG_MAX, &octx->next_offset, GFP_KERNEL); > - if (ret < 0) > + if (unlikely(ret =3D=3D -EBUSY)) > + return -ENOSPC; > + if (unlikely(ret < 0)) > return ret; > =20 > offset_set(dentry, offset); Reviewed-by: Jeff Layton