From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC228C4BA18 for ; Wed, 26 Feb 2020 18:15:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A661A24650 for ; Wed, 26 Feb 2020 18:15:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A661A24650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 555406B0075; Wed, 26 Feb 2020 13:15:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 505236B009E; Wed, 26 Feb 2020 13:15:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F4796B00A0; Wed, 26 Feb 2020 13:15:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 21B1D6B0075 for ; Wed, 26 Feb 2020 13:15:07 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F32FE181AC9CC for ; Wed, 26 Feb 2020 18:15:06 +0000 (UTC) X-FDA: 76533079812.08.plate77_83ef406f42429 X-HE-Tag: plate77_83ef406f42429 X-Filterd-Recvd-Size: 2336 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 18:15:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 60A47AE4B; Wed, 26 Feb 2020 18:15:04 +0000 (UTC) Subject: Re: [PATCH] mm/slub.c: replace cpu_slab->partial with wrapped APIs To: qiwuchen55@gmail.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, chenqiwu References: <1581951895-3038-1-git-send-email-qiwuchen55@gmail.com> From: Vlastimil Babka Message-ID: <94b29ab3-3789-a9b7-0a66-0acfaef6ca9f@suse.cz> Date: Wed, 26 Feb 2020 19:15:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1581951895-3038-1-git-send-email-qiwuchen55@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/17/20 4:04 PM, qiwuchen55@gmail.com wrote: > From: chenqiwu > > There are slub_percpu_partial() and slub_set_percpu_partial() > APIs to wrap kmem_cache->cpu_partial. This patch will use the > two to replace cpu_slab->partial in slub code. > > Signed-off-by: chenqiwu Same comment as for "[PATCH v2] mm/slub.c: replace kmem_cache->cpu_partial with wrapped APIs". This function generates code only with CONFIG_SLUB_CPU_PARTIAL and so the wrapper just obfuscates the code unnecessarily. > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 17dc00e..15bb0ba 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2207,11 +2207,11 @@ static void unfreeze_partials(struct kmem_cache *s, > struct kmem_cache_node *n = NULL, *n2 = NULL; > struct page *page, *discard_page = NULL; > > - while ((page = c->partial)) { > + while ((page = slub_percpu_partial(c))) { > struct page new; > struct page old; > > - c->partial = page->next; > + slub_set_percpu_partial(c, page); > > n2 = get_node(s, page_to_nid(page)); > if (n != n2) { >