From: "Lameter, Christopher" <cl@os.amperecomputing.com>
To: Michal Hocko <mhocko@suse.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm: fix draining remote pageset
Date: Fri, 25 Aug 2023 10:06:19 -0700 (PDT) [thread overview]
Message-ID: <94b0e0c6-a626-46a1-e746-a336d20cdc08@os.amperecomputing.com> (raw)
In-Reply-To: <ZORtHmDeDCMcCb7Q@dhcp22.suse.cz>
On Tue, 22 Aug 2023, Michal Hocko wrote:
> Yes, this doesn't really show any actual correctness problem so I do not
> think this is sufficient to change the code. You would need to show that
> the existing behavior is actively harmful.
Having some pages from a remote NUMA node stuck in a pcp somewhere is
making that memory unusable. It is usually rate that these remote pages
are needed again and so they may remain there for a long time if the
situation is right.
And he is right that the intended behavior of freeing the remote pages
has been disabled by the patch.
So I think there is sufficient rationale to apply these fixes.
next prev parent reply other threads:[~2023-08-25 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:08 Huang Ying
2023-08-11 9:35 ` Michal Hocko
2023-08-14 1:59 ` Huang, Ying
2023-08-16 6:49 ` Michal Hocko
2023-08-16 7:08 ` Huang, Ying
2023-08-16 20:23 ` Lameter, Christopher
2023-08-21 7:55 ` Michal Hocko
2023-08-21 8:30 ` Huang, Ying
2023-08-21 9:27 ` Michal Hocko
2023-08-21 22:31 ` Huang, Ying
2023-08-22 8:09 ` Michal Hocko
2023-08-25 17:06 ` Lameter, Christopher [this message]
2023-08-29 6:08 ` Huang, Ying
2023-08-29 18:05 ` Lameter, Christopher
2023-09-05 16:52 ` Vlastimil Babka
2023-09-06 4:17 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b0e0c6-a626-46a1-e746-a336d20cdc08@os.amperecomputing.com \
--to=cl@os.amperecomputing.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox