From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412D2C282EC for ; Fri, 14 Mar 2025 20:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB9FA280002; Fri, 14 Mar 2025 16:28:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6A4F280001; Fri, 14 Mar 2025 16:28:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30F3280002; Fri, 14 Mar 2025 16:28:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8601A280001 for ; Fri, 14 Mar 2025 16:28:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E17B856BEE for ; Fri, 14 Mar 2025 20:28:00 +0000 (UTC) X-FDA: 83221293120.16.F6069B9 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf15.hostedemail.com (Postfix) with ESMTP id 36354A0011 for ; Fri, 14 Mar 2025 20:27:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=G0caXqJx; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.18) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741984078; a=rsa-sha256; cv=none; b=vm+DCbQy7DOQm0NwQYGWrmc6Nw6yvIxgq4DZynJOiY8hipp6PPU1S1xAs34pzFe/+QY4FF aJHCpz7vGsN1xVAG16xnGWYo8UNX2KPdAtJ2Fxd/0UZm8DqQTeHUh4lenRXubk2mxl8pV6 JGp+TjC4XVtR0rcAnPi1ium9Bg147KA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=G0caXqJx; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.18) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741984078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RG4SqroJCU1DTSv4wrxAVrk0vqwpeBa/+O29kcmAajw=; b=Yk8Eu4x3+iFQCxT+rIu+WwNYXy5b+KFloDu2XVMGlk1wixDVtTCERyWKunIHTAXe585Dwb jmqXiUP1ez6hUXaTMA0/MutpGEBScsJyfMZfL3n8bXenlsyLq07BgzCnDbTlFcXVmXM8Uv SaSN0ZRrWlyAyNHqGvRhMoZCyu52NbQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741984079; x=1773520079; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=c98VBI/orTqJ8SUbn7WXT26aLVcLDP5S/+xzC3eQ7zA=; b=G0caXqJxOGodTn8Lft7TzD0Vg6uP4gI714gH0ioEBbtWyM0L1GlIz3Va Ibib/BIbKmqhoKQ/o7Qxno70jeScelIu5bjirPb3UKnosRI4fEamNCqe6 7akjARrA0oO39hfuFlvkxHNqds8xL0NULCm7bOHgZ9ZTBNpSEwRxIEQQG dplaqyMzxrIXReL1hL0iY1LB1czmMqJJzeeOXNKYFog/Qp6aIFJihVxCE TXFOO+t1lOYRD8Im328PEYnPjlptMTLHjMRugBB4WeFwEGuDeNGobbPKO N8pPkDcr4eBYyyHcHj1/ETQSeLx/gg8U8LYWmgfNFTSSYAijQzUkSE6KD Q==; X-CSE-ConnectionGUID: 6cEhbZfbSVu5C3yu0kjtJQ== X-CSE-MsgGUID: a0obizYeQO+ebYpDO6dKbw== X-IronPort-AV: E=McAfee;i="6700,10204,11373"; a="43326935" X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="43326935" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2025 13:27:57 -0700 X-CSE-ConnectionGUID: +AWBNPp1QmGlxlESfcoOTw== X-CSE-MsgGUID: 87K9jIcJSt6+kJtRe3ChGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="122105768" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.108.212]) ([10.125.108.212]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2025 13:27:56 -0700 Message-ID: <94a5ebb9bd4c8076f23489e014462ac6d169cae0.camel@linux.intel.com> Subject: Re: [PATCH 0/9] Minor cleanups and improvements to swap freeing code From: Tim Chen To: Kemeng Shi , akpm@linux-foundation.org Cc: kasong@tencent.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 14 Mar 2025 13:27:55 -0700 In-Reply-To: <20250313210515.9920-1-shikemeng@huaweicloud.com> References: <20250313210515.9920-1-shikemeng@huaweicloud.com> Autocrypt: addr=tim.c.chen@linux.intel.com; prefer-encrypt=mutual; keydata=mQENBE6N6zwBCADFoM9QBP6fLqfYine5oPRtaUK2xQavcYT34CBnjTlhbvEVMTPlNNzE5v04Kagcvg5wYcGwr3gO8PcEKieftO+XrzAmR1t3PKxlMT1bsQdTOhKeziZxh23N+kmA7sO/jnu/X2AnfSBBw89VGLN5fw9DpjvU4681lTCjcMgY9KuqaC/6sMbAp8uzdlue7KEl3/D3mzsSl85S9Mk8KTLMLb01ILVisM6z4Ns/X0BajqdD0IEQ8vLdHODHuDMwV3veAfnK5G7zPYbQUsK4+te32ruooQFWd/iqRf815j6/sFXNVP/GY4EWT08UB129Kzcxgj2TEixe675Nr/hKTUVKM/NrABEBAAGJAS4EIAECABgFAk6ONYoRHQFLZXkgaXMgcmVwbGFjZWQACgkQHH3vaoxLv2UmbAgAsqa+EKk2yrDc1dEXbZBBGeCiVPXkP7iajI/FiMVZHFQpme4vpntWhg0BIKnF0OSyv0wgn3wzBWx0Zh3cve/PICIj268QvXkb0ykVcIoRnWwBeavO4dd304Mzhz5fBzJwjYx06oabgUmeGawVCEq7UfXy+PsdQdoTabsuD1jq0MbOL/4sB6CZc4V2mQbW4+Js670/sAZSMj0SQzK9CQyQdg6Wivz8GgTBjWwWsfMt4g2u0s6rtBo8NUZG/yw6fNdaoDaT/OCHuBopGmsmFXInigwOXsjyp15Yqs/de3S2Nu5NdjJUwmN1Qd1bXEc/ItvnrFB0RgoNt2gzf25aPifLabQlVGltIENoZW4gPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokBOAQTAQIAIgUCTo3rPAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQHH3vaoxLv2XYdAf8DgRO4eIAtWZy4zLv0EZHWiJ35GYAQ5fPFWBoNURE0+vICrvLyfCKTlUTFxFxTiAWHUO7JM+uBHQSJVsE+ ERmTPsiU O1m7SxZakGy9U2WOEiWMZMRp7HZE8vPUY5AM1OD0b38WBeUD3FPx5WRlQ0z6izF9aIHxoQhci0/WtmGLOPw3HUlCy1c4DDl6cInpy/JqUPcYlvsp+bWbdm7R5b33WW2CNVVr1eLj+1UP0Iow4jlLzNLW+jOpivLDs3G/bNC1Uu/SAzTvbaDBRRO9ToX5rlg3Zi8PmOUXWzEfO6N+L1gFCAdYEB4oSOghSbk2xCC4DRlUTlYoTJCRsjusXEy4bkBDQROjes8AQgAzuAQ5rF4/ZYaklzSXjXERiX0y1zBYmcYd2xVOKf50gh8IYv8allShkQ8mAalwIwyxTY+1k72GNCZIRVILSsuQY6fLmPUciuCk/X1y4oLNsF/Np8M9xxwYwqUibUwRdWwpSG2V0bcqjtUH1akaoY758wLONUmXrlfVonCfENd0aiP+ZLxYE1d1CRPv4KbAZ6z6seQCEQrappE4YXIC9yJUqT076DD1RhPmwNbNTTAauuwG+vX+jWsc5hUaHbKsAf/Rsw13+RA3dzWekbeIxO9qvQoQ26oqKEA31mxWhwNDnkTeo07+e2EGC2BV6s+sU1/m/lup5Bj34JLP7qYtd6EswARAQABiQEeBBgBAgAJBQJOjes8AhsMAAoJEBx972qMS79lYmQH+I4qdFm8wlkh/ZVWNJMSpfUfupuLPZ0g0hxNr3l2ZltEskVl5w+wJV+hBZ7zMmSxMYvMjJ+5aBDSZOfzhnK6+ETl4e/heDYiBLPYCtvU88cMRFb3jKcVxSfSzbBawEr7OFfCny3UtmYQ0PJmHFT6p+wlEHSyKxtyDDlLS/uPPR/llK94fOhvQlX8dir9b8r7JGuFTjtG2YbsTuapi3sFDmBhFZwYcNMt80FSIXGQjJzrsl1ZVSIwmqlF2191+F/Gr0Ld92dz1oEOjwKH1oRb/0MTsNU7udZv7L8iGKWCjHnA0dIoXKilf8EJyXGQ0wjQE3WBAdMecb vSKDRA7k 9a75kCDQROjjboARAAtXPJWkNkK3s22BXrcK8w9L/Kzqmp4+V9Y5MkkK94Zv66lXAybnXH3UjL9ATQgo7dnaHxcVX0S9BvHkEeKqEoMwxg86Bb2tzY0yf9+E5SvTDKLi2O1+cd7F3Wba1eM4Shr90bdqLHwEXR90A6E1B7o4UMZXD5O3MI013uKN2hyBW3CAVJsYaj2s9wDH3Qqm4Xe7lnvTAGV+zPb5Oj26MjuD4GUQLOZVkaA+GX0TrUlYl+PShJDuwQwpWnFbDgyE6YmlrWVQ8ZGFF/w/TsRgJMZqqwsWccWRw0KLNUp0tPGig9ECE5vy1kLcMdctD+BhjF0ZSAEBOKyuvQQ780miweOaaTsADu5MPGkd3rv7FvKdNencd+G1BRU8GyCyRb2s6b0SJnY5mRnE3L0XfEIJoTVeSDchsLXwPLJy+Fdd2mTWQPXlnforgfKmX6BYsgHhzVsy1/zKIvIQey8RbhBp728WAckUvN47MYx9gXePW04lzrAGP2Mho+oJfCpI0myjpI9CEctvJy4rBXRgb4HkK72i2gNOlXsabZqy46dULcnrMOsyCXj6B1CJiZbYz4xb8n5LiD31SAfO5LpKQe/G4UkQOZgt+uS7C0Zfp61+0mrhKPG+zF9Km1vaYNH8LIsggitIqE05uCFi9sIgwez3oiUrFYgTkTSqMQNPdweNgVhSUAEQEAAbQ0VGltIENoZW4gKHdvcmsgcmVsYXRlZCkgPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokCVQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQTRofI2lb24ozcpAhyiZ7WKota4SQUCYjOVvwUJF2fF1wAKCRCiZ7WKota4SeetD/4hztE+L/Z6oqIYlJJGgS9gjV7c08YH/jOsiX99yEmZC/BApyEpqCIs+RUYl12hwVUJc++sOm/p3d31iXvgddXGYxim00+ DIhIu6sJ aDzohXRm8vuB/+M/Hulv+hTjSTLreAZ9w9eYyqffre5AlEk/hczLIsAsYRsqyYZgjfXLk5JN0L7ixsoDRQ5syZaY11zvo3LZJX9lTw0VPWlGeCxbjpoQK91CRXe9dx/xH/F/9F203ww3Ggt4VlV6ZNdl14YWGfhsiJU2rbeJ930sUDbMPJqV60aitI93LickNG8TOLG5QbN9FzrOkMyWcWW7FoXwTzxRYNcMqNVQbWjRMqUnN6PXCIvutFLjLF6FBe1jpk7ITlkS1FvA2rcDroRTU/FZRnM1k0K4GYYYPj11Zt3ZBcPoI0J3Jz6P5h6fJioqlhvZiaNhYneMmfvZAWJ0yv+2c5tp2aBmKsjmnWecqvHL5r/bXeziKRdcWyXqrEEj6OaJr3S4C0MIgGLteARvbMH+3tNTDIqFuyqdzHLKwEHuvKxHzYFyV7I5ZEQ2HGH5ZRZ2lRpVjSIlnD4L1PS6Bes+ALDrWqksbEuuk+ixFKKFyIsntIM+qsjkXseuMSIG5ADYfTla9Pc5fVpWBKX/j0MXxdQsxT6tiwE7P+osbOMwQ6Ja5Qi57hj8jBRF1znDjDZkBDQRcCwpgAQgAl12VXmQ1X9VBCMC+eTaB0EYZlzDFrW0GVmi1ii4UWLzPo0LqIMYksB23v5EHjPvLvW/su4HRqgSXgJmNwJbD4bm1olBeecIxXp6/S6VhD7jOfi4HACih6lnswXXwatzl13OrmK6i82bufaXFFIPmd7x7oz5Fuf9OQlLOnhbKXB/bBSHXRrMCzKUJKRia7XQx4gGe+AT6JxEj6YSvRT6Ik/RHpS/QpuOXcziNHhcRPD/ZfHqJSEa851yA1J3Qvx1KQK6t5I4hgp7zi3IRE0eiObycHJgT7nf/lrdAEs7wrSOqIx5/mZ5eoKlcaFXiKJ3E0Wox6bwiBQXrAQ/2yxBxVwARAQABtCVUaW0gQ2hlbiA8dGltLmMuY2hlbkBsaW51eC5pbnRl bC5jb20+ iQFUBBMBCAA+FiEEEsKdz9s94XWwiuG96lQbuGeTCYsFAlwLCmACGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ6lQbuGeTCYuQiQf9G2lkrkRdLjXehwCl+k5zBkn8MfUPi2ItU2QDcBit/YyaZpNlSuh8h30gihp5Dlb9BnqBVKxooeIVKSKC1HFeG0AE28TvgCgEK8qP/LXaSzGvnudek2zxWtcsomqUftUWKvoDRi1AAWrPQmviNGZ4caMd4itKWf1sxzuH1qF5+me6eFaqhbIg4k+6C5fk3oDBhg0zr0gLm5GRxK/lJtTNGpwsSwIJLtTI3zEdmNjW8bb/XKszf1ufy19maGXB3h6tA9TTHOFnktmDoWJCq9/OgQS0s2D7W7f/Pw3sKQghazRy9NqeMbRfHrLq27+Eb3Nt5PyiQuTE8JeAima7w98quQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 36354A0011 X-Stat-Signature: yhzcc5nz4n7erp5gwcutt6ibo4hpfe5u X-Rspamd-Server: rspam06 X-HE-Tag: 1741984078-379733 X-HE-Meta: U2FsdGVkX1+N+Ej/FFVeJVW+CMiVwi+y234s+0Twzd9uzKK5e/+65wgzL5WHwfW3i4xonorxVWTDwQkpYycdsao1VNBTY34tmaFaOBmO58ZPcDwKMp2lgA+tK8/Btx0yRXqE5eNB1RT5jI+huihHGSiy4k4RrW+R7jbSUlgOJxVcoWwX0Z3qa8zD8bvVNteOLA7QYQF1OVgPlEfk95bwJ9u/gotHAiOcQNX7fhmxINErDzg9Q+7BT4wMRqBNhIdV1xY11y3Y2sGfFx8YScxkNvRdV2ka1rXHRKbjw3etiQg4e4vDRngspPD6Doj1lJ6YtvNGqmwHbz83Bn8QTejEl34grODGx8ZglQ6OwVRgLtWq+BRhh/O3PWhm1DCVDBwgXM5dfsmRZcZVh2gOETqp25xNtcj/QKGdi+5lsgnQFTnMsygYzFSNFfFAJffMR+e206IBEEkoaI4FWu9EQC+o8gt8/KIDE+cgscyfxiSM2H/aQKBjxQ2/uNK+IpIZ40isHKyEb0BhJMTAv3+WgutvlZdVQJgylSe1OLnlHVXxcQqrqDOSXqcCrEcS2X7r8Js68Bg4GxmZaVqabaxBXJqyGllN4QJWc/RoSyaucjjux+lcbdHBhZTDqauYilA8tThPY/AcTRZVpVxTDnnwRJ6V4FQR75PdwdTd2f5oK8yXSNCF9iEHZAVxSLTuF8/x7SOIO0SGVbdx/zPf49Cufe9GdZZtftuPqPlt+bapPKZKfyeCe6aZhTlK8ciJ9clHqmM/gmHanGHgIQQeGxBDHzbT9FQNgwR0TtPm2+csk9l/hNtScQizVWkP+SuVYDmvtO7SDtz+nAglPxSkabJ84iPoYaZL8i6w86V90Uli8gQrUM5T57ra63rZCViGGUdQdtUSsTQyLgkGnBjntiNHtgpl9h1lcBCVti3kX1Aux6zVaxRyj0ZtjWVQ4SMxCXAARy2CMBwBVXoLa6ezq3esBLq 6ylZDpX3 +1OyxLOXX9dVplHA42iGSYTPA+PqRk8vVQNdZT5zkqMisXR0ztkSEw5d6yuqz2pTOIo9rXhFSoCTP7qeDhtN5HqlzYqY4JK4JmlKs/4Kz6Bl28Sx5Wp+9KCtjfecYRUHpQfnSqsSi9iCa7ELiqdQuRIVc8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-03-14 at 05:05 +0800, Kemeng Shi wrote: > Hi All, > This series contains some cleanups and improvements which are made > during learning swapfile. Here is a summary of the changes: Nice work. > 1. Function nameing improvments. > -Use "put" instead of "free" to name functions which only do actual free > when count drops to zero. > -Use "entry" to name function only frees one swap slot. Use "entries" to > name function could may free multi swap slots within one cluster. Use > "_nr" suffix to name function which could free multi swap slots spanning > cross multi clusters. Will be nice to add some comments in the code about functions with _nr=C2= =A0 crossing the cluster boundaries and those without stay within a cluster.= =20 > 2. Eliminate the need to set swap slot to intermediate SWAP_HAS_CACHE > value before do actual free by using swap_entry_range_free() > 3. Add helpers swap_entries_put_map() and swap_entries_put_cache() as a > general-purpose routine to free swap entries within a single cluster > which will try batch-remove first and fallback to put eatch entry > indvidually with cluster lock acquired/released only once. By using=20 > these helpers, we could remove repeated code, levarage batch-remove in > more cases and aoivd to acquire/release cluster lock for each single > swap entry. Wonder if the batching shows up in any swap performance improvement? Tim >=20 > Kemeng Shi (9): > mm: swap: rename __swap_[entry/entries]_free[_locked] to > swap_[entry/entries]_put[_locked] > mm: swap: factor out the actual swap entry freeing logic to new helper > mm: swap: use __swap_entry_free() to free swap entry in > swap_entry_put_locked() > mm: swap: remove unneeded VM_BUG_ON(*map !=3D SWAP_HAS_CACHE) in > swap_entry_range_free() > mm: swap: use swap_entries_free() drop last 1 flag in > swap_entries_put_nr() > mm: swap: drop last SWAP_MAP_SHMEM flag in batch in > swap_entries_put_nr() > mm: swap: free each cluster individually in swap_entries_put_map_nr() > mm: swap: factor out helper to drop cache of entries within a single > cluster > mm: swap: replace cluster_swap_free_nr() with > swap_entries_put_[map/cache]() >=20 > mm/swapfile.c | 173 +++++++++++++++++++++++++------------------------- > 1 file changed, 86 insertions(+), 87 deletions(-) >=20