From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C268FD63930 for ; Wed, 20 Nov 2024 12:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39EB76B0099; Wed, 20 Nov 2024 07:07:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E436B009A; Wed, 20 Nov 2024 07:07:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23CC96B009B; Wed, 20 Nov 2024 07:07:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 073D76B0099 for ; Wed, 20 Nov 2024 07:07:16 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9FA1A16022E for ; Wed, 20 Nov 2024 12:07:15 +0000 (UTC) X-FDA: 82806346812.15.39C1A8A Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf23.hostedemail.com (Postfix) with ESMTP id DDEAB14001C for ; Wed, 20 Nov 2024 12:06:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VfjN89wL; spf=pass (imf23.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732104251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uc4FeWg62+0tPnC8EZ1b1Ba4o8yAWdikfuNASs5qR+4=; b=mjNSZnVQRRnXZMTZtnuXnDc4xKfEBEyzlKU8Rnr55exKFL8US5CYUYqkLQdgv1mzs12Gvf nrsRf9GgwXXKq1Z+5R+x5yGfYURQga+DqQgIvxJ0/cRgmd4O0c3Q9Ux9Ig9PVQ+KPZ6JHd XbtEvqNb2HvhhFCVmt/U1XyT7L0uC7o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VfjN89wL; spf=pass (imf23.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732104251; a=rsa-sha256; cv=none; b=xRe1Jjt848hA7uOCo808f9t+hRKxIBwqy6e2n3Dy4/SGCoXnk3xqt85g7B67rYV4H4b3jC OGmlMl5Ax3DOISLhBk+gKolnHJuBN3wJHaNSFlHQ78OlJNNCnCZDbhCEt0h8AE6UuqlJgu v7Nk9L0W4dEhO8QSSYV6PPwPIUyMqeQ= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1732104429; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=uc4FeWg62+0tPnC8EZ1b1Ba4o8yAWdikfuNASs5qR+4=; b=VfjN89wLQNNSjWTUwIrRznk1FsYbl+0spNZRQA3sVn626igmbU5fLeCSJ0wqijlBx0O92R0sd+UErT78j38UBHAWGra5uGZibtkApPe2P/nw+fkB0PqMU6oJtGFACGRvhP4azv5aqedh/eqPBkFaSxHzNbPhbYK/R15UcfyXzOU= Received: from 30.221.144.243(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0WJsG-ew_1732104427 cluster:ay36) by smtp.aliyun-inc.com; Wed, 20 Nov 2024 20:07:08 +0800 Message-ID: <949e9cf4-60df-4e2e-96a3-2219cfcbb46a@linux.alibaba.com> Date: Wed, 20 Nov 2024 20:07:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] fs/writeback: in wait_sb_inodes(), skip wait for AS_WRITEBACK_INDETERMINATE mappings To: Joanne Koong , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org Cc: shakeel.butt@linux.dev, josef@toxicpanda.com, linux-mm@kvack.org, bernd.schubert@fastmail.fm, kernel-team@meta.com References: <20241115224459.427610-1-joannelkoong@gmail.com> <20241115224459.427610-4-joannelkoong@gmail.com> Content-Language: en-US From: Jingbo Xu In-Reply-To: <20241115224459.427610-4-joannelkoong@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DDEAB14001C X-Stat-Signature: znwpctdzf9ncruyja1mxmwb8byrdhb1b X-Rspam-User: X-HE-Tag: 1732104398-315058 X-HE-Meta: U2FsdGVkX18ktSerGozRoUx1Zq7zh+7Y2c5SrEtJtDNcEyn26iTN/6FUkYEZd8nQPJjPibEIZJgJrYbR0RxvlFeBrRH5G+DQlNp4iaLjAS635eJOCL9Gr/mYnV+KTW0GvZZt5q92mKfaE+vWPHQoqF6uS1MeDCOp4AeNi2kCH55PL8beLLDAofBdsBQEt4F8WeXKiUZnXSHrYl5CD08BzkPlaFAmbGo2UrG4JrF4yE+3uNpyYECHpplEbbMasOXxVnG6KQWLHMeW4EkjbKOPqXqx1ObUdei4LrhHlp2WMWtKHThzC4LJo8iVr/OM6MelA/CjsT8z1htHniy3GGynoRjB3b4IvjS9hW52aNlBxICTexFANxhHr1qKujeANlCSFZOuumnvZxl8eDjU3JgHfjk5Czao5b+7jXr6GTnkZGFwVzfa3cXQqwG7kECfWotCXhEuKq4iaa9RE8Tw9FGtZgPzxxSfhy+MdZ5j3TqWIob22W3R2W7zh2kaPrvjJACGT0Zu7ZJNKzlWLZWI7uniwH9Ry/ij1V2YEoFD3RyKkC9dvk9TbvO6Nk/ncYQxuEiVN9A6x/QMRGk9Mt1XX7+W+UyI5quP6et7PcxrXtWEfYjtRX/EHQeP8BY1twKhImDFL/oEr42aegRzoL69AH1Cl1S0FstUgJDs5vZSPbTEzbNvkWdCC1FLHxXgRvk34lADrigflVW7IpagBTIevLFDxBcKoZq6tmysD17REkYuykucwT4ewvSIyybIJJ7yRDBo32PCUmAIFcNQJmbaFKuZAdJ2iqyTX7OXCVUVap4zuUqBaSfOPCSuxS+oXIsNOiKB/LMhawgTlnHIWsxIVzHUNS32zStKdY2WJ2KiTnw4DKvJGb6g9z/dftzwmv30Wylt8aLtAFYDKeUEBKSVtZ3j60dSBfm77JY0ZKWL7UAw9Oo5TRJFOkOiC28U5doS6pydQauYHsnlfv34EOmvteW f6PD4gDO 4auouHy2TFl4mXr7fCTg7/tjE2RRDBuQjdtF8iyFfjF8Qgow7QPKpVE18Xa5Ro6JHbyrbZF3T/4gmFZ3RwOE3aohb1CdLuPx0iO8aBMc7fwhZbIs3nKvWzfkHyPZ/TBCHEGBsa1Z/LyiTYcdmynnO/nhVM8esIEgwyA2zaw/Umv5vNacUm6VP7/QBvfyXmN1fZhrMuVydrHgop2BsiROxbzJ5OYs+YSE+woKKQrlQd6ZAIee1bzzzeR6Kgd/g0+9g5rKWb915LowXjDDI/XiayWQy1G4OLsMDxKtybC5LrMKQFgMyEvOxAcrWkl/vUObpyTabANDqKTTGVsjCYix4l6jSRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/16/24 6:44 AM, Joanne Koong wrote: > For filesystems with the AS_WRITEBACK_INDETERMINATE flag set, writeback > operations may take an indeterminate time to complete. For example, writing > data back to disk in FUSE filesystems depends on the userspace server > successfully completing writeback. > > In this commit, wait_sb_inodes() skips waiting on writeback if the > inode's mapping has AS_WRITEBACK_INDETERMINATE set, else sync(2) may take an > indeterminate amount of time to complete. > > If the caller wishes to ensure the data for a mapping with the > AS_WRITEBACK_INDETERMINATE flag set has actually been written back to disk, > they should use fsync(2)/fdatasync(2) instead. > > Signed-off-by: Joanne Koong > --- > fs/fs-writeback.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index d8bec3c1bb1f..ad192db17ce4 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -2659,6 +2659,9 @@ static void wait_sb_inodes(struct super_block *sb) > if (!mapping_tagged(mapping, PAGECACHE_TAG_WRITEBACK)) > continue; > > + if (mapping_writeback_indeterminate(mapping)) > + continue; > + > spin_unlock_irq(&sb->s_inode_wblist_lock); > > spin_lock(&inode->i_lock); Reviewed-by: Jingbo Xu -- Thanks, Jingbo