From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338F2C77B7A for ; Wed, 31 May 2023 07:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B84A66B0072; Wed, 31 May 2023 03:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0E2B280001; Wed, 31 May 2023 03:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98825900002; Wed, 31 May 2023 03:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 824C96B0072 for ; Wed, 31 May 2023 03:46:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 568A11A0267 for ; Wed, 31 May 2023 07:46:44 +0000 (UTC) X-FDA: 80849768328.25.B614503 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 360CF180014 for ; Wed, 31 May 2023 07:46:42 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P51VlisM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685519202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAEIqyTQIqAgpwEz1m8TesLih/MrDXD4GJgP6XrJJHQ=; b=TN7RS4FsrCiKtFRnDOMuqndvJql8Lln3csBQXkSFV0unxj/nDzzHzld5E8E9N7MMZcCzHV D6ngEsZg12TL6pxYOOi79vBMrE5lf89Umg2JgXaSAH4IpS3IYSksMCWjZW+HJWZd8zT3yM 0ykLAwgnzD9k2DwO57wi7/7Sx5ykH3g= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P51VlisM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685519202; a=rsa-sha256; cv=none; b=m0ep97g0bBMiRtD0nkAD+eo5G+WEhDppGYl7hiL4RC1rRTGshHrJSmjaLn+yfP81Q1On0f ZY2vJK6cbCj1PtiXZ8qXuyyDdSU+SFZby0xwd1dgof3bFaX6yPx/BqQqJN0oM6ZtxCgpyb oPYR/6ZnLKXqTfIY0PcKI1eIBFqqkNw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685519201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAEIqyTQIqAgpwEz1m8TesLih/MrDXD4GJgP6XrJJHQ=; b=P51VlisMD7pWCRbQ0yjMZdUEFDH0xkj1rsaheKA3ZkOrwjW8ePAPimITJu2dOel1izfwoL xeyIKE9TzdGmRYhHjF2f3tlgIHLi45G2PAYZ+3AHiibrtc7410QvB6+KIGcdw/hYppq3iG etnTAd83yhM3SF+UVEkDC3r6R6/d9GU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-HczpncI4PEW9LKyAms3Uog-1; Wed, 31 May 2023 03:46:40 -0400 X-MC-Unique: HczpncI4PEW9LKyAms3Uog-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f608ea689cso33832815e9.3 for ; Wed, 31 May 2023 00:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519199; x=1688111199; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lAEIqyTQIqAgpwEz1m8TesLih/MrDXD4GJgP6XrJJHQ=; b=hyOBaGbolohZV5YrtfEJbi5TM5KvOZrj5ZLU/cUcEblU/uEBD8gInd9/BIrTa57ueV m0LPj0qUVtF/I70Y+5q0uyvcCFIehBg8oxX4Ycr0Yt2dcyHLehfH9/YgMo++Pl60ojy7 6Bm6VTCFW/bNA/ZncreHI4DcSaQG5QLwXUXUr+H3AClcshycJdKNzsr/YZnavpj3LuCQ om23RbrC3HvgTQ1yn0+gMY9Dore66IFWLLyiIVxT9DAUR55pzueznOHqWbtmfVTSsblk tY3a5Wgo4MY359GsM4GOHpW7o7BM2WxEfGh18CJfjQe6TyyKGB7oYVGW7hkN+0Gcvx2w zHdA== X-Gm-Message-State: AC+VfDx8iGDKk5LTJG5NPD2OaXjEgVHzJ7P32hqL6PStO8WvQaBPxIa0 yYnYSdcB0i+ZRG5yPSPdWf6Si4UjAiDSwRdlz35nRjX/g2YXf6jYWZ//dO3Z7SgRXWeKunLt8Kx NaFAPjmZPJPQ= X-Received: by 2002:a05:600c:294c:b0:3f4:2374:3512 with SMTP id n12-20020a05600c294c00b003f423743512mr3473971wmd.18.1685519198914; Wed, 31 May 2023 00:46:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7z2nWeeDyToNoabyk0bgUbIZ5Qb1hjh9n0hxodHOR7kl1BRQ2tIjARx8taRxj6Rm72VES6uw== X-Received: by 2002:a05:600c:294c:b0:3f4:2374:3512 with SMTP id n12-20020a05600c294c00b003f423743512mr3473958wmd.18.1685519198688; Wed, 31 May 2023 00:46:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id d13-20020a5d4f8d000000b0030ae69920c9sm5748797wru.53.2023.05.31.00.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:46:38 -0700 (PDT) Message-ID: <9493177b-c435-9adc-cdfc-e45b91f02e77@redhat.com> Date: Wed, 31 May 2023 09:46:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V3 4/5] swap: remove get/put_swap_device() in __swap_duplicate() To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao , Chris Li References: <20230529061355.125791-1-ying.huang@intel.com> <20230529061355.125791-5-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230529061355.125791-5-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 360CF180014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: e46cycfghqfywdj35xfjfi6gha43jj48 X-HE-Tag: 1685519202-794368 X-HE-Meta: U2FsdGVkX1+5fFa9xBZAI51fXdwluAX9PFECy/p8EgFNTA4Ced124L4bKIZN9166Rz1g7saOW/CpwpB4eKV+JRa2BfEhQqqBZI/gdfoxmLg9CYZb3pe+XA7LWMtFpftWCIAFkDmt3zyqYZqElW4fNMVUYY4KPGZ4JC9DOoNcvyrow95m8WCuz6TP3/aRwMVr3BPfuau/WZ0Tqw26e9KZAGkGnOMZnsAlApvZDVAFUAPQV8ctdNCcInSzsj2xoWw5swPeYmuiFKVlwn6UH8UgKHFxBAK4sgHlyS9LKGyh/g06ev4EjyfOewOfuRMiEkDB7kg6ObE0MuWB0B7Bui2HokTXA3CyBYmR/OxwbG+Zksa3pLH8XElzbj+hc/zIh3B3jfJcWZ+UndjuJ6afpvUM5IC3vTlte1tkckbGUsDlnjwAtjkpG+56ISESqPsa72i+kFZAuTTEEt53x9Qgk4emrQqG0hc8Keo/m3NoDuk/4QzTtEaXLHuwMmSYo5hsFXs3W5pcjtW+DwvRK/kFyuXzsj6XDXD8zc6J+Gm3aQynL+/Vx1zJr+VN49L3X13FpxSisgHSLtC/xarwX25FL9c3v1Dy852fschQtTp30pGzFIuXT4y4cpV7qOIGRkiGCREo1Yb8Ya+uRuKhHq5OFLR16qBXvyzRSRhFemPspuUXp82/vp5SV8XWyg4r4Ym6/hS6+tq3W+rt4TSTnM990HJg8B9aIgPegy1kZWEPrk/iJr/DYv6u7wAmTfsssaTuXo99P6s+rIVmvQX+Um50kvutbE4Q6d/5jFMHMqVDHXyDKp6N0qFVijWOOsvPWYNSQ7QdKZUbLo8SHCmvLwOh5XN88eqyN+nWMpymm5QugFFJs2Bh7H+14cAyRt3P/++zDWabvLwXWpTu7nY8OQRFb8hPPvV6a6qdTdSLQfxzHKgGZdSw16LMEypV1X6HGWU8ILvZfkuoKtJlpn5wfN3oqPZ Tpi4dHU8 YTsWn2dC0q71Waf2x+xM8/+Lv6j3Mukyf0QhB/QbiX7Q3VqzgBEt7nPImUUE1KqyecyzKCynZY4nIC64YaHW78wES+4wQXzU0kLDzwA/ANXA3dj9oybN+POsb9fxiYmsImWPi16Amw+Dw75a2U4hUR1f6lVc5VgGJWJpxDz9GcBvxsBnvEdvN4hBAnR2YwCuNxDyiJR7l/IbqOZd7AZyonwwn40BkLlp8AO2l0uu9Krcub3s2ifP1Al8WiFxbJGd/MW7FNwWKMrFWVBgARhwdRfINfnSIeNWr/bt0neNhXkn2sz+7C6uqykEIWWzJd0BeexGLbZenbPwy2cSOwAf+svhUcWzadUa+j5eSV8RDRZGv5LV4TxT4yZmpc58VEwK5z/ee4qBrtCM8C0pUDIjd4EKfUDVOV1QeS+kNU0xqhhjxGB8fK9qzKPA5NAiZKG0ZIYYh1mtFVqr5BfR5wZbUy+DH3mC8SxjuT/GZvv2lE4JukSKr2JZCCXpIAG3DH3t8hZ+z3IffIxChgzhEOqij+Hny5WMXpOS9keFvBvIJunI3gb/fVrC4tiDXfMvYi9+/s7ZPzmlIWFTUeV8a6jyp6YWvDG+OEvb6MQOCT3hoh/Qm40CTrJbrxbR5DQgqtlq6tFjPMR1/lvuMxeluwuhHl2FybVj5Gl9H3Dy2DHpj3kLeek3Tcf/A/JRJNVJ7zpCHBXJ6f4hAIzaE6urMcCDJG6cEGKV9KkEarEBcU8mka5flKtfcRxdAAnPyqxEwFMz+EWez X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.05.23 08:13, Huang Ying wrote: > __swap_duplicate() is called by > > - swap_shmem_alloc(): the folio in swap cache is locked. > > - copy_nonpresent_pte() -> swap_duplicate() and try_to_unmap_one() -> > swap_duplicate(): the page table lock is held. > > - __read_swap_cache_async() -> swapcache_prepare(): enclosed with > get/put_swap_device() in __read_swap_cache_async() already. > > So, it's safe to remove get/put_swap_device() in __swap_duplicate(). > > Signed-off-by: "Huang, Ying" > Reviewed-by: Yosry Ahmed > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Tim Chen > Cc: Yang Shi > Cc: Yu Zhao > Cc: Chris Li > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb