linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "yaoaili [么爱利]" <yaoaili@kingsoft.com>
To: "HORIGUCHI NAOYA(堀口　直也)" <naoya.horiguchi@nec.com>
Cc: "Oscar Salvador" <osalvador@suse.de>,
	"yaoaili126@163.com" <yaoaili126@163.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"YANGFENG1 [杨峰]" <YANGFENG1@kingsoft.com>,
	"willy@infradead.org" <willy@infradead.org>
Subject: RE: [PATCH] Fix incorrect compound page flags store
Date: Tue, 8 Sep 2020 09:10:49 +0000	[thread overview]
Message-ID: <9492b81a2e9046eaa3e4028c1f0e7879@kingsoft.com> (raw)
In-Reply-To: <20200908090046.GA5714@hori.linux.bs1.fc.nec.co.jp>

Got it, Thank you! I think I need to learn more about thp.

Thanks
Aili Yao

-----Original Message-----
From: HORIGUCHI NAOYA(堀口　直也) [mailto:naoya.horiguchi@nec.com] 
Sent: Tuesday, September 8, 2020 5:01 PM
To: yaoaili [么爱利] <yaoaili@kingsoft.com>
Cc: Oscar Salvador <osalvador@suse.de>; yaoaili126@163.com; linux-mm@kvack.org; YANGFENG1 [杨峰] <YANGFENG1@kingsoft.com>; willy@infradead.org
Subject: Re: [PATCH] Fix incorrect compound page flags store

On Tue, Sep 08, 2020 at 08:48:21AM +0000, yaoaili [么爱利] wrote:
> Does the if (PageCompound(p) && compound_head(p) != orig_head) check cover the case you mentioned?

This check covers when the page p is included into the compound page with *different* size from thp (for example, included into slab pages or hugepages in other size).

If p was originally in a 2MB thp before split and then is now included in another 2MB thp after the page lock, compound_head(p) is equal to orig_head, so it passes over this check.

Thanks,
Naoya Horiguchi

  reply	other threads:[~2020-09-08  9:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  3:44 yaoaili126
2020-09-08  7:02 ` HORIGUCHI NAOYA(堀口　直也)
2020-09-08  7:18   ` yaoaili [么爱利]
2020-09-08  7:26   ` Oscar Salvador
2020-09-08  8:02     ` yaoaili [么爱利]
2020-09-08  8:09       ` Oscar Salvador
2020-09-08  8:36     ` HORIGUCHI NAOYA(堀口　直也)
2020-09-08  8:48       ` yaoaili [么爱利]
2020-09-08  9:00         ` HORIGUCHI NAOYA(堀口　直也)
2020-09-08  9:10           ` yaoaili [么爱利] [this message]
2020-09-08  8:51       ` Oscar Salvador
2020-09-08  9:05         ` HORIGUCHI NAOYA(堀口　直也)
2020-09-18  9:35           ` Oscar Salvador
2020-09-25  1:18             ` HORIGUCHI NAOYA(堀口　直也)
2020-09-25  1:55               ` yaoaili [么爱利]
2020-09-25  4:35                 ` HORIGUCHI NAOYA(堀口　直也)
2020-09-25  5:52                   ` yaoaili [么爱利]
  -- strict thread matches above, loose matches on Subject: below --
2020-09-02 11:24 [PATCH] fix " yaoaili [么爱利]
2020-09-02 11:35 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9492b81a2e9046eaa3e4028c1f0e7879@kingsoft.com \
    --to=yaoaili@kingsoft.com \
    --cc=YANGFENG1@kingsoft.com \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=osalvador@suse.de \
    --cc=willy@infradead.org \
    --cc=yaoaili126@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox